Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • May 12 11:45
    davesmith00000 synchronize #14
  • May 12 10:22
    davesmith00000 opened #14
  • May 13 2018 13:27
    julienrf opened #13
  • Feb 08 2018 12:21
    julienrf commented #12
  • Feb 08 2018 12:21

    julienrf on master

    support input events for input … (compare)

  • Feb 08 2018 12:21
    julienrf closed #12
  • Feb 08 2018 12:19
    battermann edited #12
  • Feb 08 2018 12:16
    battermann synchronize #12
  • Feb 08 2018 12:15
    battermann review_requested #12
  • Feb 08 2018 12:15
    battermann opened #12
  • Feb 05 2018 08:28
    battermann added as member
  • Jan 28 2018 20:20
    julienrf commented #8
  • Jan 28 2018 20:20

    julienrf on master

    elm inspired HTTP API Merge pull request #8 from batt… (compare)

  • Jan 28 2018 20:20
    julienrf closed #8
  • Jan 27 2018 11:11
    battermann synchronize #8
  • Jan 27 2018 11:07
    battermann synchronize #8
  • Jan 26 2018 19:06
    battermann synchronize #8
  • Jan 26 2018 18:51
    battermann synchronize #8
  • Jan 26 2018 08:43
    battermann synchronize #8
  • Jan 25 2018 21:20
    battermann edited #8
Julien Richard-Foy
@julienrf
hello, I’ve just released a 1.0.0-RC1
we can do a 1.0.0 after your HTTP PR is merged if you want
the revision is not that important
but I think 1.0.0 is fine since I’ve been using it for one year
Leif Battermann
@battermann
sounds good
I'd also suggest to add a few more wrappers for HTML tags, like form, p, etc. and maybe a class attribute wrapper as well?
Maybe even some more event wrappers like onInput? It would be nice if they were typed so that they can only be applied to valid html tags.
Leif Battermann
@battermann
But this can be done after the 1.0.0 release, off course.
Cool, that the binary lib is published now :)
Leif Battermann
@battermann
do you have preferences for a specific testing lib?
any recommendations for testing http requests?
would you do separate test configs for unit and integration tests?
Julien Richard-Foy
@julienrf
I agree with having more tags and attributes wrappers
I like using scalacheck for writing tests
I wouldn't use different configs unless we need to
Julien Richard-Foy
@julienrf
Testing the HTTP API might require an elaborate setup. I don't know if that would work with jsdom
Otherwise we will need to use selenium
Leif Battermann
@battermann
It should work together with jQuery as described here https://www.scala-js.org/tutorial/basic/index.html. I'll give it a try.
But we can only do end to end tests, right?
Probably heard to test Http in isolation, I guess.
Julien Richard-Foy
@julienrf
The implementation of Http.send command creates an XMLHttpRequest, so to test this command you’ll have to setup an end to end test, yes
Leif Battermann
@battermann
Not sure if I have to set up a complete program to test it or if I can execute the Cmd from the test...
Leif Battermann
@battermann
Hi, we're building a small front end with scalm for a work project now :) Anyway, I would like to configure hot reloading as described here: https://scalacenter.github.io/scalajs-bundler/cookbook.html#webpack-dev-server. My problem is that, when I start the dev server, it runs in the target/scala-2.12/scalajs-bundler/ as root folder. My html files however are defined in the resources folder and therefore compiled in target/scala-2.12/classes. They can not be accessed by the web server. How do I need to set up my project so that this works?
Julien Richard-Foy
@julienrf
Leif Battermann
@battermann
ok, I'll try that, thx
Leif Battermann
@battermann
This also works: webpackDevServerExtraArgs := Seq("--content-base", "../../../..", "--inline")
although hot reloading is not working so far
Leif Battermann
@battermann
Sorry that the HTTP PR is taking so long, I plan to work on it tonight, and hope to finish it for the most part. Anyway I still don't have a good end to end testing strategy. The efforts seem to be almost unreasonable. (As http is only a thin wrapper around some scalm core functionality.) I will try to factor out the logic from the calls to the scalm core implementation and will try to test that in isolation.
Julien Richard-Foy
@julienrf
No worries :)
Indeed I didn’t make any effort so far to get a productive end to end testing infrastructure…
But that’s definitely a useful thing to have
I think we should try to setup selenium for that
what do you think? (or is there any new and better tool for running tests in a browser?)
Julien Richard-Foy
@julienrf
cypress.io looks interesting as well
I have never tried it though
Leif Battermann
@battermann
Well, I have almost no experience with frontend testing. :D Why do we need a browser test? Wouldn't it be sufficient to use jsdom and jQuery? (Maybe for HTTP request, we will need a browser, I'm not sure.)
Julien Richard-Foy
@julienrf
jsdom could be an alternative to selenium, yes
my experience with it so far has not been extremely pleasant though
we don’t need jQuery
and yes, we might need to mock an HTTP server
Leif Battermann
@battermann
Javier Salcedo
@salc2
Hi there guys
Leif Battermann
@battermann
hey
Javier Salcedo
@salc2
putting myself update with the conversation
about the e2e test
Javier Salcedo
@salc2
What do you think about create issues, just to know what is missing. e.g: extends html tag wrappers to all real one.
Leif Battermann
@battermann
Issues would be great, might also encourage others to collaborate, imo.
Javier Salcedo
@salc2
totally
Julien Richard-Foy
@julienrf
sure, go ahead!
Javier Salcedo
@salc2
:+1: