Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • May 12 11:45
    davesmith00000 synchronize #14
  • May 12 10:22
    davesmith00000 opened #14
  • May 13 2018 13:27
    julienrf opened #13
  • Feb 08 2018 12:21
    julienrf commented #12
  • Feb 08 2018 12:21

    julienrf on master

    support input events for input … (compare)

  • Feb 08 2018 12:21
    julienrf closed #12
  • Feb 08 2018 12:19
    battermann edited #12
  • Feb 08 2018 12:16
    battermann synchronize #12
  • Feb 08 2018 12:15
    battermann review_requested #12
  • Feb 08 2018 12:15
    battermann opened #12
  • Feb 05 2018 08:28
    battermann added as member
  • Jan 28 2018 20:20
    julienrf commented #8
  • Jan 28 2018 20:20

    julienrf on master

    elm inspired HTTP API Merge pull request #8 from batt… (compare)

  • Jan 28 2018 20:20
    julienrf closed #8
  • Jan 27 2018 11:11
    battermann synchronize #8
  • Jan 27 2018 11:07
    battermann synchronize #8
  • Jan 26 2018 19:06
    battermann synchronize #8
  • Jan 26 2018 18:51
    battermann synchronize #8
  • Jan 26 2018 08:43
    battermann synchronize #8
  • Jan 25 2018 21:20
    battermann edited #8
Julien Richard-Foy
@julienrf
Otherwise we will need to use selenium
Leif Battermann
@battermann
It should work together with jQuery as described here https://www.scala-js.org/tutorial/basic/index.html. I'll give it a try.
But we can only do end to end tests, right?
Probably heard to test Http in isolation, I guess.
Julien Richard-Foy
@julienrf
The implementation of Http.send command creates an XMLHttpRequest, so to test this command you’ll have to setup an end to end test, yes
Leif Battermann
@battermann
Not sure if I have to set up a complete program to test it or if I can execute the Cmd from the test...
Leif Battermann
@battermann
Hi, we're building a small front end with scalm for a work project now :) Anyway, I would like to configure hot reloading as described here: https://scalacenter.github.io/scalajs-bundler/cookbook.html#webpack-dev-server. My problem is that, when I start the dev server, it runs in the target/scala-2.12/scalajs-bundler/ as root folder. My html files however are defined in the resources folder and therefore compiled in target/scala-2.12/classes. They can not be accessed by the web server. How do I need to set up my project so that this works?
Julien Richard-Foy
@julienrf
Leif Battermann
@battermann
ok, I'll try that, thx
Leif Battermann
@battermann
This also works: webpackDevServerExtraArgs := Seq("--content-base", "../../../..", "--inline")
although hot reloading is not working so far
Leif Battermann
@battermann
Sorry that the HTTP PR is taking so long, I plan to work on it tonight, and hope to finish it for the most part. Anyway I still don't have a good end to end testing strategy. The efforts seem to be almost unreasonable. (As http is only a thin wrapper around some scalm core functionality.) I will try to factor out the logic from the calls to the scalm core implementation and will try to test that in isolation.
Julien Richard-Foy
@julienrf
No worries :)
Indeed I didn’t make any effort so far to get a productive end to end testing infrastructure…
But that’s definitely a useful thing to have
I think we should try to setup selenium for that
what do you think? (or is there any new and better tool for running tests in a browser?)
Julien Richard-Foy
@julienrf
cypress.io looks interesting as well
I have never tried it though
Leif Battermann
@battermann
Well, I have almost no experience with frontend testing. :D Why do we need a browser test? Wouldn't it be sufficient to use jsdom and jQuery? (Maybe for HTTP request, we will need a browser, I'm not sure.)
Julien Richard-Foy
@julienrf
jsdom could be an alternative to selenium, yes
my experience with it so far has not been extremely pleasant though
we don’t need jQuery
and yes, we might need to mock an HTTP server
Leif Battermann
@battermann
Javier Salcedo
@salc2
Hi there guys
Leif Battermann
@battermann
hey
Javier Salcedo
@salc2
putting myself update with the conversation
about the e2e test
Javier Salcedo
@salc2
What do you think about create issues, just to know what is missing. e.g: extends html tag wrappers to all real one.
Leif Battermann
@battermann
Issues would be great, might also encourage others to collaborate, imo.
Javier Salcedo
@salc2
totally
Julien Richard-Foy
@julienrf
sure, go ahead!
Javier Salcedo
@salc2
:+1:
Javier Salcedo
@salc2
julienrf/scalm#11
Leif Battermann
@battermann
Hey, I'd say the julienrf/scalm#8 is ready for review. I don't have any tests, yet. But I did some manual testing. If we agree on a testing strategy, I will add some.
Julien Richard-Foy
@julienrf
Excellent, I’ll have a look ASAP
Leif Battermann
@battermann
This would be cool, too: https://47deg.github.io/sbt-microsites/ or something of the like
Julien Richard-Foy
@julienrf
indeed, I prefer having a dedicated documentation website than a readme
I’m not a big fan of sbt-microsites though
Leif Battermann
@battermann
@salc2 how did you do the squash on your PR? I tried git rebase -i <after_this_commit> and replaced pick with squash. But that didn't work out. I had to pull and merge before I could push, and after that the old history popped up again.
Ah, it's git push --force, right?
Julien Richard-Foy
@julienrf
you run git rebase -i master you replace pick with f (or fixup), except for the first commit, and then do a git push --force, or a git push <your_fork> feature/http_api:feature/http_api-squashed if you don’t want to push force.
Leif Battermann
@battermann
I get a merge conflict. I have to look at it carefully when I have more time.
Leif Battermann
@battermann
few, I think, I managed to successfully squash... after I went through a merging hell ;-) (not sure if I did it right, the result looks right, though)
Javier Salcedo
@salc2
@battermann hey sorry for the late response. Yes this rebase thing is the hell lol.
The truth is a screwed it up... so I had to create another branch haha
I wonder how could we achieve the feature "Merge and Squash" which have some repos?
Btw. What do you guys think about raquo comment in julienrf/scalm#11
Is really neccesary a complete html third party library?