Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • May 13 2018 13:27
    julienrf opened #13
  • Feb 08 2018 12:21
    julienrf commented #12
  • Feb 08 2018 12:21

    julienrf on master

    support input events for input … (compare)

  • Feb 08 2018 12:21
    julienrf closed #12
  • Feb 08 2018 12:19
    battermann edited #12
  • Feb 08 2018 12:16
    battermann synchronize #12
  • Feb 08 2018 12:15
    battermann review_requested #12
  • Feb 08 2018 12:15
    battermann opened #12
  • Feb 05 2018 08:28
    battermann added as member
  • Jan 28 2018 20:20
    julienrf commented #8
  • Jan 28 2018 20:20

    julienrf on master

    elm inspired HTTP API Merge pull request #8 from batt… (compare)

  • Jan 28 2018 20:20
    julienrf closed #8
  • Jan 27 2018 11:11
    battermann synchronize #8
  • Jan 27 2018 11:07
    battermann synchronize #8
  • Jan 26 2018 19:06
    battermann synchronize #8
  • Jan 26 2018 18:51
    battermann synchronize #8
  • Jan 26 2018 08:43
    battermann synchronize #8
  • Jan 25 2018 21:20
    battermann edited #8
  • Jan 25 2018 21:19
    battermann edited #8
  • Jan 25 2018 21:18
    battermann synchronize #8
Julien Richard-Foy
@julienrf
my experience with it so far has not been extremely pleasant though
we don’t need jQuery
and yes, we might need to mock an HTTP server
Leif Battermann
@battermann
Javier Salcedo
@salc2
Hi there guys
Leif Battermann
@battermann
hey
Javier Salcedo
@salc2
putting myself update with the conversation
about the e2e test
Javier Salcedo
@salc2
What do you think about create issues, just to know what is missing. e.g: extends html tag wrappers to all real one.
Leif Battermann
@battermann
Issues would be great, might also encourage others to collaborate, imo.
Javier Salcedo
@salc2
totally
Julien Richard-Foy
@julienrf
sure, go ahead!
Javier Salcedo
@salc2
:+1:
Javier Salcedo
@salc2
julienrf/scalm#11
Leif Battermann
@battermann
Hey, I'd say the julienrf/scalm#8 is ready for review. I don't have any tests, yet. But I did some manual testing. If we agree on a testing strategy, I will add some.
Julien Richard-Foy
@julienrf
Excellent, I’ll have a look ASAP
Leif Battermann
@battermann
This would be cool, too: https://47deg.github.io/sbt-microsites/ or something of the like
Julien Richard-Foy
@julienrf
indeed, I prefer having a dedicated documentation website than a readme
I’m not a big fan of sbt-microsites though
Leif Battermann
@battermann
@salc2 how did you do the squash on your PR? I tried git rebase -i <after_this_commit> and replaced pick with squash. But that didn't work out. I had to pull and merge before I could push, and after that the old history popped up again.
Ah, it's git push --force, right?
Julien Richard-Foy
@julienrf
you run git rebase -i master you replace pick with f (or fixup), except for the first commit, and then do a git push --force, or a git push <your_fork> feature/http_api:feature/http_api-squashed if you don’t want to push force.
Leif Battermann
@battermann
I get a merge conflict. I have to look at it carefully when I have more time.
Leif Battermann
@battermann
few, I think, I managed to successfully squash... after I went through a merging hell ;-) (not sure if I did it right, the result looks right, though)
Javier Salcedo
@salc2
@battermann hey sorry for the late response. Yes this rebase thing is the hell lol.
The truth is a screwed it up... so I had to create another branch haha
I wonder how could we achieve the feature "Merge and Squash" which have some repos?
Btw. What do you guys think about raquo comment in julienrf/scalm#11
Is really neccesary a complete html third party library?
Julien Richard-Foy
@julienrf
I think we should at least support all tag names
supporting all attributes requires more work
Javier Salcedo
@salc2
OK, so a third party library like scalatags or this that "raquo" suggested is no really necessary right?
Julien Richard-Foy
@julienrf
why not if they save us some work, but no it is not necessary. That being said it’s probably subjective but I don’t like the fact that scalatags and scala-dom-types mix attributes and children elements in the same parameters list
Javier Salcedo
@salc2
makes sense
Leif Battermann
@battermann
@julienrf When are you going to publish a new release?
Julien Richard-Foy
@julienrf
No precise plan actually…
I can publish an RC2 with the cool HTTP thing
Leif Battermann
@battermann
I could use it in current project, where I reimplemented the HTTP stuff, it would be nice to be able to reduce our source code, though. But no hurry, really.
Julien Richard-Foy
@julienrf
What do you need for a 1.0.0 ?
Leif Battermann
@battermann
really not much more so far. I’ve implemented a few more HTML tags, but this is marginal
Leif Battermann
@battermann
a small PR for input fields: julienrf/scalm#12
Leif Battermann
@battermann
@julienrf Have you ever tried to build pagination with scalm?
I can build it from scratch. Though I’m not sure whether I could reuse some stuff, maybe use a scala js lib for that, but I don’t know how that integrates with the elm arch?
What would be your approach?
Julien Richard-Foy
@julienrf
No I haven’t!
Actually I don’t even know JS libraries that do that
To my experience pagination is hard to implement in a generic way
Leif Battermann
@battermann
AFAIK
... if the web service implements the right protocol like e.g. OData, there out of the box client solutions.
So in scalm you would implement it from scratch?