hi guys, if curious, here's a PR I've made...it has 2 commits (read individually) 1. Pulls out a bunch of stuff from jumpy-view to a labels.coffee ... 2. refactors a bunch of code with mobx..... The mobx added net 19 more LOC according to the stat, but I think the code is a lot cleaner / flexible. @johngeorgewright I think your PR for tree view....the labels can be almost unioned in...I had an idea, but I'd have to rethink about it...
There's a small outstanding 2 bugs with "Jump Mode!" in the status on open (2nd time) and with too many calls to reset (the backspace) ....I'll make 2 tests tonight, and can probably fix both with one line of initialization / reset or something.Hold off a little maybe before reapplying your work... I have to re read your stuff and see how difficult it would be for you to apply the same approach on top (probably cut and pasting some code on top of the new master would be easiest... I don't want to just steal your stuff I want you to get credit :smile:
I'm pretty gung ho about this mobx approach though. Unless everyone thinks I'm nuts...
BTW, new Atom release the tests run in half the time (master branch too)..
I think you'll like it.....it should be easy to copy the new tabs labeling feature .....one file 100 LOCish and turn it into tree view. I did the tabs functionality because I thought it was easier, and wanted to see if you wanted to take a look at another round of the tree view (all of your styling code should still work I might be able to cherry pick it in)
wordsPattern, right? And then I would have to remove
Hi, thanks for responding! I got it working the way it worked before for me! :) However, it's really hacky and there are some things I simply don't understand, like for example why you have to use
this.commands.add(atom.commands.add(/*.....*/)) and why simply calling
atom.commands.add(/*.....*/) isn't working anymore.
As soon as I find the time again I'll look into it again, clean my code a little and put it in a gist. :)