Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • 22:15
    dependabot[bot] labeled #90
  • 22:15
    dependabot[bot] opened #90
  • 22:15

    dependabot[bot] on npm_and_yarn

    Bump node-fetch from 2.6.1 to 2… (compare)

  • 20:10
    jasongrout commented #1006
  • 20:10
    jasongrout commented #1006
  • 20:02
    jasongrout synchronize #3491
  • 19:05
  • 16:38
    vidartf milestoned #3503
  • 16:38
    vidartf labeled #3503
  • 16:38
    vidartf labeled #3503
  • 16:37

    vidartf on master

    Make notebook name more accurate Add "Learning Widgets" section … Merge pull request #3504 from m… (compare)

  • 16:37
    vidartf closed #3504
  • 14:34
    github-actions[bot] commented #3504
  • 14:34
    mwcraig milestoned #3504
  • 14:34
    mwcraig labeled #3504
  • 14:34
    mwcraig opened #3504
  • 08:54

    martinRenou on master

    Install jupyterlite-sphinx from… Add example directory to the ju… Add more example notebooks to J… and 2 more (compare)

  • 08:54
    martinRenou closed #1006
martinRenou
@martinRenou
Thanks @jasongrout !
martinRenou
@martinRenou
@jasongrout as you saw there is the notebook dependency in widgetsnbextension that is annoying for emscripten environments. But the ipywidgets -> ipykernel dependency is annoying as well.
this dependency has been inconvenient for xeus-python too
ideally I'd like ipywidgets to pull the Comms implementation from a separate package than ipykernel
it's not ideal
Jason Grout
@jasongrout
Sure, breaking those dependencies sounds good, if it works out
By the way, while you're here @martinRenou - it would be really great if we could give a separate contents directory option to jupyterlite (i.e., https://github.com/jupyterlite/jupyterlite-sphinx/issues/17#issuecomment-1163923233). This would allow us to easily expose the really awesome examples directories we have in ipyleaflet and ipywidgets via jupyterlite.
i.e., it would be great if the ipywidgets/ipyleaflet docs had a "click here to explore a lot of examples using jupyterlite" link
martinRenou
@martinRenou
yes definitely :+1: I had a PR jupyterlite/jupyterlite-sphinx#24 it probably needs a bit of testing
Jason Grout
@jasongrout
I tried using the jupyterlite_config.json contents option, but it didn't seem to do anything
martinRenou
@martinRenou
I was about to suggest this
Jason Grout
@jasongrout
I was going off of https://jupyterlite.readthedocs.io/en/latest/howto/content/files.html#content-with-the-cli ("the #/LiteBuildConfig/contents in jupyter_lite_config.json")
should that config option have worked? I tried both with a relative and absolute directory
martinRenou
@martinRenou
I guess it should have yes
I never used it personally
Jason Grout
@jasongrout
i.e., I tried something like:
diff --git a/docs/source/jupyterlite_config.json b/docs/source/jupyterlite_config.json
index 816d221..decf663 100644
--- a/docs/source/jupyterlite_config.json
+++ b/docs/source/jupyterlite_config.json
@@ -5,6 +5,7 @@
         "https://files.pythonhosted.org/packages/py2.py3/i/ipyleaflet/ipyleaflet-0.16.0-py2.py3-none-any.whl"
       ],
       "ignore_sys_prefix": true,
+      "contents": ["../../examples"],
       "piplite_urls": [
         "https://files.pythonhosted.org/packages/py2.py3/i/ipyleaflet/ipyleaflet-0.16.0-py2.py3-none-any.whl",
         "https://files.pythonhosted.org/packages/py2.py3/i/ipython-genutils/ipython_genutils-0.2.0-py2.py3-none-any.whl",
in ipyleaflet
martinRenou
@martinRenou
what are the jupyter lite logs?
Jason Grout
@jasongrout
it just showed the single ipyleaflet.ipynb file it normally finds (from the --contents option)
martinRenou
@martinRenou
I wonder if the CLI option jupyterlite-sphinx adds doesn't overwrite the contents config entry https://github.com/jupyterlite/jupyterlite-sphinx/blob/main/src/jupyterlite_sphinx.py#L276
Jason Grout
@jasongrout
I was wondering that too
in general, can I expect any jupyterlite config option in that file to work?
(and I wasn't sure if relative URLs worked)
martinRenou
@martinRenou
ideally yes. Though for relative paths I don't know.
Jason Grout
@jasongrout
to me, that PR looks pretty good
I like that it doesn't flatten the directory structure too
Jason Grout
@jasongrout
@martinRenou - it looks like it might have been two things: 1. the config file was in the source directory, not the root directory, so it was actually never getting used, and 2. the command line argument is overriding the config option, so you're right there
also, it's a little weird that in jupyterlite, the config file is jupyter_lite_config.json, but in jupyterlite-sphinx, the default is jupyterlite_config.json
martinRenou
@martinRenou

the command line argument is overriding the config option, so you're right there

We should probably open an issue to the JupyterLite repo for this. It sounds like an issue.

thanks for the issue on jupyterlite-sphinx! We should make it more consistent indeed
Jason Grout
@jasongrout
The overriding is a jupyter thing. A command line argument always overrides a file config value
I guess there isn't a provision for merging a command line thing and a file config value...
martinRenou
@martinRenou
oh ok I see
Jason Grout
@jasongrout
See https://docs.jupyter.org/en/latest/use/config.html#command-line-options-for-configuration: "Command line options will override options set within a configuration file."
Jason Grout
@jasongrout
@martinRenou - the problem in jupyterlite/jupyterlite-sphinx#24 was a small typo :)
Jan-Hendrik Müller
@kolibril13
In the package jupyter-capture-output I've made Jupyter cell magics to capture Jupyter output like Text, Image, Video and more formats on the wishlist. Thanks to the latest JupyterLite v0.1.0b9 release with read+write options, this can now be tried at: https://kolibril13.github.io/jupyter-capture-output
1 reply
Jason Grout
@jasongrout
@kolibril13 - very nice!
@martinRenou - if you want to make a new jupyterlite-sphinx release with that contents option, I'll try to get it working with ipyleaflet and ipywidgets to expose the example directory before releasing
Or I'm happy to help with releases/development too if you want to give me permissions
martinRenou
@martinRenou
should we merge this before? jupyterlite/jupyterlite-sphinx#58
let me see if I can give you permission
Duc Trung Le
@trungleduc
@kolibril13 thanks for sharing, it's cool!
martinRenou
@martinRenou
@jasongrout posting here in case you miss my message on Github: You should have received an invitation to the jupyterlite org and for having commit rights on the jupyterlite-sphinx repo :) You probably need to accept it. I will let you merge my PR if you're ok :D
Jason Grout
@jasongrout
Yep, sounds good. Thanks!
Jan-Hendrik Müller
@kolibril13
Thanks for the nice feedback!
Contributions to jupyter-capture-output are always welcome :)
For the project jupyter-splitview there is now also a JupyterLite version available here, thanks to @psychemedia. I've also made a Tweet about the splitview widget 🐦
Jason Grout
@jasongrout
@martinRenou - on second thought about the config options renaming - let's have a broader conversation with other jupyterlite folks about whether jupyterlite is one word or two words - it seems jupyterlite isn't consistent in that in their code.
However, I think jupyterlite/jupyterlite-sphinx#59 probably makes sense to get in before a release as a minor maintenance item