These are chat archives for juttle/juttle

5th
Feb 2016
Phil Rzewski
@philrz
Feb 05 2016 20:57

@rlgomes: The examples in the Graphite Adatper README don't work as written. WIth the "name" filtering coming before the "-from", error message comes up:

Error: from is not defined (RT-UNDEFINED)

If I switch the order, it works.

Rodney Lopes Gomes
@rlgomes
Feb 05 2016 21:09
switch the order ?
Daria Mehra
@dmehra
Feb 05 2016 21:09
Thanks @philrz if you feel like putting up a PR with the change, that'd be great. For markdown docs you can do it right in the github UI
Rodney Lopes Gomes
@rlgomes
Feb 05 2016 21:10
and that sounds alot like a parser issue as the adapter doen't decide the order of parameters
Daria Mehra
@dmehra
Feb 05 2016 21:11
I think we have a requirement that all -options come before the filter expression
Rodney Lopes Gomes
@rlgomes
Feb 05 2016 21:11
humm actually now this does ring a bell as you can't have the parameters before the filter expression and maybe that change happened after the README was updated
Michael Demmer
@demmer
Feb 05 2016 21:11
That is absolutely the case
The grammar rule is effectively
read <adapter> [options]? [filter]?
Phil Rzewski
@philrz
Feb 05 2016 21:26
Thanks @dmehra. Since it was the Markdown doc, I edited it in the GitHub UI. (Only now do I realize that the "do it" you meant was probably putting up the PR, whereas I hit the immediate commit-to-master button. Oops. But since it feels like you all just effectively signed off on the fix, I'm not flagellating myself over it and will just do better next time. :) )
Daria Mehra
@dmehra
Feb 05 2016 23:51
you did great @philrz ! yes, best to pick the branch option for a PR, but this one was good to go. also, if we care enough, we could lock out commits on master...