by

Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
    Martin Beták
    @matobet
    But at least is not scalaz :D
    Tomas Jelinek
    @jelkosz
    first trying to understand what did you do with it :) Damn, I start to feel like I don't know scala anymore :)
    the last iteration was nearly only on the frontend...
    Tomas Jelinek
    @jelkosz
    ahhh, finally got it
    but we don't need to do it this sophistically, do we?
    it is not a matching of List[A] and List[B]
    but a match of List and BasicDbList
    Martin Beták
    @matobet
    well I guess we could take the BasicDbList as default and if that doesnt' match, always assume it is List[ObjectId], but as I'm no mongo expert I don't know how future proof that would be
    I just disliked the "@unchecked" this would require
    Sorry @unchecked, didn't mean to mention you, I just meant the scala annotation :D
    Tomas Jelinek
    @jelkosz
    well, in MigrateDb.scala you don't need to do any special check since you don't mind what the type of the int is
    lol :DDD
    so back to the migratedb
    tasks match {
    case xs: List[_] =>
    xs.contains(id.get)
    case xs: BasicDBList =>
    xs.contains(id.get)
    }
    this is completely fine since we need only the contains
    Project.scala is more funny...
    case List[ObjectId](xs) => ...
    this does not make it more future proofe
    the thing is that we can not handle anything else anyway...
    and we are talking to a lib which returns an Object
    Martin Beták
    @matobet
    do you get any warnings when you do List[_] instead of using TypeCase?
    Tomas Jelinek
    @jelkosz
    in migratedb no
    because I'm not casting it to anything else
    also this is without warnings:dbObject match {
    case ids: List[_] =>
    ids.asInstanceOf[List[ObjectId]]
    case ids: BasicDBList =>
    ids.toArray.toList.asInstanceOf[List[ObjectId]]
    Martin Beták
    @matobet
    Ok, maybe if this List[ObjectId]/BasicDbList is common enough maybe it would be worth encapsulating this match in a common function (\@unchecked even) and using that
    Tomas Jelinek
    @jelkosz
    you keep mentioning @ unchecked :D
    Martin Beták
    @matobet
    I tried to escape it :D
    Tomas Jelinek
    @jelkosz
    why? Maybe he is a nice guy :)
    Martin Beták
    @matobet
    or lady ;)
    Tomas Jelinek
    @jelkosz
    yeah, according to the github pictures one can never know
    mmm, seems to be common enough, just the codebase is small enough so the absolute num of occurrences is not too big :)
    it may be worth trying to extract it somehow, but not sure how would that look like exactly
    Tomas Jelinek
    @jelkosz
    @kasicka I've set your pot as the project logo in google page: https://code.google.com/p/kanbanik/ :)
    @matobet hmmm, does not seem to be that common anymore as looking at it again... Only on that two places while in MigrateDb it does not really matter what type it is so we don't need any cast. So seems that only one place
    Martin Beták
    @matobet
    @jelkosz on other matter, I made a patch that upgrades all dependencies (thanx to maven versions plugin that was pretty easy - after I discovered it after 3 painful manual searches for new versions :)) all went well except that lift-json supports scala 2.11 only in 3.0-M2 version
    not sure how we feel about using snapshot versions
    Zuzana Svetlíková
    @kasicka
    I'm glad you like it :D I'll have a look at that python script once the semester is over
    Tomas Jelinek
    @jelkosz
    @matobet I'd say it is fine - we can use a snapshot version in the devel branch and until we get to a new release, they will for sure have a stable version...
    @matobet going to verify if it works and if yes, I'll merge it
    Martin Beták
    @matobet
    I'm right now fix my warnings patch to drop the shapeless dep and then look at that upgrade patch
    Tomas Jelinek
    @jelkosz
    ahh, you have not created a pull request yet - and I was surprised why don't I see it :)
    Martin Beták
    @matobet
    yeah, I was also dealing with android for a while :)
    Tomas Jelinek
    @jelkosz
    really? Don't tell me it was moVirt - that great oVirt client! :D
    Martin Beták
    @matobet
    actually it was! I know, what a great application :D
    Tomas Jelinek
    @jelkosz
    it reminds me I wanted to setup kanbanik on cloudspin and setup movirt to monitor it today evening
    and I also wanted to go to sleep early
    hmmmmm
    Martin Beták
    @matobet
    go to bed, tomorrow you'll have 2 patches waiting for review, hopefully :)
    Martin Beták
    @matobet
    @jelkosz ok scala warnings seem to be ok but what about [WARNING] Declared compileSourcesArtifact was not found in project dependencies kanbanik:web:jar
    in GWT phase?
    Martin Beták
    @matobet
    @jelkosz made PRs for #5 warnings and #9 upgrade