Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Jul 16 22:01
    snyk-bot opened #295
  • Jul 16 22:01

    saiichihashimoto on snyk-fix-06c3e0ff9880aade54daa2c7f0b8ab64

    fix: package.json to reduce vul… (compare)

  • Jul 16 22:01

    saiichihashimoto on snyk-fix-06c3e0ff9880aade54daa2c7f0b8ab64

    (compare)

  • Jul 09 22:01
    snyk-bot opened #294
  • Jul 09 22:01

    saiichihashimoto on snyk-fix-73f5704f643772fd0103b023ececfd69

    fix: package.json to reduce vul… (compare)

  • Jul 09 22:01

    saiichihashimoto on snyk-fix-73f5704f643772fd0103b023ececfd69

    (compare)

  • Apr 30 22:02
    snyk-bot opened #293
  • Apr 30 22:02

    saiichihashimoto on snyk-fix-9353f41681ec1be73002b1f8f6af276e

    fix: package.json & .snyk to re… (compare)

  • Apr 30 22:02

    saiichihashimoto on snyk-fix-9353f41681ec1be73002b1f8f6af276e

    fix: package.json & .snyk to re… (compare)

  • Apr 30 22:02

    saiichihashimoto on snyk-fix-9353f41681ec1be73002b1f8f6af276e

    (compare)

  • Apr 06 22:01
    snyk-bot opened #292
  • Apr 06 22:01

    saiichihashimoto on snyk-fix-a89a51e2bb9ea973fc7e1116e0519989

    fix: package.json to reduce vul… (compare)

  • Apr 06 22:01

    saiichihashimoto on snyk-fix-a89a51e2bb9ea973fc7e1116e0519989

    (compare)

  • Mar 06 22:01
    snyk-bot opened #291
  • Mar 06 22:01

    saiichihashimoto on snyk-upgrade-970859ca2478a34018d37dd71863281e

    (compare)

  • Mar 06 22:01

    saiichihashimoto on snyk-upgrade-970859ca2478a34018d37dd71863281e

    fix: upgrade passport from 0.3.… (compare)

  • Oct 02 2019 01:36
    saiichihashimoto commented #290
  • Oct 01 2019 21:45
    brianroach commented #290
  • Aug 19 2019 18:48
    saiichihashimoto commented #290
  • Aug 19 2019 17:46
    brianroach commented #290
Saiichi Hashimoto
@saiichihashimoto
Setting up this room
Saiichi Hashimoto
@saiichihashimoto
Hey everyone! We just made HoverCards open to the public, so feel free to check it out! We don't have any real documentation yet, but we'll get there. :-)
Gabin Aureche
@Zhouzi
Hey there! I've been using hovercards for quite some time now and I've been pleasingly surprised to see it has been open sourced. I'd be glad to contribute, there's one thing though that's making the onboarding hard. I didn't expect to see that level of complexity, there are lots of stuff going on and the grouping doesn't help much at giving a clear picture of the architecture. e.g I hardly associate the root folders (is "components" the website's components? or the extension?). Would it be okay if I start by working out on documenting the architecture? How the different pieces work together? And then would you be ok to discuss further simplifications? (splitting the different pieces in relevant parts)
Saiichi Hashimoto
@saiichihashimoto
Yeah, that would be awesome! I thought that documentation would be pretty important but I haven't gotten around to it.
I personally like how it's architected, but that's because I did the architecting and, so far, it's mostly been just for myself. :-)
Gabin Aureche
@Zhouzi
Great, will see what I can come up with :)
Saiichi Hashimoto
@saiichihashimoto
Hey @Zhouzi, maybe it'll help if explain the "philosophy" behind the architecture. When I'm developing, I wanted to find things by concern. If my concern is the layout/hierarchy of the components, I can dive into components and find what I want. If something is going on with the integrations, I'd dive into integrations and so on. I found that organizing the structure by filetypes or by feature sets missed the point. Containing the code for a feature separately often breaks code up in ways that ends up being convoluted and only gives the semblance of modularity. In reality, any future features or bugfixes ends up snaking through all of it anyways. This way, features and changes DO end up making changes across the board, but everything is where I'd expect it to be. I hope this helps with the documentation you're thinking of. :-)
Gabin Aureche
@Zhouzi
Hey @saiichihashimoto! Sorry for the delay. Yeah, definitely makes sense. Still have to fully understand the architecture on a higher level though (how the extension communicates with the server, how is the site built, ...). To be honest I've been looking at the code and feel like I've been missing lots of features according to the amount of things in the repo. It would probably take some time before feeling comfortable with the code base, will see ^^ Anyway, keep up the good work!
Saiichi Hashimoto
@saiichihashimoto
Thanks @Zhouzi! If there's anything you want me to elaborate on, let me know!
Abd ar-Rahman Hamidi
@hbakhtiyor
Hey guys
Anyone there?
Does it have browser version? meaning I can add the script to my website and visitor hover my social links and the pop-up appear
what the purpose of the server? can just fetch the data from client & cache data in visitor's browser
without any server
Abd ar-Rahman Hamidi
@hbakhtiyor
anyone alive there?
Thibaut Schaeffer
@Schaeff

Hi @saiichihashimoto! I’d like to start playing with Hovercards and hopefully extend it, any chance you could tell a bit more about the architecture?

  • Where is the logic adding hover listeners?
  • What’s the general idea?

I see you described it earlier it this channel however it would be helpful to get up to speed

Kaustubh Hiware
@kaustubhhiware
Hi!
I have just been checking out hovercards, and it looks great
However, in my experience it works fine on facebook.com/messages, but not on messenger.com . Any plausible reasons ?
Saiichi Hashimoto
@saiichihashimoto
Sorry about the enormous delay, somehow gitter only notified me of these messages recently.
@hbakhtiyor there is no browser version. Though, that could be interesting to implement! The server is needed for some of the APIs, since there's app secrets associated with them. The APIs that could be done entirely from the extension don't hit the server at all.
@Schaeff I haven't worked on hovercards in quite a while so I'd have to give it a look over. Let me know if you're still interested, it's been quite a while since your message.
@kaustubhhiware I'm not sure. Some of these use their own redirect links to the content, probably to track what content is being clicked. We've gotten hovercards to detect some of them but not all of them. Chances are, facebook.com/messages uses a different redirect than messenger.com
TheVEN0M
@TheVEN0M
hovercards can't be installed on chrome 70