Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
    Sergei Rybalkin
    @rybalkinsd
    Hey guys! Looks like gitter helps with better project communication, planning and design discussions.
    Feel free to chat here
    Gokul
    @gokulchandra
    @rybalkinsd I was hoping to get your thoughts on the design for rybalkinsd/kohttp#65 ?
    Sergei Rybalkin
    @rybalkinsd
    Hey @gokulchandra ! Sorry for the delay. Currently on holidays. Will try my best to check your thoughts next days.
    Hey @shtykh any chance you could have a look?
    Gokul
    @gokulchandra
    @rybalkinsd Sounds good. Enjoy your holidays! :+1:
    Sergei Rybalkin
    @rybalkinsd
    Hi @gokulchandra I have a part of rybalkinsd/kohttp#55 (multipart requests) which is not designed yet. Would you mind to take a look?
    Gokul
    @gokulchandra
    Hey @rybalkinsd , I just got back from vacation. I will have a look sometime this week. :+1:
    Sergei Rybalkin
    @rybalkinsd
    welcome back @gokulchandra ! I'm currently analyzing new version of kotlin and okhttp and planning to add upgrade in on of the next releases
    Also great news we're getting close to 1000 downloads / month on maven central
    Gokul
    @gokulchandra

    Also great news we're getting close to 1000 downloads / month on maven central

    Thats amazing news!

    There is a PR rybalkinsd/kohttp#75 for rybalkinsd/kohttp#55. Are we planning on including file upload as a part of the multipart form?
    Sergei Rybalkin
    @rybalkinsd
    @gokulchandra I didn't make any tests for file uploading
    Upload dsl seems simple for me, implementing it at the moment
    Looks like it's better to implement upload on top of multipart
    so it'll look like this
    body {
            multipart {
                +file("file", "filename", File(this.javaClass.getResource("/cat.gif").toURI()))
                +form { "1" to 2 }
           }
     }
    Gokul
    @gokulchandra
    This looks like great.
    Regarding your Stackoverflow post how do we specify content-type for the request though? Through the multipart DSL?
    Sergei Rybalkin
    @rybalkinsd
    yaeh, that's tricky. general way now is to provide body(type) { }
    if multipart is included in body - you can reuse existing syntax. however, looks like body and multipart body are opposite things, and you use only one of them in request
    Sergei Rybalkin
    @rybalkinsd
    m/b it's better to improve HttpPostContext with multipartBody { } but do not have a strong opinion atm
    Sergei Rybalkin
    @rybalkinsd
    @gokulchandra btw, I sent you an invite to repository to make collaboration easier
    Also debugging multipart requests I found myself looking for some flags like curl -v or even logging everything including headers, body parts, etc
    could you please make a enhancement issue for this cases?
    Sergei Rybalkin
    @rybalkinsd
    httpPost(client) {
      host = "postman-echo.com"
      path = "/post"
    
      multipartBody {
        +form("cat", File(this.javaClass.getResource("/cat.gif").toURI()))
        +form("cat1", File(this.javaClass.getResource("/cat.gif").toURI()))
      }
    }
    Gokul
    @gokulchandra

    @rybalkinsd

    Also debugging multipart requests I found myself looking for some flags like curl -v or even logging everything including headers, body parts, etc

    The logging interceptor enables this. Should we add this as a separate enhancement or allow users to log as required using the interceptor.

    Sergei Rybalkin
    @rybalkinsd
    Could u think about a design? In my mind it’s better to have a single customizable interceptor. There are several ways how http requests could look like
    Sergei Rybalkin
    @rybalkinsd
    I'm trying to test file upload DSL. Anyone know any public API for file upload? I just found https://imgur.com/ but it asks for auth
    Sergei Rybalkin
    @rybalkinsd
    val r  = upload(client) {
            url("http://postman-echo.com/post")
            val fileUri = this.javaClass.getResource("/cat.gif").toURI()
            file(fileUri)
        }
    here is a upload API, subject to review
    Sergei Rybalkin
    @rybalkinsd
    Finally release 0.8.0 ! thanks for your contribution !
    Gokul
    @gokulchandra
    Thats awesome :confetti_ball: !
    Sergei Rybalkin
    @rybalkinsd
    Hi all! Here is a video from last Kotlin/Everywhere meetup in Moscow. I was talking about DSL and kohttp. Talk was in RU, however, EN subtitles are available https://t.co/W6Th9qv7wQ?amp=1
    Sergei Rybalkin
    @rybalkinsd
    I'm working on multipart body refactoring. Now figuring out the best api possible, need your advice @/all
    1.
    multipartBody {
      +part("name", "filename") {
        file(File("cat"))
      }
      ...
    }
    2.
    multipartBody {
      +part("name", "filename") {
        file(File("cat"))
      }
      ...
    }
    Baurzhan
    @Baural
    Hi all!
    Sergei Rybalkin
    @rybalkinsd
    @Baural Hi, welcome
    Sergei Rybalkin
    @rybalkinsd
    Hey, any thoughts/interest in supporting Flow & Channel in next versions?
    Sergei Rybalkin
    @rybalkinsd
    Detekt 1.0 is out. Anyone wanna try it in the project?
    Sergei Rybalkin
    @rybalkinsd
    kohttp 0.11.0 is just released!
    kenta.koyama
    @doyaaaaaken
    Conglaturation!!
    Sergei Rybalkin
    @rybalkinsd
    @/all Feel free to share ideas of what we should do in next release 0.12.0 - as we now have a bunch of tasks
    Sergei Rybalkin
    @rybalkinsd
    Here is a medium post about making kohttp 0.11.0
    Gokul
    @gokulchandra
    Hey @rybalkinsd got a WIP for the spring starter. It is pretty basic now, lets iterate on it. :)
    rybalkinsd/kohttp#166.
    Sergei Rybalkin
    @rybalkinsd
    Hey @gokulchandra , that’s awesome! Well check it out soon