Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
    NiLuJe
    @NiLuJe
    The "hold on the thumbnail in recents view" thingy?
    Never used it, but apparently, that's a thing, yeah
    Well, it's in a three dots menu in the reents view now, but, yeah, it's there
    And it indeed does what it says on the tin, yay.
    Martín Fernández
    @pazos
    but you shouldn't be able to use KOReader in split view
    NiLuJe
    @NiLuJe
    That was with GMail ;p
    I never installed KOReader on that device ;)
    Martín Fernández
    @pazos
    lol, better for your mental health!
    NiLuJe
    @NiLuJe
    ^^
    Martín Fernández
    @pazos
    If you install current version you'll be able to reproduce the issues @wangkaibule mentioned.
    NiLuJe
    @NiLuJe
    Already got my hands in too many pies ;p
    Martín Fernández
    @pazos
    @pazos: I think that's safe (it certainly works on my H2O). I remember having issues with fractional sleeps somewhere though, but I'll be damned if I can remember where ;).
    If is safe on kobos and safe on Kindles I will make the change.
    NiLuJe
    @NiLuJe
    With a bit of luck, that was on something like FW 2.x on Kindle, so, eh.
    I'm suspiciously using usleep in my old Kindle stuff, so that may be it
    The K2 is flat, so, more on that later ;)
    One could awlays use usleep if it's there and sleep otherwise, that'd make everything happy ;)
    Martín Fernández
    @pazos
    usleep 500000 || sleep 0.5 ?
    fine for me
    NiLuJe
    @NiLuJe
    Yeah, fractional sleep is an optional busybox feature, while usleep is an "all or nothing" applet
    So that'd make the most sense, compatibility-wise ;)
    https://git.busybox.net/busybox/tree/coreutils/sleep.c?h=1_29_stable && https://git.busybox.net/busybox/tree/coreutils/usleep.c?h=1_29_stable for ref.
    Martín Fernández
    @pazos
    ok, since it is called recursively I would go for usleep 500000 2>/dev/null || sleep 0.5
    NiLuJe
    @NiLuJe
    Yup
    NiLuJe
    @NiLuJe
    @pazos: Well, I'm kind of amazed I somehow managed to remember that, but that was indeed FW 2.x...
    [root@kindle root]# usleep 500000
    [root@kindle root]# sleep 0.5
    sleep: invalid number '0.5'
    \o/
    Frans de Jonge
    @Frenzie
    I was expecting that on Kobo tbh, but I tried it and was surprised to see that sleep 0.5 Just Worked™. (Isn't it one of those GNU extensions or whatever?)
    NiLuJe
    @NiLuJe
    It's a coreutils behavior that's optional in bb, yeah
    And usleep is bb only, funnily enough
    NiLuJe
    @NiLuJe
    Mwahahah, 8bpp on Kobo, I CAN PAN REALLY FAST GUYS§§!
    Frans de Jonge
    @Frenzie
    @NiLuJe Awesome! :-D
    Frans de Jonge
    @Frenzie
    @NiLuJe Shall I merge the gesture thingy tonight or wait until tomorrow/Tuesday?
    NiLuJe
    @NiLuJe
    My reply in the issue was meant to serve as a +1, yeah, go ahead ;).
    NiLuJe
    @NiLuJe
    @Frenzie : I sneaked in a crash report in https://github.com/koreader/koreader/pull/4607#issuecomment-464839072 in case it falls through the cracks ;)
    NiLuJe
    @NiLuJe
    I think that was on the nightly, but I might already have been using a local -56 build by then
    Frans de Jonge
    @Frenzie
    @NiLuJe Should be fixed by this one already I believe? koreader/koreader#4612
    NiLuJe
    @NiLuJe
    Quite possibly, haven't reproduced it yet on -56
    Frans de Jonge
    @Frenzie

    @NiLuJe Any thoughts on koreader/koreader#4620 btw?

    These are the auto-generated ones:
    http://ota.koreader.rocks/koreader-android-latest-nightly
    http://ota.koreader.rocks/koreader-android-x86-latest-nightly
    http://ota.koreader.rocks/koreader-appimage-latest-nightly

    NiLuJe
    @NiLuJe
    Definitely like the idea, but can this work with symlinks instead?
    I usually see this sort of stuff handled with a symlink in oldschool http/ftp software mirrors
    Frans de Jonge
    @Frenzie
    Sure, I was talking more about the frontend code. ;)
    NiLuJe
    @NiLuJe
    That'd basically save you the parsing stage in the frontend, if stuff follows symlinks properly ;p
    Frans de Jonge
    @Frenzie
    Oh, that way. Hm, that wouldn't quite work
    It'd need to be a redirect, not a symlink
    otherwise you're downloading a file named "latest-nightly"
    or in any case it'd need HTTP header shenanigans :P
    NiLuJe
    @NiLuJe
    Does the frontend actually care about the filename? (IIRC, zsync stuffs ends up in updated.tar or something)
    Frans de Jonge
    @Frenzie
    No, but I sure do! ;)
    NiLuJe
    @NiLuJe
    Getting the version from it maybe, if that bypasses the zsync file