Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
    NiLuJe
    @NiLuJe
    I've never actually built the emulator on macOS myself (my masochistic tendencies don't extend that far).
    (And the masquerading does make sense. ICC does the same thing. Otherwise, a crapload of stuff wouldn't even compile because of idiotic buildsystems or crappy preprocessor checks).
    Once that's out of the way, that "only" leaves the fact that XCode is currently broken on Catalina, because Clang and the libc don't agree on stack alignment.
    Deploying for < 10.15 appears to be the least crappy workaround right now.
    Theoretically, export MACOSX_DEPLOYMENT_TARGET=10.14
    No idea if everything we build will honor that, though.
    (I'm going to go out on a limb and say: it won't, and something will horribly segfault).
    TL;DR: It might be faster to actually spool up a Linux VM...
    Nick
    @dontcrash
    Might just use Docker, seems like a dead easy solution
    Nick
    @dontcrash
    Will give that a crack later today, definitely keen on Google Drive support in the cloud storage menu
    Thanks
    NiLuJe
    @NiLuJe
    Since that's going to be pure Lua, you can just test on-device, too
    I generally don't bother with the emulator myself
    for file in $(git diff --name-only upstream/master) ; do ; [[ -f "${file}" ]] && scp "${file}" "root@forma:/mnt/onboard/.adds/koreader/${file}" ; done
    And a KOReader restart and that's it.
    Nick
    @dontcrash
    Tried to call scp with ssh enabled but it doesn’t want to connect, regular ssh access works however
    Frans de Jonge
    @Frenzie
    @NiLuJe Back when the MuPDF build was slightly broken on Mac I followed our build Mac OS build instructions in a VM and it worked perfectly (besides some minor fixups). Homebrew was updated since but I believe so were our instructions… anyway, so basically it's become a shitstorm only quite recently because from ~2014-2018 everything pretty much just worked unless we broke it. But the past year and a half Homebrew and Apple have been very actively breaking things.
    Nick
    @dontcrash
    I’ll be attempting the Docker instructions in an hour or so, any tips on SCP? I could manually copy the files to my Libra via USB from Nickel, but would love to be able to just use scp
    Containerised sounds much better, because you don’t have to rely on the user to have their own system setup perfectly to build
    Frans de Jonge
    @Frenzie
    @dontcrash Enable the built-in Dropbear SSH server in settings → network.
    Nick
    @dontcrash
    Have done that already, I can connect to it via ssh, but scp fails for some reason
    Scrap that, my stupid fu#$%ng router was blocking port 2222, I switched it over to the default 22 and my router allowed that on LAN
    Nick
    @dontcrash
    for frontend/apps/reader/modules/readermenu.lua, setting the file browser button to the home icon definitely makes more sense:
    filemanager = {
    icon = "resources/icons/appbar.home.png",
    Nick
    @dontcrash
    Okay, I've made changes to my own Kobo devices version of KOReader to improve the UI a bit, haven't had a chance to look at Google Drive support, should be possible though, I put together a Google Doc of proposed changes and a screenshot of what it looks like, I have enabled comments, please let me know what you think @Frenzie
    https://docs.google.com/document/d/11rpFMiyla_GqtnTC8Lq07Ux8witfqxe1c9-MZN0deek/edit?usp=sharing
    Frans de Jonge
    @Frenzie

    @dontcrash Well, I think that kind of excludes people from the conversation by separating it out from the usual channels. Non-composite issues & PRs are generally preferred.

    1. Should be fine.
    2. I doubt people who enable the shortening option would be happy to see the standard ~ replaced by something much longer; might need some more thought. (As an aside, see http://koreader.rocks/doc/modules/gettext.html.) Wasn't there some customization option for the string involved?
    3. Not necessarily better, plus it might be ambiguous with device home (i.e., exit). Other potential alternatives include some kind of up/back arrow. But basically please stick it in a PR with before/after screenshots for the community.
    4. I'm not sure if I'd like that.
    5. But that one I probably would.

    6. http://koreader.rocks/doc/modules/util.html#splitFilePathName

    7. Agreed.
    8. Tbh I never even look at that.
    9. It is? Might be better to track in an issue.
    Frans de Jonge
    @Frenzie
    Btw, did the Docker setup work out? :)
    Nick
    @dontcrash
    Didn’t end up using docker, but I’m sure it would have, I ended up just sending the files to my device via scp
    Nick
    @dontcrash
    I’ll push them as pull requests, I just wanted some feedback before I did so :)
    NiLuJe
    @NiLuJe
    FWIW, I agree with @Frenzie on pretty much every point ;).
    Except that I actually like the current behavior for 9. ;).
    Nick
    @dontcrash
    9 I’m not so sure on, I guess it doesn’t matter that much, but renaming it from File Browser to just KOReader is definitely something that needs doing, I was developing user interfaces for my irl job working with a full stack developer, and from what I was reading online, a lot of people (myself included) love KOReader as it’s a better experience, but think that the UI is clunky, no offence, it works great but just visually, some things could be improved
    I don’t believe people would have a problem with replacing ~ with Home, the people I have talked to about that, they only have that setting turned on because it’s unpleasant to look at /mnt/onboard/path, you have to remember who the target audience is for this, it’s not just programmers
    I haven’t gotten around to it as of yet, but I was also thinking of throwing together an “intro” e.g replacing the
    Replacing the Help/Quick start, with a visual experience, that shows users how to navigate
    Frans de Jonge
    @Frenzie
    There are definitely a lot of things that can be improved; it's great to have someone else spend time on it too. ;-)
    Nick
    @dontcrash
    I honestly just want to help, the moment I used KOReader I immediately preferred it over Nickel, and I know a lot of people complain online about the UI mostly, so I thought, hey why not try to improve it :)
    So for the commits in the pull request that are approved (if they are), they will make it into the nightly?
    Frans de Jonge
    @Frenzie
    Not unless you separate it out slightly more into multiple PRs. I've little desire to go cherry-picking 'em. ^_^
    Nick
    @dontcrash
    Ah oops, so I should create new branches for each new item?
    Frans de Jonge
    @Frenzie

    Not each item, but I'd say the 12-hour clock thing is completely unrelated to anything else for example.

    Anyway, it doesn't matter too much, but when it's all together they'll basically all be blocked by that one commit.

    Nick
    @dontcrash
    Alright, in future any changes will stick to that structure, e.g. branch for each major change, unless related etc
    For now, do you need me to do anything to the current PR or will the 12 hour clock idea still be looked at?
    Frans de Jonge
    @Frenzie
    Screenshots are always good. ;-) For users like me just so we don't have to fetch the PR to see what it looks like (or if I'm on my phone) but there are also users who contribute or just like to stay apprised without really getting involved in Git/Lua.
    Frans de Jonge
    @Frenzie
    Btw, I was probably a bit cryptic yesterday but with my gettext link I meant that the Home thing should read _("Home").
    Nick
    @dontcrash
    Ah for translation
    Nick
    @dontcrash
    Here is what it looks like:
    https://imgur.com/a/ip364tn
    Nick
    @dontcrash
    Need to look into the word gap setting for epub, medium is larger than large
    Nick
    @dontcrash
    Trying to add the home path custom message functionality but getting this, not familiar with LUA, any ideas?
    attempt to index global 'InputDialog' (a nil value)
    Here's my code:
    https://pastebin.com/rL3hsEbJ
    @Frenzie
    Scrap that, needed to add local InputDialog = require("ui/widget/inputdialog")
    I went off the example code on http://koreader.rocks/doc/modules/ui.widget.inputdialog.html
    This example is incorrect then?