Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
    Guillaume Grossetie
    @Mogztter
    Awesome! Well done 👍
    No it's not necessary I will take a look when I get some time
    🍾
    Guillaume Grossetie
    @Mogztter
    pull request merged!
    nicely done @bobroro_gitlab :smile:
    I will try to move the code out of the Intellij plugin this week to add some tests
    bob roro
    @bobroro_gitlab
    @Mogztter was just wondering what's the best way to update the font list for plantuml within the kroki docker?
    seems this is the default font list https://imgur.com/a/f89DZh5
    Guillaume Grossetie
    @Mogztter
    I think it relies on system font so you will probably need to build an image FROM yuzutech/kroki and the install your fonts
    bob roro
    @bobroro_gitlab
    Where's the dockerfile? Or how to extend it to add fonts.
    Guillaume Grossetie
    @Mogztter
    it's the standard mechanism to build an image from another base image, see: https://docs.docker.com/develop/develop-images/dockerfile_best-practices/
    so you create a new image from the base image yuzutech/kroki and then you can add fonts on Alpine (based OS of the base image): https://wiki.alpinelinux.org/wiki/Fonts
    bob roro
    @bobroro_gitlab
    @Mogztter ok thanks
    alexandre-frey
    @alexandre-frey
    @Mogztter Hi! I've tried this morning to use kroki-server-0.7.1.jar but it seems the jar file lacks a lot of contents? It is very small (100KB vs 23MB for 0.6.0) and is not executable
    Guillaume Grossetie
    @Mogztter
    Ooops I must have uploaded the "wrong" jar (i.e. not the fatjar that contains everything)
    Thanks for the heads-up! I don't have my primary (Linux) machine at hand but I will see what I can do using my (macOS) laptop :)
    Guillaume Grossetie
    @Mogztter
    As a workaround, you can build it yourself from the tag, a mvn package at the root of the project should produce the fatjar in server/target
    alexandre-frey
    @alexandre-frey
    Thanks! I'm using version 0.6.0 now. I don't need the latest, I guess, it's just for playing around.
    Nick Caballero
    @nickcaballero
    Hi! I’m hoping to migrate away from PlantUML server to the Kroki server. However, I don’t see any mention of the license for the project in the source code.
    Guillaume Grossetie
    @Mogztter
    Hello @nickcaballero, I'm not a license expert but most of the time my work is licensed using MIT
    In this case, I'm not 100% sure because we rely on other diagrams libraries but they are all open source
    feel free to open an issue at https://github.com/yuzutech/kroki so I don't forget to add a license
    Marcel Stör
    @marcelstoer

    Hey @Mogztter I'm once again stuck with an Antora integration issue. Hence, I'm not quite sure if it has to be addressed on the Kroki or on the Antora side. Loading external .pumls causes issues. For starters I used the example from your README:

    [plantuml,alice-bob,svg,role=sequence]
    ....
    include::alice-bob.puml[]
    ....

    This resolves just fine in IntelliJ (i.e. the AsciiDoc plugin with Kroki enabled) but fails for Antora:

    $ antora antora-playbook.yml 
    asciidoctor: ERROR: index.adoc: line 14: include target not found: alice-bob.puml
    Somehow processing still continues because there appears to be a subsequent request to kroki.io which of course also fails
    Skipping plantuml block. GET https://kroki.io/plantuml/svg/eNoLzStKLc7PKUtNUcjMS84pTUlVSMksSk0uySxLBYoo5OanlOakFusH-fuH6BckpgOZmXkpqRV6iSn5yQq6ME1WVok5mcmpukn5SXoFpbk50bEA1jQgoA== - server returns an empty response or a 404 status code
    In case it matters asciidoctor-kroki is at 0.9.2.
    Marcel Stör
    @marcelstoer
    The directory structure is like this
    docs
    ├── antora.yml
    └── modules
        └── ROOT
            ├── nav.adoc
            ├── pages
            │   ├── alice-bob.puml
            │   └── index.adoc
            └── partials
                └── alice-bob.puml
    Findings:
    • include::partial$alice-bob.puml[] works ok both in IntelliJ and Antora (CLI)
    • include::page$alice-bob.puml[] works only in IntelliJ
    • include::alice-bob.puml[] ditto
    Guillaume Grossetie
    @Mogztter
    Hey Marcel, the include directive is a preprocessing directive. It will be resolved by Asciidoctor. Antora is extending the include directive to use a custom resolver. The Intellij extension mimicks this resolver but the implementation has a few differences (that's why sometimes it's working in Antora but not in Intellij and vice versa)
    The Kroki extension does not see the include directive (as the directive is resolved as a preprocessing step)
    Marcel Stör
    @marcelstoer
    Thanks for the clarifications. Does this mean it's expected that include::alice-bob.puml[] (i.e. referencing on file system level) does not work - and maybe a surprise the IntelliJ plugin supports it?
    Guillaume Grossetie
    @Mogztter
    In other words, the "issue" here is that the Intellij gives the impression that include::alice-bob.puml[] can be resolved by Antora but that's not true
    Marcel Stör
    @marcelstoer
    Ok, as a consequence would you also say that the example in your README under the "Antora Integration" chapter should use include::partial$alice-bob.puml[] instead? And maybe point to https://docs.antora.org/antora/2.3/standard-directories/?
    Guillaume Grossetie
    @Mogztter
    The usage section is not under the "Antora Integration": https://github.com/mogztter/asciidoctor-kroki#usage
    But we should probably mention that in Antora the target of the include directive must be a resource identifier
    Speaking of which, puml files should be under examples not partials
    Partials are saved as AsciiDoc source files (.adoc) and stored in a partials directory.
    Guillaume Grossetie
    @Mogztter
    Examples are resources, such as source code (e.g., runner.js), terminal output, and data sets (e.g., choptank-co2.csv).
    Marcel Stör
    @marcelstoer

    The usage section is not under the "Antora Integration"

    Oh..right, sorry about this.

    Speaking of which, puml files should be under examples not partials

    In my opinion neither of them are a good match but you're right, partials is probably even worse than examples.

    Guillaume Grossetie
    @Mogztter
    @all If you would like to use Kroki in GitLab, please add a comment and/or thumbs up to gitlab-org/gitlab#241744
    Marcel Stör
    @marcelstoer
    It's a neat idea as an alternative to using kroki.io or a self-managed instance. For me personally it's not high on the list of wanna-haves. We currently use the free service from our GitLab pipeline.
    Guillaume Grossetie
    @Mogztter
    Thanks!
    The idea is to render diagrams in AsciiDoc (or Markdown) documents using Kroki (public or self-managed instance)
    So it's useful when you view AsciiDoc or Markdown documents directly on GitLab. For instance, README on the main page of a repository.
    If you are publishing the documentation elsewhere then it won't be useful
    Adrian Kosmaczewski
    @akosma_gitlab
    Just found this and I wonder if this could fit into Kroki: https://diagrams.mingrammer.com/
    Adrian Kosmaczewski
    @akosma_gitlab

    @all If you would like to use Kroki in GitLab, please add a comment and/or thumbs up to gitlab-org/gitlab#241744

    this is awesome! I hope it works out and they include it!

    Guillaume Grossetie
    @Mogztter
    Hey Adrian! How are you? https://diagrams.mingrammer.com/ looks good but it's a Python DSL meaning that you can execute arbitrary Python code
    I might still create companion Docker containers for these diagrams libraries when you want to use them in a trusted environment
    but I won't deploy them on kroki.io until I have a production-grade sandbox in-place :smile: