Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
    Felix Köhler
    @kdoteu
    ktoso/maven-git-commit-id-plugin#136 it think this ticket address this sitation
    Konrad `ktoso` Malawski
    @ktoso
    replied in the ticket
    help is very welcome
    Felix Köhler
    @kdoteu
    what would be a better approach? Add a property to switch from repo history to module history? Or provide both information with a new variable such as git.commit.module.id.abbrev ?
    Already found a suitable soultion to find the latest commit with jgit but not with native git.
    Konrad `ktoso` Malawski
    @ktoso
    could be a new property yes :)
    cool, if its doable with jgit then native surely also we'll figure out :)
    you can PR with that you have if it works with jgit maybe
    Felix Köhler
    @kdoteu
    Its only hacked in ;D nothing to commit :D i'll do a fast hacky version for my company and will do a full PR in my spare time :D
    Konrad `ktoso` Malawski
    @ktoso
    that would be very cool, thanks in advance
    Felix Köhler
    @kdoteu
    For clarification you prefer a switch for module / repo history? Or did you mean the new variable version?
    Konrad `ktoso` Malawski
    @ktoso
    new value
    Felix Köhler
    @kdoteu
    perfect
    Konrad `ktoso` Malawski
    @ktoso
    we'd want to make it optional too
    if it slows down things
    Felix Köhler
    @kdoteu
    that should'nt be a problem :D
    Konrad `ktoso` Malawski
    @ktoso
    :+1:
    Felix Köhler
    @kdoteu
    Hacky Version is already running and working fine :D
    Konrad `ktoso` Malawski
    @ktoso
    nice
    pankajtandon
    @pankajtandon
    Hi Konrad.. Looks like you're v busy :smile:
    What do I have to do to get you to look at the PR I submitted for ReleaseNotes support :smile:
    Konrad `ktoso` Malawski
    @ktoso
    ping me there ;)
    pankajtandon
    @pankajtandon
    I have a PR here: ktoso/maven-git-commit-id-plugin#266
    Konrad `ktoso` Malawski
    @ktoso
    I can give it a look, thanks
    pinging on github works too
    Konrad `ktoso` Malawski
    @ktoso
    I have mixed feelings about it
    why not as independent plugin?
    I dont actively maintain the plugin
    @TheSnoozer is helping out a lot, but it's in maintanance mode
    this is a big new feature
    and not really 1:1 aligned with the core of what it does
    would you want to perpahs independently release it as plugin instead? @pankajtandon
    Kyle Anderson
    @andersonkyle
    @ktoso Hi Konrad. Just curious as to when we can expect Version 2.2.3 to be released? Thanks!
    TheSnoozer
    @TheSnoozer
    Anything specific fixed for 2.2.3 that you need ASAP?
    Kyle Anderson
    @andersonkyle
    Nothing urgent. I was following #275 where mkrivan mentions some fixes that were merged to master in January. I've just noticed your recent comment on that issue where you mention an alternative approach. Just out of curiosity, any ETA to cut a new release?
    Konrad `ktoso` Malawski
    @ktoso
    “whenever needed”, as simple as that ;)
    can cut one now
    Konrad `ktoso` Malawski
    @ktoso
    should I?
    Kyle Anderson
    @andersonkyle
    That'd be great.
    Konrad `ktoso` Malawski
    @ktoso
    ok, tried today but had a few failing tests locally
    will try tomorrow
    almost 1AM over here :)
    will kee you informed here
    Kyle Anderson
    @andersonkyle
    No problem :)
    Dmitry Bond
    @Citrys
    Hey, Sorry I have, probably, a silly question.. but will give a try. I found that it is possible to add maven-git-commit-id-plugin via sbt dependency (libraryDependencies += "pl.project13.maven" % "git-commit-id-plugin" % "2.2.3") And my question is if it possible to do the simple init of git.properties into file with this plugin, but in sbt plugins space? Cause we use only sbt. Thanks in advance for help. Cheers.
    TheSnoozer
    @TheSnoozer
    Honestly this is a good question...i don't have a straight answer but it seems like that there are plugins in stb that allows to run maven-plugins: https://github.com/shivawu/sbt-maven-plugin let me know if you got it somewhat working ;-)
    Dmitry Bond
    @Citrys
    @TheSnoozer Thanks a lot for response, will check this super plugin and keep you posted!
    TheSnoozer
    @TheSnoozer
    @Citrys sounds good for me. It might help if you setup a sample project so I could have a look as well :P
    TheSnoozer
    @TheSnoozer
    @Citrys did you had success running the plugin with sbt?
    Dmitry Bond
    @Citrys
    Hey @TheSnoozer I tried it, but sbt maven plugin was not the best option, so... I wrote similar plugin using eclipse jgit . In any case, thanks very much for your help.
    girishpalaparty
    @girishpalaparty
    Hey there everyone. just a quick question. I am trying to add Git plugin Global Config user.name Value to my JCasC file. I am using version 1.4 of JCasC plugin and it does not seem to support that value. Do you know if an updated version of that uses it ?