I've set to meta+space
edited ticket
@Kodehawa "Window placement "Centered" places the windows on the top-left instead of at the center (seems like all window placement rules get ignored)" That should be fixed now again.
@XakepSDK On master branch it does it a bit different. It does not move the window to the (0,0) coordinates but also does not move it to the last restore position before the restart. Instead it keeps it at the top-right corner. Don't know why it does it there this way but I don't think it makes sense trying to optimize this very specific case.
Just uploaded a new version of geometries-2 branch which hopefully fixes many of the remaining issues from kwinft/kwinft#121.
4 new bugs
1 or 2 fixed (not sure if shadows bug 100% fixed, needs more testing)
KRunner is still cursed though haha
Krunner is indeed cursed. Gonna take a look at it tomorrow. Right now fixing back up the unit tests again and for that the Wayland windowing. What's nice: with the new round of redesign today the implementations for both are even more closer together. Much of the geometry code will be the same and at some point can be further consolidated.
Finally full screen in firefox was fixed
About black window bug - i can reliably reproduce it with firefox
Make it full screen by F11 and then back
Window content will be black
@XakepSDK is this what you see on resize when grabbing from titlebar
Image looks different
Looks like it's a broken aspect ratio, right?
for like a second
I've just uploaded a new version. It features again some major changes to the overall design. Now basically everything from resizing over maximization to fullscreening is synchronized on Wayland and X11. Would be happy to get some more feedback for this version. Thanks in advance!
Assuming there are no major problems with the latest version my plan is to merge MR kwinft/kwinft!68 and then windowing branch to master this weekend and release a beta quickly after to stay in sync with Plasma releases.
If you're interested in the Wayland session KDE's virtual Wayland sprint has just begun and sesions will be today and tomorrow. Topics are diverse and of course it's also relevant for KWinFT. See this page for a timetable of topics and a link to the virtual meeting room: https://community.kde.org/Sprints/Wayland/2021Virtual
Hey @romangg_gitlab, let me do a quick question. I'm trying to build the
geometries-2 branch and I get the following build error. May I be using some outdated dependency?In file included from /tmp/kwinft-git/src/build/kcmkwin/kwindecoration/declarative-plugin/kdecorationprivatedeclarative_autogen/EWIEGA46WW/moc_previewclient.cpp:10,
from /tmp/kwinft-git/src/build/kcmkwin/kwindecoration/declarative-plugin/kdecorationprivatedeclarative_autogen/mocs_compilation.cpp:7:
/tmp/kwinft-git/src/build/kcmkwin/kwindecoration/declarative-plugin/kdecorationprivatedeclarative_autogen/EWIEGA46WW/../../../../../../kwin/kcmkwin/kwindecoration/declarative-plugin/previewclient.h:110:10: error: ‘void KDecoration2::Preview::PreviewClient::requestShowWindowMenu(const QRect&)’ marked ‘override’, but does not override
110 | void requestShowWindowMenu(QRect const& rect) override;
| ^~~~~~~~~~~~~~~~~~~~~
KWinFT master depends of course against latest KDecoration.
Also for geometries-2 branch you need to build Wrapland's windowing branch: https://gitlab.com/kwinft/wrapland/-/commits/windowing