by

Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
Roman Gilg
@romangg_gitlab
Ah, there is a blog about it: https://www.synopsys.com/blogs/software-security/integrating-coverity-scan-with-gitlab-ci/
Adrien Faveraux
@erreur404_gitlab
I have accepted ;)
Adrien Faveraux
@erreur404_gitlab
I will maybe rerun scan in agressive mode for find more defect
Roman Gilg
@romangg_gitlab
The defects listing is quite nice. Don't know if one can integrate it in the merge review flow. But probably one can at least run it automatically from master branch when there are new commits.
It's a bit annoying that one can not change the name of the project once created. :/ kwinft -> KWinFT
Roman Gilg
@romangg_gitlab
Maybe one could a mail to the site admin. But can be tried later.
Bernie Innocenti
@berniecodewiz_gitlab
Someone pointed me in the right direction for the bug where decorations are corrupted in 30bpp
Rendering to QImage::Format_ARGB32_Premultiplied results in color artifacts when compositing is disabled
QImage::Format_A2RGB30_Premultiplied works with compositing disabled, but doesn't work when it's enabled :-)))
https://gitlab.com/kwinft/kwinft/-/blob/master/decorations/decorationrenderer.cpp#L70
Bernie Innocenti
@berniecodewiz_gitlab
Not sure where to find the actual implementation of Decoration::paint() that's being called.
Roman Gilg
@romangg_gitlab

Not sure where to find the actual implementation of Decoration::paint() that's being called.

Could be in the KDecoration2 library: https://api.kde.org/kdecoration/html/classKDecoration2_1_1Decoration.html#a39ea53ed89dc997d286f6ae243b8c41a

Bernie Innocenti
@berniecodewiz_gitlab
that's a pure virtual method
Ah, found! It's in breeze/kdecoration/breezedecoration.cpp
Roman Gilg
@romangg_gitlab
Yea, decorations override it to implement their stuff.
Adrien Faveraux
@erreur404_gitlab

It's a bit annoying that one can not change the name of the project once created. :/ kwinft -> KWinFT

Oups

Roman Gilg
@romangg_gitlab
Can happen, but they should provide a way to change the project name after creation.
Adrien Faveraux
@erreur404_gitlab
yes i will email her , sorry for that :/
Roman Gilg
@romangg_gitlab
Btw I pushed a new version of FDBuild to the master branch. Has lots of small improvements if you wanna try it. Currently I'm working on romangg/fdbuild#16 what needs a bit more work.
Adrien Faveraux
@erreur404_gitlab
for sure, i will update my fdbuild version ;)
Bernie Innocenti
@berniecodewiz_gitlab
Oh, now I see where the bug is:
https://gitlab.com/kwinft/kwinft/-/blob/master/plugins/platforms/x11/standalone/x11_decoration_renderer.cpp#L94-97
The QImage is Format_ARGB32_Premultiplied, but the destination surface is now something else
xcb_put_image() takes the depth... doesn't it also have a parameter to specify the actual FOURCC?
Adrien Faveraux
@erreur404_gitlab
i currently reupload a scan on coverity, i have see some problem with the compiler that ignore certain file. So the compiled file grow from 400 mb to 800 mb
Adrien Faveraux
@erreur404_gitlab
155 defect :) good !
Bernie Innocenti
@berniecodewiz_gitlab
Hey @romangg_gitlab, I'm still seeing corrupted shadows from kwinft on x11 with 30bpp. Works in kwin 5.19.1
Should I file an issue in gitlab? or is x11 no longer priority?
Roman Gilg
@romangg_gitlab

Should I file an issue in gitlab? or is x11 no longer priority?

Definitely file an issue. Fixing stuff on x11 is still important. Thanks!

155 defect :) good !

Yea, that's "good". :D I looked up how this coverty system work. We can't really build on every merge request (it does not allow unlimited builds) but we should be able to add some scheduled builds once a day. This way we can see the overall defect count still develop over time.

Adrien Faveraux
@erreur404_gitlab
yeah, i currently fix critical and i will push a PR
Bernie Innocenti
@berniecodewiz_gitlab

Definitely file an issue. Fixing stuff on x11 is still important. Thanks!

kwinft/kwinft#63

Roman Gilg
@romangg_gitlab
@berniecodewiz_gitlab Thanks. I added some labels. Added you to the KWinFT group so you can change/add them yourself in the future. :)
Adrien Faveraux
@erreur404_gitlab
@berniecodewiz_gitlab i will check change in main kwin for identify why its working ;)
Adrien Faveraux
@erreur404_gitlab
hello all , i have ported all change in scene, it include quad for subsurface and more, and it's working without black screen :p
kwinft/kwinft!23
@berniecodewiz_gitlab , can you test the shadow for kwinft with the modification , maybe your problem is fixed because shadow is directly painted in scene
Bernie Innocenti
@berniecodewiz_gitlab
Trying
Bernie Innocenti
@berniecodewiz_gitlab
Nope
@erreur404_gitlab @romangg_gitlab the shadows are still broken with kwinft/kwinft!23 applied (as well as dependent wrapland patch of course)
I also noticed another regression from kwin: the transparent background of Konsole is no longer blurred.
Adrien Faveraux
@erreur404_gitlab
Ok thanck you for testing, i will search more :p the blured working on kwinft master ?
Bernie Innocenti
@berniecodewiz_gitlab
no, blurring is working in kwin 5.19.1 and not in kwinft
Adrien Faveraux
@erreur404_gitlab
Ok if is not my path , i will find where is the problem
ericschdt
@ericschdt
Hello, I came from here: https://www.reddit.com/r/kde/comments/hkmozo/freesync_or_gsync_on_kwin_wayland/ and wanted to know if you have plans for VRR at KWinFT and how plans look like. :)
Roman Gilg
@romangg_gitlab
Hi Eric. Current plan is to first split out the backends into a separate library as described in kwinft/kwinft#21. Then we can take a look at different refresh rates for different outputs and VRR. There might be a shortcut with current architecture but it likely would be ugly.
For the library split out I'm currently waiting on C++20 modules becoming available in current build systems / compilers.
ericschdt
@ericschdt
Thank you Roman for your quick response. I guess you cannot give any crude ETA right now, even if you knew when C++20 modules become available, but will definitely keep watching the project.
ericschdt
@ericschdt
Maybe a second question, if I'm allowed: How is the state regarding HDR support?
ericschdt
@ericschdt
Gotta go, see you!