Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • Sep 24 20:46
    Sergio Blanco commented on merge request #220 fix: firefox returns to SDDM when opening or closing the hamburger menu (wayland) in KWinFT
  • Sep 24 17:43
    Tom Englund commented on merge request #229 Draft: make rules take a list of desktops in KWinFT
  • Sep 24 16:16
    Sergio Blanco commented on merge request #220 fix: firefox returns to SDDM when opening or closing the hamburger menu (wayland) in KWinFT
  • Sep 24 12:12
    Tom Englund commented on merge request #229 Draft: make rules take a list of desktops in KWinFT
  • Sep 24 12:11
    Tom Englund commented on merge request #229 Draft: make rules take a list of desktops in KWinFT
  • Sep 24 12:11
    Tom Englund commented on merge request #229 Draft: make rules take a list of desktops in KWinFT
  • Sep 24 12:10
    Tom Englund commented on merge request #229 Draft: make rules take a list of desktops in KWinFT
  • Sep 24 12:10
    Tom Englund commented on merge request #229 Draft: make rules take a list of desktops in KWinFT
  • Sep 24 12:10
    Tom Englund commented on merge request #229 Draft: make rules take a list of desktops in KWinFT
  • Sep 24 12:10
    Tom Englund commented on merge request #229 Draft: make rules take a list of desktops in KWinFT
  • Sep 24 12:09
    Tom Englund commented on merge request #229 Draft: make rules take a list of desktops in KWinFT
  • Sep 24 12:09
    Tom Englund commented on merge request #229 Draft: make rules take a list of desktops in KWinFT
  • Sep 24 12:09
    Tom Englund commented on merge request #229 Draft: make rules take a list of desktops in KWinFT
  • Sep 24 12:08
    Tom Englund commented on merge request #229 Draft: make rules take a list of desktops in KWinFT
  • Sep 24 08:59
    Roman Gilg commented on merge request #220 fix: firefox returns to SDDM when opening or closing the hamburger menu (wayland) in KWinFT
  • Sep 24 04:05
    Sergio Blanco commented on merge request #220 fix: firefox returns to SDDM when opening or closing the hamburger menu (wayland) in KWinFT
  • Sep 23 18:29
    ms178 commented on merge request #168 Make use of C++20 ranges in KWinFT
  • Sep 23 18:14
    Roman Gilg commented on merge request #220 fix: firefox returns to SDDM when opening or closing the hamburger menu (wayland) in KWinFT
  • Sep 23 18:12
    Sergio Blanco commented on merge request #220 fix: firefox returns to SDDM when opening or closing the hamburger menu (wayland) in KWinFT
  • Sep 21 21:06
    GitLab | Roman Gilg pushed 41 commits to KWinFT
Roman Gilg
@romangg:matrix.org
[m]
That should even allow to remove all if-cases and the virtual override of the get_client_property_data function.
But it also means we can't show properties at the moment of windows that don't have a control interface. :/
But still better than showing none at all. ;)
Tom Englund
@gulafaran:matrix.org
[m]
yeah il test :p
Roman Gilg
@romangg:matrix.org
[m]
Btw I'm working now for a week non-stop on this damn templating of everything. That's why I'm maybe not so reactive with replies and reviews at the moment. It's kind of exhausting. But there is light at the end of the tunnel.
Tom Englund
@gulafaran:matrix.org
[m]
Roman Gilg: oh dont worry, im mostly spending my late nights fiddling. trying to spend as much of my last vacation days out boating/chilling :D
Roman Gilg
@romangg:matrix.org
[m]
Sounds nice! ๐Ÿ˜„ Friend of me visited me on the weekend when travelling from Nordsee to Bayern. He was in Sweden with his van and girlfriend for a few days. He enjoyed it but on the photos it looked quite cold I have to say. At least a lot colder in comparison to how it is now in Berlin.
They liked the colder weather though.
Tom Englund
@gulafaran:matrix.org
[m]
Haha yeah well i guess its what you get used to june - august averages like 18 - 22C daytime with some random heatdays of 27, and nights is like 12 - 15C
I do live quite far up north ๐Ÿ˜‚
Hm silly phone wont let me copy url, but luleรฅ
2 replies
Tom Englund
@gulafaran:matrix.org
[m]
also sadly using scripting doesnt help either returns "objectName" anyways, and ofc nothing for internal windows etc without control hm
Tom Englund
@gulafaran:matrix.org
[m]
aha hold up we got a few get_property_index and get_property_count etc
Roman Gilg
@romangg:matrix.org
[m]
Right, I noticed on my refactors you also need to change type we get the property count from.
Tom Englund
@gulafaran:matrix.org
[m]
Roman Gilg: yay it works, so technically i could implent some kind of internal_window or window without control scripting classes for this aswell?
1 reply
or well hm "win->control->scripting.get();" no
Roman Gilg
@romangg:matrix.org
[m]
Then we would also not need to "misuse" the scripting::window class. Have it nicely separated instead.
Tom Englund
@gulafaran:matrix.org
[m]
yeah
Roman Gilg
@romangg:matrix.org
[m]
You could use the scripting::window class as a paragon though.
Maybe even make this in some way a class template, so scripting module and debug module can share code.
Q_PROPERTYS are a bit annoying here though. Maybe not a template class, just a virtual interface.
Roman Gilg
@romangg:matrix.org
[m]
Tom Englund: So my current "fix" for the debug properties you can find now on the base-object-2 branch I'm actively working on: romangg/kwinft@084e937
It falls back to reading the QObject properties of the Toplevel for windows without control. But of course there are no Q_PROPERTYs defined on the Toplevel class anymore.
Tom Englund
@gulafaran:matrix.org
[m]
Roman Gilg: right, i was tinkering around with interfaces/templates and see what could be done. but merge that i got nothing finalized :p
seems q property doesnt support class templates and bunch of other annoyances :(
1 reply
had some ideas about having something like window->debug a bit like window->control but not sure
Roman Gilg
@romangg:matrix.org
[m]
...which then is composited back into the actual class with a smart pointer.
You can have a QObject templated when there is no Q_OBJECT, Q_PROPERTY and so on macro in it.
Tom Englund
@gulafaran:matrix.org
[m]
damn was just checking out your branch, thats some serious work. cool :)
Roman Gilg
@romangg:matrix.org
[m]
Haha, thank you! :)
The last commit is still wip, but the other ones are ok.
Tom Englund: I was wondering if you're currently still working on rules stuff. You were looking into some fixes for that just recently, right? Because I may want to do kwinft/kwinft#241 now, which may create conflicts.
Tom Englund
@gulafaran:matrix.org
[m]
Roman Gilg: well i got that draft laying around waiting for some kind of virtual_desktop_manager integration struct or similiar but then got looped into debug_console thought of using it and appending a few useful things to actually debug or test things properly
Roman Gilg: so proceed on, il rebase with any conflicts ๐Ÿ‘๏ธ
idea was to add one more tab for space properties aswell and fill in bunch of useful things heh but yeah noticed quite a lot was a bit off on it
Tom Englund
@gulafaran:matrix.org
[m]
il probably get more things going anyhow in ~1 week when the vacation days run out and the regular boring work, sleep, eat shedule begins again xD, so yeah dont worry. anything you work on that conflicts. il rebase! dont let me hold you up
1 reply
Roman Gilg
@romangg:matrix.org
[m]
Haha, thank you. That sounds cool. I'll likely also be finished until then with the base-objects-2 branch. As I see it this concludes the major refactorings necessary in kwinft's core infrastructure.
So then it's a good point in time to do feature work.
Juan Jose Casafranca
@jjcasmar_gitlab
Kwinft is based on wlroots, right?
1 reply
Roman Gilg
@romangg:matrix.org
[m]
There are changes lined up to increase the usage in the future: kwinft/kwinft!186
Must wait on the next wlroots release 0.16 for that.
Tom Englund
@gulafaran:matrix.org
[m]
Roman Gilg: did a short test nothing obvious with 230
Roman Gilg
@romangg:matrix.org
[m]
Thank you Tom! I'm gonna merge it then later today. :)
I had already rebased the base-object-2 branch onto it and doing some work there right now.
Tom Englund
@gulafaran:matrix.org
[m]
Roman Gilg: i have a uh question tho, seeing you use enum_index in this MR aswell, 395518 in coverity has an odd error about it, ive tried various things in godbolt and locally and cant really tell why its complaining
either its false positive or its catching some oddball case :p
Roman Gilg
@romangg:matrix.org
[m]
I see hmm. It's weird but I don't think it's a real issue. It somehow assumes that lay could be layer::count, which would be an issue as local layers variable only has 15 entries. Maybe accessing it with at would silence the warning.
i.e. layers.at(enum_index(lay)).push_back(win)