have mostly refactored my rules patches, but digging into some regression and the attempt at integration struct, but its a bit slow on this turd rebuilding xD
next week tho then il enjoy my ryzens again xD
*refactored/rebased
But better to concentrate first on getting the template objects done somehow and afterwards make them pretty with C++20.
are they related to those lambda capture changes i found last time?
but seems those only caused warnings i think
not that that draft will apply nor quite "rebase" any more since quite a lot changed so could technically close it i guess
First build error for me is this:
diff --git a/input/wayland/redirect.cpp b/input/wayland/redirect.cpp
index 666fe6b67..bc7b6c06c 100644
--- a/input/wayland/redirect.cpp
+++ b/input/wayland/redirect.cpp
@@ -471,17 +471,18 @@ void redirect::handle_fake_input_device_added(Wrapland::Server::FakeInputDevice*
device->setAuthentication(true);
});
- auto devices
- = fake::devices<input::platform>({std::make_unique<fake::pointer>(device, &platform),
- std::make_unique<fake::keyboard>(device, &platform),
- std::make_unique<fake::touch>(device, &platform),
- platform});
+ fake::devices<input::platform> devices{
+ .pointer = std::make_unique<fake::pointer>(device, &platform),
+ .keyboard = std::make_unique<fake::keyboard>(device, &platform),
+ .touch = std::make_unique<fake::touch>(device, &platform),
+ .platform = platform,
+ };
platform_add_pointer(devices.pointer.get(), platform);
platform_add_keyboard(devices.keyboard.get(), platform);
platform_add_touch(devices.touch.get(), platform);
fake_devices.insert({device, std::move(devices)});
}
While the aggregate can be fixed with this new lovely aggregate syntax, it won't work with the move ctors defaulted in the fake::devices struct.
But if I remove the move ctors the insert into fake_devices map doesn't work anymore. :/
Then there was a second build error with sstream. But I stopped at this point.
right so new things then, but yeah once i get access to my ryzen i can test around more with building with c++20 hm
I hope until then the base-objects-2 branch is finished. I want that branch getting done so bad! 😂
isnt technically that called designated initializers that is only entering in c++20?
Actually I don't know if and how the current master code works in this regard. <del>Initializer lists</del> List initialization is a bit black magic to me.
In theory it's available since C++11: https://en.cppreference.com/w/cpp/language/constructor
Strike that.
https://en.cppreference.com/w/cpp/language/aggregate_initialization (1), (2) are available since C++11.
Roman Gilg: so yeah the draft !229 is about as far as im capable of, its still missing the integration struct initalization. and mostly because either of that struct not being implented or something else i missed. each time i test things it destroys my ~/.config/somekwinrulerc so all rules get all bonkers :P so its a bit uh hard to know if all the side effects are from the bonkers configs left around or because of the code
1 reply
seems the thread i made commenting on it didnt update the visible code but its a bit changed in the commit, worth knowing.
now to reset my poor ~/.config/kwin files 😄
unless testXdgShellClientRules is the one bonkering my local rules when i run the test locally.
anyhow thats where im at :p
i keep getting some glitches (right mouse on desktop doesn't show the menu) and some crashes. also decorations seems to be different than with kwin, not sure if that is normal
@jjcasmar_gitlab: well it should support that, is this on wayland or xorg? might be a new regression from the recent big refactors, not all settings and setups gets tested with the limited workforce working on kwinft. when most the big milestones are done it should stabilize a bit tho
@jjcasmar_gitlab: It's cool though that Wayland seems to work with reduced reliability already in general on Wayland. Thanks for the feedback. And yes, as Tom said, once big milestones are done we'll look again more into stabilizing. If you wanna help with testing or code you're most welcome.
After I got this base-objects-2 branch finished I can take a look at !229.
@jjcasmar_gitlab: Sure thing. :) Easiest way to get started is follow the steps outlined in https://gitlab.com/kwinft/kwinft/-/blob/master/CONTRIBUTING.md
First you learn how to log and debug the program efficiently. Later on it also helps with building master.
Roman Gilg: looks like either cppcheck version has catched up or the kwinft code has changed enough, it doesnt segfault on any of the files now.
So should we try to integrate it in our ci?
well, it wouldnt hurt to have as a side thing as coverity, but you are not gonna get it cleanly report no issues :p
the list is long with suggestions of prefer std:any_of or std::acumulate and bunch of other uh non issues :P
i guess it depends on the --enable=FLAGS heh
cppcheck --enable=all --std=c++20 --language=c++ * , http://ix.io/47MS obviously wildcarding is a bit wrong since it runs on non c++ files but :D
Could we disable all but one checks in the beginning and then step by step enable more?
1 reply
(while having it enforced on ci from the start)
Ok, I'll go on with the templating now in the evening after eating a curry wurst. 😁
Now after half a week most of the Toplevel types in the win directory is finally gone.