Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
    Richard Eckart de Castilho
    @reckart
    it does support passing an absolute path to part.write(...);
    Martin Grigorov
    @martin-g
    yes, Tomcat has this code, I know
    but it is against spec
    Jetty doesn't behave this way
    there was a bug report at Tomcat bugzilla by one of the Jetty developers about this
    Richard Eckart de Castilho
    @reckart
    IMHO the fix here would be not to call part.write(String) at all
    Martin Grigorov
    @martin-g
    and Tomcat team said that the spec is off
    odd*
    by opting for Servlet 3 impl I think you should expect Servlet 3 behavior
    Richard Eckart de Castilho
    @reckart
    do you believe it is necessary that ServletPartFileItem.write(File) calls Part.write(String)?
    Martin Grigorov
    @martin-g
    if Wicket does whatever it wants/needs then it will be really confusing for everyone
    immediately someone will file a bug that something is not according to Servlet spec
    Richard Eckart de Castilho
    @reckart
    if Wicket ServletPartFileItem.write(File) accepts an absolute path and Part.write(String) writes to a different location -> that is confusing
    Martin Grigorov
    @martin-g
    and it will be hard to argue with him/her
    Richard Eckart de Castilho
    @reckart
    ServletPartFileItem is not part of the Servelet 3 API
    It inherits from Apache Commons FileItem
    IMHO it doesn't need to care about the spec
    Martin Grigorov
    @martin-g
    yes, it is an adaptor for something that came a decade later (Servlet 3)
    well, write to users@
    this channel is not about Wicket core
    and I cannot take such decisions myself
    if others agree then the change is easy
    Richard Eckart de Castilho
    @reckart
    Martin Grigorov
    @martin-g
    well, I still wait for the test
    Richard Eckart de Castilho
    @reckart
    ;)
    sigh I half hoped I could convince you of the existence of the problem without having to sink time into writing that example
    Martin Grigorov
    @martin-g
    no hurries! I'm going on vacation soon
    Richard Eckart de Castilho
    @reckart
    I' am on vacation!
    Martin Grigorov
    @martin-g
    haha
    enjoy! :-)
    Richard Eckart de Castilho
    @reckart
    yeah...
    anyway :) It was nice to meet you
    Martin Grigorov
    @martin-g
    my pleasure!
    Kees van Dieren
    @keesvandieren

    Hi, we need Wicket with Bootstrap 4. We see this issue: l0rdn1kk0n/wicket-bootstrap#540

    We have lots of experience with Wicket and Bootstrap 3, but no experience with Wicket-Bootstrap.

    How much time would it approx. take us to create a wicket-bootstrap with Bootstrap 4? Will it take about a day, a few days, or weeks?

    Martin Grigorov
    @martin-g
    creating the branch would take millis :-) migrating - dunno :-/
    the problem I expect is with the third party plugins. No idea how many of them have version for v.4
    Kees van Dieren
    @keesvandieren
    :-)
    Martin Grigorov
    @martin-g
    but the ones which are not upgraded could be removed/commented out
    Kees van Dieren
    @keesvandieren
    Ok, so to start just remove everything and add every component back that is migrated / added?
    Martin Grigorov
    @martin-g
    better comment out the Maven module for -extensions in the parent pom. Then migrate -core
    Kees van Dieren
    @keesvandieren
    Ok, we will look into it. I work for a customer who has several applications, that all will be migrated on the long term. First we migrate a UI Patternlibrary (with examples of common UI elements), next we will look to the Wicket apps how to migrate them.
    Martin Grigorov
    @martin-g
    good luck! let us know if you need any advice !
    ... or extra man power
    Kees van Dieren
    @keesvandieren

    :+1: thanks for your thoughts.

    One other issue is that we still have an old-fashioned app-server with Servlet 3.0. Pushing some more to get Ops to upgrade to Servlet 3.1 to make us able to use Wicket 8

    Martin Grigorov
    @martin-g
    Wicket doesn't really use anything from Servlet 3.1. It should work with 3.0 too. You just need to convince Maven to not complain
    wicket-http2 uses Servlet 4.0 but I guess you do not use this module
    Kees van Dieren
    @keesvandieren
    Ok, great! We'll try that anyway than
    namtar
    @namtar
    Hi, I want to provide a Bootstrap Status Label (label-sucess....) Component and a BootstrapTextFilteredPropertyColumn and BootstrapChoiceFilteredPropertyColumn to be used with the BootstrapDefaultDataTable.
    My Question: Is there a preferred branch to which I should commit the code to? I made my changes on the wicket-8.x branch but I will merge it in the wicket-7.x or master branch if necessary.
    Martin Grigorov
    @martin-g
    @namtar wicket-8.x is enough!
    namtar
    @namtar
    Ok thx. I will do a pull request.