lagom/contributors

Discussion of Lagom project development: https://github.com/lagom/.github/blob/master/CONTRIBUTING.md | Use lagom/lagom channel for general discussion. | Code of Conduct: https://www.lightbend.com/conduct | Forums: https://discuss.lagomframework.com | Commercial support from https://www.lightbend.com/

Sergey Morgunov

@ihostage

Hi, maintainers! :hand: Can you transfer this issue lagom/lagom-akka-discovery-service-locator#81 to Lagom repository?

I am afraid that the issues an archived repository will be forgotten. :scream: :smile:

Renato Cavalcanti

@renatocaval

I will move it, thanks

Sergey Morgunov

@ihostage

@renatocaval :+1: Thanks!

Renato Cavalcanti

@renatocaval

FYI: lagom/lagom#1919

we can repeat the comments we added on the original one and pretend that we are having the conversation for the first time ;-)

Sergey Morgunov

@ihostage

:joy:

Links will be enough. :wink: Just I did not want to create a new issue and thought you move the original issue to the new repository (like were moved issues to lagom-samples)

Renato Cavalcanti

@renatocaval

yep, I could have done that, but need to unarchive and archive again. So took the short cut of copying the description and linking back

Sergey Morgunov

@ihostage

but need to unarchive and archive again

Oops, I did not know about these details. :man-shrugging:

Michael Liarakos

@mliarakos

I developed a prototype Lagom ScalaJS client and example project on how to use it. I have a longer explanation on lagom/lagom#571. Let me know what you think of the approach.

Elijah Rippeth

@erip

:raised_hands:

Sergey Morgunov

@ihostage

I tried to use scala.Option on structural typing in
com.lightbend.lagom.dev.Servers, but got a error:

[error] java.lang.NoSuchMethodException: com.lightbend.lagom.internal.cassandra.CassandraLauncher.start(java.io.File, java.io.File, boolean, scala.Option, [Ljava.lang.String;, java.lang.ClassLoader)
[error]     at java.lang.Class.getMethod(Class.java:1786)
[error]     at com.lightbend.lagom.dev.Servers$CassandraServer$.reflMethod$Method4(Servers.scala:217)

Want to known why? Because Scala Library loaded by different class loaders from different places (~/.ivy2/cache/org.scala-lang/scala-library/jars/scala-library-2.12.8.jar!/scala/Option.class and ~/.sbt/boot/scala-2.12.4/lib/scala-library.jar!/scala/Option.class) :smile:
I knew about class loaders, but forget that Scala is just library (for JVM in runtime, of course) :smile: and lost hour for remember this :disappointed: My brain almost exploded, because I tried find difference in method signatures, but signatures (stringified) are absolutely equals :joy:

Elijah Rippeth

@erip

I know y'all have been busy, but has anyone had a chance to look at @mliarakos's SJS branch? Perhaps a WIP PR is a good option for a review?

Renato Cavalcanti

@renatocaval

@erip, I had a quick look

my personal take on it is that this would be good as an extension

thus not intergated inside Lagom

would that be possible?

Elijah Rippeth

@erip

I don't think so since it requires changes to the lagom internals.

Though very minimally

I suspect if those changes were made separately it might be possible.

Renato Cavalcanti

@renatocaval

Maybe a DRAFT PR, so we can easily compare the source code

Elijah Rippeth

@erip

:+1: The required changes are outlined here: https://github.com/lagom/lagom/issues/571#issuecomment-508942154

A large number of changes are just SJS compatibility changes of artifacts. The lagom changes are basically breaking components into separate files and adding a few abstractions.

Will talk to @mliarakos in case he isn't on gitter often. :)

Renato Cavalcanti

@renatocaval

one thing to take into account is that in the coming months we will be adding bits of Lagom back into Play
and the whole idea is to reduce Lagom’s code base (it should become a thin layer on top of Play)
this goes on the opposite direction because it increases Lagom, adds a new runtime (javascript) and more things to maintain

that’s why I would prefer it to be a side project

Elijah Rippeth

@erip

Understood. Some of the changes could likely be ported upstream, but don't quote me on that

The abstractions might be useful for Lagom even outside of this context (e.g., not relying so heavily on a wsClient from play)

Sergey Morgunov

@ihostage

Hi, folks! :wave:
What do you think about lagom/lagom-java.g8#60 ?

Tim Moore

@TimMoore

@ihostage I'll have to leave that up to the core development team. Seems like a fine idea IMHO but I'm not the one who will be maintaining it.

@ignasi35 any thoughts?

Sergey Morgunov

@ihostage

@TimMoore The core team is very busy until :disappointed: But you came to light and I caught you on the common channel. :joy:

Tim Moore

@TimMoore

Indeed we all are :)

Sergey Morgunov

@ihostage

:joy:

Tim Moore

@TimMoore

Some people have had summer holidays, too... everything slows down a bit (except of course for support requests somehow)

Sergey Morgunov

@ihostage

I understand :wink:

yakovlevdmv

@yakovlevdmv

Hello,
I'm doing PR lagom/lagom#2251 . I got to the point when I need an outside perspective. Some points are not so obvious. I'd appreciate any response.

Dale Wijnand

@dwijnand

Please note that Lagom 1.6.0-RC1 is released, using Akka 2.6.0-RC2 and Play 2.8.0-RC1.

Sergey Morgunov

@ihostage

:tada:

Sergey Morgunov

@ihostage

Hi, folks! :wave:
@marcospereira @renatocaval Can you find a time to back on our discussion on the forum about release Play SOAP and review my PRs?

Renato Cavalcanti

@renatocaval

@ihostage, sorry for that. I thought this was already done. I lost track

I will wait for Marcos to come online. It's morning for him

Sergey Morgunov

@ihostage

Thank you, Renato :+1:
Just some member of community wait release with support Scala 2.13
playframework/play-soap#108

Renato Cavalcanti

@renatocaval

@ihostage, we are running short in time because right now. We have Play / Lagom major releases that we want to finalize and next week we have company meeting. Can we post pone it to after next week?

Sergey Morgunov

@ihostage

@renatocaval I think — yes :smile:
Moreover, if you do several actions that I described on our discussion on the forum, in the future Play Core Team not need to spend time for release Play SOAP. I can do that myself as maintainer. :wink:

Dale Wijnand

@dwijnand

Hey! Please note that Lagom 1.6.0-RC2 is released, with a couple of critical bug fixes: https://github.com/lagom/lagom/releases/tag/1.6.0-RC2

Sergey Morgunov

@ihostage

@dwijnand :+1:

Renato Cavalcanti

@renatocaval

this is a test

that didn't work as expect :-(

I just enabled thread conversations here, but I'm not sure how to use it

Where communities thrive

People

Repo info

Activity