lagom/contributors

Discussion of Lagom project development: https://github.com/lagom/.github/blob/master/CONTRIBUTING.md | Use lagom/lagom channel for general discussion. | Code of Conduct: https://www.lightbend.com/conduct | Forums: https://discuss.lagomframework.com | Commercial support from https://www.lightbend.com/

Renato Cavalcanti

@renatocaval

@erip, I had a quick look

my personal take on it is that this would be good as an extension

thus not intergated inside Lagom

would that be possible?

Elijah Rippeth

@erip

I don't think so since it requires changes to the lagom internals.

Though very minimally

I suspect if those changes were made separately it might be possible.

Renato Cavalcanti

@renatocaval

Maybe a DRAFT PR, so we can easily compare the source code

Elijah Rippeth

@erip

:+1: The required changes are outlined here: https://github.com/lagom/lagom/issues/571#issuecomment-508942154

A large number of changes are just SJS compatibility changes of artifacts. The lagom changes are basically breaking components into separate files and adding a few abstractions.

Will talk to @mliarakos in case he isn't on gitter often. :)

Renato Cavalcanti

@renatocaval

one thing to take into account is that in the coming months we will be adding bits of Lagom back into Play
and the whole idea is to reduce Lagom’s code base (it should become a thin layer on top of Play)
this goes on the opposite direction because it increases Lagom, adds a new runtime (javascript) and more things to maintain

that’s why I would prefer it to be a side project

Elijah Rippeth

@erip

Understood. Some of the changes could likely be ported upstream, but don't quote me on that

The abstractions might be useful for Lagom even outside of this context (e.g., not relying so heavily on a wsClient from play)

Sergey Morgunov

@ihostage

Hi, folks! :wave:
What do you think about lagom/lagom-java.g8#60 ?

Tim Moore

@TimMoore

@ihostage I'll have to leave that up to the core development team. Seems like a fine idea IMHO but I'm not the one who will be maintaining it.

@ignasi35 any thoughts?

Sergey Morgunov

@ihostage

@TimMoore The core team is very busy until :disappointed: But you came to light and I caught you on the common channel. :joy:

Tim Moore

@TimMoore

Indeed we all are :)

Sergey Morgunov

@ihostage

:joy:

Tim Moore

@TimMoore

Some people have had summer holidays, too... everything slows down a bit (except of course for support requests somehow)

Sergey Morgunov

@ihostage

I understand :wink:

yakovlevdmv

@yakovlevdmv

Hello,
I'm doing PR lagom/lagom#2251 . I got to the point when I need an outside perspective. Some points are not so obvious. I'd appreciate any response.

Dale Wijnand

@dwijnand

Please note that Lagom 1.6.0-RC1 is released, using Akka 2.6.0-RC2 and Play 2.8.0-RC1.

Sergey Morgunov

@ihostage

:tada:

Sergey Morgunov

@ihostage

Hi, folks! :wave:
@marcospereira @renatocaval Can you find a time to back on our discussion on the forum about release Play SOAP and review my PRs?

Renato Cavalcanti

@renatocaval

@ihostage, sorry for that. I thought this was already done. I lost track

I will wait for Marcos to come online. It's morning for him

Sergey Morgunov

@ihostage

Thank you, Renato :+1:
Just some member of community wait release with support Scala 2.13
playframework/play-soap#108

Renato Cavalcanti

@renatocaval

@ihostage, we are running short in time because right now. We have Play / Lagom major releases that we want to finalize and next week we have company meeting. Can we post pone it to after next week?

Sergey Morgunov

@ihostage

@renatocaval I think — yes :smile:
Moreover, if you do several actions that I described on our discussion on the forum, in the future Play Core Team not need to spend time for release Play SOAP. I can do that myself as maintainer. :wink:

Dale Wijnand

@dwijnand

Hey! Please note that Lagom 1.6.0-RC2 is released, with a couple of critical bug fixes: https://github.com/lagom/lagom/releases/tag/1.6.0-RC2

Sergey Morgunov

@ihostage

@dwijnand :+1:

Renato Cavalcanti

@renatocaval

this is a test

that didn't work as expect :-(

I just enabled thread conversations here, but I'm not sure how to use it

14 replies

Lukáš Kováč

@bossqone

Hi everyone. First of all, kudos to you guys. We are using Lagom at work and it's great. Anyway, we have scenario where we want to publish only some messages to topic using TopicProducer. Current design requires to produce (Message, Offset) pair for message to be published. So in case we filter out messages, it won't commit offset until another message pass through, which results in unnecessary replays when app restarts. I've been playing with API of TopicProducer locally and changing it to accept Source[(Option[Message], Offset), Any] instead of Source[(Message, Offset), Any]. I wanted to ask if this is desirable change before I submit a PR.

Renato Cavalcanti

@renatocaval

Hi @bossqone, sorry for the silence on the line.

I saw your PR and will comment there, but in a nutshell, the way it is now, it's backward-incompatible.

Guy Youansi

@ralphlaude

Hi, i have some issues with multi-jvm tests locally and also the sbt scripted. Mul ti-jvm tests failed for example for the project (persistence-cassandra-javads). sbt srcriptrd throws this errors

[info] [error] (update) sbt.librarymanagement.ResolveException: unresolved dependency: com.lightbend.lagom#lagom-sbt-plugin;1.6.0+209-e7410a29: not found
[info] [error] unresolved dependency: com.lightbend.lagom#lagom-sbt-scripted-tools;1.6.0+209-e7410a29: not found

Thanks for help it is about this (lagom/lagom#2645)

cajoruto

@cajoruto

Hi guys

I have some spare time, and I would like to contribute patching lagom core. Since I don't have experience contributing with OSS projects. I would like to start with some first issues tag. If you allow me of course.
e.g. lagom/lagom#2553

Sergey Morgunov

@ihostage

@cajoruto No problem. Of course, you can help :+1:

Guy Youansi

@ralphlaude

Hi guys, i have problem here (lagom/lagom#2645) i need some help.

Miroslav Matejovsky

@bassmake

I am unable to import lagom/docs/build.sbt as mentioned here: https://github.com/lagom/lagom/blob/master/CONTRIBUTING.md#development-tips.
IntellijJ version: 2020.1 (but was not working with 2019.3.4 as well)
error:

[error] (lagom-internal-meta-project-kafka / update) sbt.librarymanagement.ResolveException: Error downloading com.lightbend.lagom:lagom-kafka-server_2.12:1.6.1+367-8c8cff59
[error]   Not found
[error]   Not found
[error]   not found: /Users/miroslav.matejovsky/.ivy2/local/com.lightbend.lagom/lagom-kafka-server_2.12/1.6.1+367-8c8cff59/ivys/ivy.xml
[error]   not found: https://repo1.maven.org/maven2/com/lightbend/lagom/lagom-kafka-server_2.12/1.6.1+367-8c8cff59/lagom-kafka-server_2.12-1.6.1+367-8c8cff59.pom
[error] (lagom-internal-meta-project-service-locator / update) sbt.librarymanagement.ResolveException: Error downloading com.lightbend.lagom:lagom-service-locator_2.12:1.6.1+367-8c8cff59
[error]   Not found
[error]   Not found
[error]   not found: /Users/miroslav.matejovsky/.ivy2/local/com.lightbend.lagom/lagom-service-locator_2.12/1.6.1+367-8c8cff59/ivys/ivy.xml
[error]   not found: https://repo1.maven.org/maven2/com/lightbend/lagom/lagom-service-locator_2.12/1.6.1+367-8c8cff59/lagom-service-locator_2.12-1.6.1+367-8c8cff59.pom
[error] (lagom-internal-meta-project-cassandra / update) sbt.librarymanagement.ResolveException: Error downloading com.lightbend.lagom:lagom-cassandra-server_2.12:1.6.1+367-8c8cff59
[error]   Not found
[error]   Not found
[error]   not found: /Users/miroslav.matejovsky/.ivy2/local/com.lightbend.lagom/lagom-cassandra-server_2.12/1.6.1+367-8c8cff59/ivys/ivy.xml
[error]   not found: https://repo1.maven.org/maven2/com/lightbend/lagom/lagom-cassandra-server_2.12/1.6.1+367-8c8cff59/lagom-cassandra-server_2.12-1.6.1+367-8c8cff59.pom
[error] (lagom-internal-meta-project-kafka / ssExtractDependencies) sbt.librarymanagement.ResolveException: Error downloading com.lightbend.lagom:lagom-kafka-server_2.12:1.6.1+367-8c8cff59
[error]   Not found
[error]   Not found
[error]   not found: /Users/miroslav.matejovsky/.ivy2/local/com.lightbend.lagom/lagom-kafka-server_2.12/1.6.1+367-8c8cff59/ivys/ivy.xml
[error]   not found: https://repo1.maven.org/maven2/com/lightbend/lagom/lagom-kafka-server_2.12/1.6.1+367-8c8cff59/lagom-kafka-server_2.12-1.6.1+367-8c8cff59.pom
[error] (lagom-internal-meta-project-service-locator / ssExtractDependencies) sbt.librarymanagement.ResolveException: Error downloading com.lightbend.lagom:lagom-service-locator_2.12:1.6.1+367-8c8cff59
[error]   Not found
[error]   Not found
[error]   not found: /Users/miroslav.matejovsky/.ivy2/local/com.lightbend.lagom/lagom-service-locator_2.12/1.6.1+367-8c8cff59/ivys/ivy.xml
[error]   not found: https://repo1.maven.org/maven2/com/lightbend/lagom/lagom-service-locator_2.12/1.6.1+367-8c8cff59/lagom-service-locator_2.12-1.6.1+367-8c8cff59.pom
[error] (lagom-internal-meta-project-cassandra / ssExtractDependencies) sbt.librarymanagement.ResolveException: Error downloading com.lightbend.lagom:lagom-cassandra-server_2.12:1.6.1+367-8c8cff59
[error]   Not found
[error]   Not found
[error]   not found: /Users/miroslav.matejovsky/.ivy2/local/com.lightbend.lagom/lagom-cassandra-server_2.12/1.6.1+367-8c8cff59/ivys/ivy.xml
[error]   not found: https://repo1.maven.org/maven2/com/lightbend/lagom/lagom-cassandra-server_2.12/1.6.1+367-8c8cff59/lagom-cassandra-server_2.12-1.6.1+367-8c8cff59.pom
[error] Total time: 26 s, completed 12 Apr 2020, 14:46:36
[info] shutting down sbt server

Any tips?

Ignasi Marimon-Clos

@ignasi35

Hmm, I think a user@root-lagom-foder/$ sbt +publishLocal before you try to load the project in IntelliJ should fix this issue. It sounds like a consequence of moving to sbt-dynver

Rajkumar Parthasarathi

@praajoo

Hi - I am deploying Lagom java services with persistance and message broker in Openshift platform and using discovery-method as kubernetes-api. I am having an issue in RBAC, as y orgnization does not give this Role and Role binding to be available for users. It is a financial organization and they say it is an Audit restriction to give all the pd objects which also contains environment variables along with it. Is there a way that we have a call to kubernettes to give only pod details rather than getting all pod objects. I see kubernettes mentions that api for get pod have "fields" passed in to be returned rather than getting all the details. Or is there a way that we contribute a different method to kubernettes which has to give back only pod detaiils and not the environment variables. doing kubernetes-api way of discovery makes life so easier, but this restriction makes to take other path, which is not so simple like this.

Ignasi Marimon-Clos

@ignasi35

Hi @praajoo, unfortunately the cluster bootstrap operation sort of requires using kubernetes-api. Using akka-dns, for example, is not possible because the kubernetes DNS will not expose a POD until it’s ready and a lagom node is not ready until it has joind the cluster, and it won’t join the cluster until it can locate it’s peers that won’t be locatable until ready, and note ready until …
That being said, if you can think of alternative implementations for the discovery step of the cluster boostraping phase that don’t rely on Kubernetes api or extra RBAC settings it’d be a great addition!
I think this will be better contributed as an akka management subproject in https://github.com/akka/akka-management/

Rajkumar Parthasarathi

@praajoo

Hi @praajoo, unfortunately the cluster bootstrap operation sort of requires using kubernetes-api. Using akka-dns, for example, is not possible because the kubernetes DNS will not expose a POD until it’s ready and a lagom node is not ready until it has joind the cluster, and it won’t join the cluster until it can locate it’s peers that won’t be locatable until ready, and note ready until …
That being said, if you can think of alternative implementations for the discovery step of the cluster boostraping phase that don’t rely on Kubernetes api or extra RBAC settings it’d be a great addition!
I think this will be better contributed as an akka management subproject in https://github.com/akka/akka-management/

Thanks @ignasi35 , what I was thinking is instead of calling kubernetes api to return all the pod objects, if we can find another api of kubernetes which only gives the pod status and any other required pod details for the cluster start up, shall we use that for discovery phase !!! Let me try if that is feasible and like to contribute for it....

Ignasi Marimon-Clos

@ignasi35

:point_up: June 23, 2020 6:48 AM :-) that’d be a great contribution! Please note that all discovery implementations and discussions are happening in https://github.com/akka/akka-management/

Where communities thrive

People

Repo info

Activity