by

Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
Renato Cavalcanti
@renatocaval
thanks, I will check it in a while
Elijah Rippeth
@erip
btw, is @ignasi35 responsible for reviewing the unidoc PR when he gets back from vacation?
Renato Cavalcanti
@renatocaval
no, but we can make him responsible if you want :-)
I'm back today, still catching up
it's on our list @erip
it's just going slowly during summer breaks
Elijah Rippeth
@erip
No, I just wanted to make sure. :smile: I'm excited to keep pushing on the sbt 1.x stuff.
Renato Cavalcanti
@renatocaval
@erip I was about to merge and then I saw a small improvements we can still make
left a comment here: https://github.com/lagom/lagom/pull/1527/files#r211369678
Elijah Rippeth
@erip
done
:+1:
Ignasi Marimon-Clos
@ignasi35
@erip are you around? (this is probably better to discuss lagom/lagom#1542 )
:point_up: August 20, 2018 3:55 PM LOL
Elijah Rippeth
@erip
I am
:smile:
Ignasi Marimon-Clos
@ignasi35
Nice, about the dependency issues. Is it possible you were not reloading your project after tunning the dependencies?
Elijah Rippeth
@erip
It's very possible...
Let me clone on my work laptop and give it a shot
Ignasi Marimon-Clos
@ignasi35
No rush. I’ll have to go offline in a bit. I can catch up later tonight.
Elijah Rippeth
@erip
The proposal is to simply remove % Test, right?
And not to replace it with % "compile->compile;test->test"
Ignasi Marimon-Clos
@ignasi35
yes
I think that should work.
Elijah Rippeth
@erip
ok, sbt is getting warm now
It seems OK now... I'll commit it.
Elijah Rippeth
@erip
I can test it with the online auction test after work, but I don't suspect there will be any big problems... the question is how to do something similar with JUnit
I guess just with a @Before and @After
Ignasi Marimon-Clos
@ignasi35
did you see my last comment ?
Elijah Rippeth
@erip
I did. Should we wait for that to be contributed before proceeding?
I almost wonder if the resetting of the issues buffer is worthy of being considered a bug?
i.e., allIssues doesn't actually capture all issues of a driver -- it captures all issues of a run
Ignasi Marimon-Clos
@ignasi35
That’s what I remembered… Then my suggestion for a FailFastPersistentEntityTestDriver becomes more interesting. Hmm...
It’s worth discussing on the original issue lagom/lagom#1348 though to get more feedback.
Elijah Rippeth
@erip
See here and here
Oh, I see..
Elijah Rippeth
@erip
These changes are exciting! nice job, all. :clap:
Ivan
@advancedwebdeveloper
Hello people
Elijah Rippeth
@erip
Hello
Jules Ivanic
@guizmaii
Hello
Elijah Rippeth
@erip
eventually consistent greetings. :laughing:
Elijah Rippeth
@erip
Does it make sense to prescribe/recommend a repo structure?

My team has been really fond of something like this:

api
├── MyService.scala
├── domain
│   └── package.scala
├── events
│   └── package.scala
└── commands
    └── package.scala

which is really organizationally nice... not sure if that's how opinionated Lagom wants to be, though.

Similar thing for impl, but we have readsides, entities, etc.
Elijah Rippeth
@erip
Also, after taking the reactive systems courses that Lightbend offered, I've been wondering if it even makes sense to bundle domain in the api. I could seem the domain being a separate logical project.
that way the domain, api, and impl (infrastructure) are separated according to the hexagonal architecture
Elijah Rippeth
@erip
Oops, I also forgot exceptions in the api -- we have those, too. :smile:
Jules Ivanic
@guizmaii

eventually consistent greetings. :laughing:

:smile:

Does it make sense to prescribe/recommend a repo structure?

I have to write a blog post about that

To enforce some rules, we’ve “improved” (for us, at least) the Lagom layout
there’s more than api and impl for each services