by

Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
Ignasi Marimon-Clos
@ignasi35
:point_up: August 20, 2018 3:55 PM LOL
Elijah Rippeth
@erip
I am
:smile:
Ignasi Marimon-Clos
@ignasi35
Nice, about the dependency issues. Is it possible you were not reloading your project after tunning the dependencies?
Elijah Rippeth
@erip
It's very possible...
Let me clone on my work laptop and give it a shot
Ignasi Marimon-Clos
@ignasi35
No rush. I’ll have to go offline in a bit. I can catch up later tonight.
Elijah Rippeth
@erip
The proposal is to simply remove % Test, right?
And not to replace it with % "compile->compile;test->test"
Ignasi Marimon-Clos
@ignasi35
yes
I think that should work.
Elijah Rippeth
@erip
ok, sbt is getting warm now
It seems OK now... I'll commit it.
Elijah Rippeth
@erip
I can test it with the online auction test after work, but I don't suspect there will be any big problems... the question is how to do something similar with JUnit
I guess just with a @Before and @After
Ignasi Marimon-Clos
@ignasi35
did you see my last comment ?
Elijah Rippeth
@erip
I did. Should we wait for that to be contributed before proceeding?
I almost wonder if the resetting of the issues buffer is worthy of being considered a bug?
i.e., allIssues doesn't actually capture all issues of a driver -- it captures all issues of a run
Ignasi Marimon-Clos
@ignasi35
That’s what I remembered… Then my suggestion for a FailFastPersistentEntityTestDriver becomes more interesting. Hmm...
It’s worth discussing on the original issue lagom/lagom#1348 though to get more feedback.
Elijah Rippeth
@erip
See here and here
Oh, I see..
Elijah Rippeth
@erip
These changes are exciting! nice job, all. :clap:
Ivan
@advancedwebdeveloper
Hello people
Elijah Rippeth
@erip
Hello
Jules Ivanic
@guizmaii
Hello
Elijah Rippeth
@erip
eventually consistent greetings. :laughing:
Elijah Rippeth
@erip
Does it make sense to prescribe/recommend a repo structure?

My team has been really fond of something like this:

api
├── MyService.scala
├── domain
│   └── package.scala
├── events
│   └── package.scala
└── commands
    └── package.scala

which is really organizationally nice... not sure if that's how opinionated Lagom wants to be, though.

Similar thing for impl, but we have readsides, entities, etc.
Elijah Rippeth
@erip
Also, after taking the reactive systems courses that Lightbend offered, I've been wondering if it even makes sense to bundle domain in the api. I could seem the domain being a separate logical project.
that way the domain, api, and impl (infrastructure) are separated according to the hexagonal architecture
Elijah Rippeth
@erip
Oops, I also forgot exceptions in the api -- we have those, too. :smile:
Jules Ivanic
@guizmaii

eventually consistent greetings. :laughing:

:smile:

Does it make sense to prescribe/recommend a repo structure?

I have to write a blog post about that

To enforce some rules, we’ve “improved” (for us, at least) the Lagom layout
there’s more than api and impl for each services
then you can enforce that some code are isolated from each other
Elijah Rippeth
@erip
@guizmaii Yeah, I think domain, api, impl makes sense.
Jules Ivanic
@guizmaii
we also have dto (for Data Transfer Object, maybe a better name can be found. It sounds maybe too much JavaEE bullshit), which are our APIs data structures and we have messages which are our data structures transitings via Kafka
and maybe more. I forgot. I don’t work that much on that project these days
api depends on dto and messages but dto and messages don’t know each others
Jules Ivanic
@guizmaii
APIs data structures and data transiting throught Kafka don’t have the same lifrcycle constraints that why they should be strictly separated
Elijah Rippeth
@erip
Maybe I'll just create a g8 template
Ignasi Marimon-Clos
@ignasi35
just caching up with past conversations here. I like where the conversation is going TBH. Any recommendation from real-world use of lagom to help keep the code well organised and clean is worth evaluating. @guizmaii I’m looking forward to your blog post :-)
Jules Ivanic
@guizmaii
:+1:
Elijah Rippeth
@erip
I've definitely got a lot of TODOs recently from lagom, but I'll try to come up with a g8 template that reflects how I organize things. @guizmaii, I'd be happy if you wanted to work on it, too. Once it's in a good place, I can ping you, @ignasi35
Jules Ivanic
@guizmaii

@guizmaii, I'd be happy if you wanted to work on it, too

Ok let me know what you need