Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • Apr 07 23:12

    mergify[bot] on master

    Update scalatest to 3.1.1 Merge pull request #2723 from s… (compare)

  • Apr 07 23:12
    mergify[bot] closed #2723
  • Apr 07 22:09
    ihostage synchronize #2723
  • Apr 07 22:04

    mergify[bot] on master

    Update h2 to 1.4.200 Auto create database for remote… Merge pull request #2333 from s… (compare)

  • Apr 07 22:04
    mergify[bot] closed #2333
  • Apr 07 20:59
    ihostage synchronize #2333
  • Apr 07 18:50
    mergify[bot] closed #2536
  • Apr 07 17:46
    ihostage synchronize #2536
  • Apr 07 15:48
    Travis renatocaval/lagom (fix-projection-registry-flaky) passed (238)
  • Apr 07 14:59

    mergify[bot] on 1.5.x

    Start CassandraLauncher before … Merge pull request #2811 from r… (compare)

  • Apr 07 14:59
    mergify[bot] closed #2811
  • Apr 07 14:51

    mergify[bot] on 1.6.x

    fix flaky ClusterDistributionSp… Merge pull request #2812 from r… (compare)

  • Apr 07 14:51
    mergify[bot] closed #2812
  • Apr 07 14:48
    mergify[bot] commented #2813
  • Apr 07 14:47
    renatocaval commented #2813
  • Apr 07 14:43
    renatocaval edited #2813
  • Apr 07 14:42
    renatocaval opened #2813
  • Apr 07 14:30
    Travis renatocaval/lagom@d2124a4 (backport-2770-on-1.6.x) passed (237)
  • Apr 07 14:22

    mergify[bot] on 1.6.x

    Start CassandraLauncher before … Merge pull request #2810 from r… (compare)

  • Apr 07 14:22
    mergify[bot] closed #2810
Renato Cavalcanti
@renatocaval
we will also get here all Travis activity for those same channels
Sergey Morgunov
@ihostage
:+1:
:point_up: September 24, 2018 4:39 PM @renatocaval Thank you! Now I think that the injecting MetricsService by implementation is normal case.
Ignasi Marimon-Clos
@ignasi35
:point_up: September 24, 2018 3:51 PM I think MetricsService may be removed some time in the future. It’s a service providing per-instance information so it’s weird to read that info via RPC (where you usually want to treat all instances/nodes equally). Instead, metrics should be pushed to an external aggregator to create some form of dashboard.
Sergey Morgunov
@ihostage
@ignasi35 Thank you! We will try to follow the updates MetricsService. Now we do the following. We subscribe to the stream of data from MetricsService and push data to an external MetricRegistry (+ graphite reporter).
Marcos Pereira
@marcospereira
Hum... okay so we had some failures in https://travis-ci.org/lagom/lagom/jobs/432892553. Will submit a pr to fix them now.
Ignasi Marimon-Clos
@ignasi35
@marcospereira I think the cron idea will not work as good in Lagom because of the validateDependecyWhitelist. As soon as Akka bumps a version the cron will be broken until Akka makes the release and Lagom bumps the release and fixes the whitelist.
Dale Wijnand
@dwijnand
Sounds like Marcos found a way to get an early warning. :)
Marcos Pereira
@marcospereira
:point_up: September 25, 2018 9:04 AM @ignasi35 validateDependencyWhitelist worked locally, but yeah, I was considering that too.
Marcos Pereira
@marcospereira
:point_up: September 25, 2018 7:49 AM here are the fixes: lagom/lagom#1604
Tim Moore
@TimMoore
@ignasi35 @marcospereira could you exclude the whitelist validation from the cron job?
Elijah Rippeth
@erip
Anyone know about this?
I know you all prefer discuss for Lagom questions, so I've been trying to tackle the StackOverflow questions. I'm not sure about this one, though.
Ignasi Marimon-Clos
@ignasi35
isn’t it ?
and also https://gitter.im/lagom/lagom?at=5bab622d8ddf5867dc772fef. (which I just posted). @erip feel free to copy/paste/adapt into SO.
:-)
Elijah Rippeth
@erip
So it is!
Sergey Morgunov
@ihostage
:point_up: September 26, 2018 1:36 PM The author is the same :smile:
kerr
@hepin1989
It will be possible to define a service call with grpc instead of rest endpoints right?
Elijah Rippeth
@erip
@hepin1989 I think that might be a better question for lagom/lagom or discuss.
Ignasi Marimon-Clos
@ignasi35
@hepin1989 yes. But, like @erip said, let’s move to a users channel instead of keeping the discussion here (contributors). Thanks. :-)
Jules Ivanic
@guizmaii
Hi @vasiliy-komarov, this channel is dedicated to discussion about implementations of new things in Lagom
can you stay in the lagom/lagom channel plz for this keed of requests
vasiliy-komarov
@vasiliy-komarov
@guizmaii Okay, sorry.
Jules Ivanic
@guizmaii
thanks :)
Renato Cavalcanti
@renatocaval
I created a 1.5.x branch for Lagom. This is the branch where we are going to finalize the RC cycle and cut the GA
master is now 1.6.0-SNAPSHOT
all work should be done in master and whenever we have something that we want to have in 1.5.0, we cherrypick it onto 1.5.x branch
Przemek Sokół
@falconepl

Hi all! :) I've been wondering recently... when it comes to Scala DSL for Lagom, it feels much like the Java DSL. I can see that oftentimes the return type is a Unit, with side-effects, we reference context in a few places, rather than simply provide a A => B function here and there.

Namely, instead of something like a DSL in akka-ddd [source]:

def canceledOrClosed: Actions =
  handleCommand {
    case CloseReservation(reservationId) =>
      ReservationClosed(reservationId)

    case CancelReservation(reservationId) =>
      ReservationCanceled(reservationId)
  }
  .handleEvent {
    case ReservationCanceled(_) => Canceled
    case ReservationClosed(_) => Closed
  }

we end up writing:

case (AddPost(content), ctx, state) =>
  ctx.thenPersist(PostAdded(entityId, content)) { evt =>
    ctx.reply(AddPostDone(entityId))
  }

or:

case (AddPost(content), ctx, state) =>
  if (content.title == null || content.title.equals("")) {
    ctx.invalidCommand("Title must be defined")
    ctx.done
  }

My questions is - is there any particular reason why Scala DSL for Lagom does not feel Scala-idiomatic and resembles patterns common for Java-like frameworks? (diverging from FP, side-effects etc.)

Przemek Sokół
@falconepl

Wouldn't it be better if one might be able to say e.g.:

case AddPost(content) =>
  PostAdded(entityId, content)
(...)
case PostAdded(entityId, _) =>
  AddPostDone(entityId)

and:

case AddPost(Content(None, _)) | AddPost(Content(Some(""), _)) =>
  InvalidCommand("Title must be defined")

What do you think?

Ignasi Marimon-Clos
@ignasi35
If I remember correctly the main reason for not using pattern matching in lagom’s scaladsl Persistent Entities was having typed responses to commands.
Elijah Rippeth
@erip
:point_up: there are (untyped) PersistentActors in some layer of the lasagna; they may be replaceable by typed persistent actors eventually, but the bottom line was to add responses which have type info
Jules Ivanic
@guizmaii

Hi @JohnReedLOL,

This channel is for discussing about Lagom feature development and/or bug fix development. It’s not for requiring help.

Sergey Morgunov
@ihostage
Hi, contributors!
Can you share your plans about supporting Kafka 2.1.X on Lagom 1.4.X? Or It will be supported only on 1.5.X?
Current situation:
  1. Kafka 2.1.X supported by only Alpakka Kafka Connector 1.0-RC1
  2. lagom/lagom#1673. Merged to 1.5.X, but need backport to 1.4.X
  3. lagom/lagom#1671. Until not merged and not backported.
Renato Cavalcanti
@renatocaval
@ihostage, #1673 was merged in master and needs backport to 1.5.x
we have a 1.5.x branch for the release candidate cycle
we won't port it in 1.4.x
which bring us to your original question, Kafka 2.1.x needs to go in 1.5.0 only
Sergey Morgunov
@ihostage
@renatocaval Thanks a lot! :ok_hand:
kerr
@hepin1989
Will lagom provide an kotlin dsl?
Sergey Morgunov
@ihostage
@hepin1989 Have you specific case? We use Kotlin with Lagom Java DSL and until all fine.
kerr
@hepin1989
@ihostage I mean more kotlin native /stylish
there are some guy complain about that...
Ignasi Marimon-Clos
@ignasi35
I don’t think it’s on the roadmap, no.
Wayne Wang
@WayneWang12
getquill/quill#1299 I've made this pull request for quill to support lagom.
Can anyone do a little review for it?
And also I think lagom should have a support for aggretion query. For example, I have to change the unit test for size query
await(context.run(entitySize)) mustEqual Option(entries.size)