Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • 09:12
    Travis lagom/lagom (master) fixed (6075)
  • 07:46

    dwijnand on master

    New Akka & Play Adapt to Akka 2.6.0-M8 Mark broken tests as pending to… and 1 more (compare)

  • 07:46
    dwijnand closed #2350
  • 00:40
    a1kemist edited #2360
  • 00:33
    triage-new-issues[bot] labeled #2360
  • 00:33
    a1kemist opened #2360
  • Oct 18 23:22
    michael-read commented #2354
  • Oct 18 22:19
    Travis lagom/lagom (master) broken (6074)
  • Oct 18 21:42
  • Oct 18 21:07
    scala-steward opened #2359
  • Oct 18 20:43

    mergify[bot] on master

    #1334 remove SBT_OPTS documenta… Merge pull request #2356 from f… (compare)

  • Oct 18 20:43
    mergify[bot] closed #2356
  • Oct 18 20:43
    mergify[bot] closed #1334
  • Oct 18 19:06
  • Oct 18 18:45
    Travis lagom/lagom#2356 broken (6066)
  • Oct 18 18:09
    Travis lagom/lagom#2356 broken (6066)
  • Oct 18 18:04
    marcospereira edited #2356
  • Oct 18 17:55

    mergify[bot] on master

    Adds a transitive dep tp akka t… Merge pull request #2343 from i… (compare)

  • Oct 18 17:55
    mergify[bot] closed #2343
  • Oct 18 17:55
    mergify[bot] closed #2342
Sergey Morgunov
@ihostage
Hmmm. Kustomize looks better than custom jq transformation.
Sergey Morgunov
@ihostage
Hi, contributors! :wink:
@dwijnand Please, add to backlog 1.5.0 this issue lagom/lagom#1772 :pray:
Dale Wijnand
@dwijnand
done
Sergey Morgunov
@ihostage
Thanks a lot! :+1:
Alden Torres
@aldenml_gitlab
Hi!, good morning, working with Lagom 1.5.0-RC2, I'm using akka.remote.serialization.ProtobufSerializer in my akka.actor serialization configuration, but in order to do that, I need to add "com.typesafe.akka" %% "akka-remote" % "2.5.21" to my build.sbt. Now, it's my understanding that akka can be a little picky when mixing versions. In order to guarantee that I'm using the same version that Lagom is using internally, I would like to expose that version via the Lagom plugin. I see that the Lagom version is exposed with https://github.com/lagom/lagom/blob/master/project/Tasks.scala#L8, I just can't figure out where is the right place to communicate an internal (but very important) dependency version number. Or is this idea a wrong approach? Thanks
Sergey Morgunov
@ihostage
@aldenml_gitlab Directly change the version of Lagom transitive dependencies in your libraryDependencies. See example
And I’m not sure, that this room is right place for your question :smile: I recommend to use discussion forum or general room :wink:
Alden Torres
@aldenml_gitlab
OK, I read in the github issue template If you have a feature request, the [contributors channel](https://gitter.im/lagom/contributors) is a better forum than an issue tracker to discuss it.
keep in mind that my question is not about how sbt resolve my dependencies, but about where to put (if it's a sound idea) an AkkaVersion in the lagom plugin in order to create a PR
Sergey Morgunov
@ihostage
Lagom 1.5.X already have a dependency on Akka 2.5.21 https://github.com/lagom/lagom/blob/1.5.x/project/Dependencies.scala
Just wait for next release or temporary build your custom version of Lagom :wink:
Alden Torres
@aldenml_gitlab
already using 1.5.0-RC2, but for the specific case of "com.typesafe.akka" %% "akka-remote", this dependency is not added out of the box to a project using LagomScala (but that's fine, that's not the problem)
Ignasi Marimon-Clos
@ignasi35
"com.typesafe.akka" %% "akka-remote” should be added to any LagomScala project that needs clustering. PErsistence, PubSub and durectu use of lagomClsuter use clustering.
Alden Torres
@aldenml_gitlab
@ignasi35 thank you very much!, I just confirmed that my problem was that I was starting from a bare minimum lagom service, adding akka.remote.serialization.ProtobufSerializer to my application.conf failed at runtime with ClassNotFoundException, and just adding lagomScaladslPersistenceCassandra to my build.sbt fix it. Well, it makes sense after all. Thanks again
Alden Torres
@aldenml_gitlab
hi @ignasi35, I have another situation when it's helpful to me having the akka version exposed. It's a common library with lagom dependencies and akka dependencies like akka-stream-testkit that it's not pulled by lagom dependencies, but still I want to have perfect sync in akka versions. Can you tell me where is the right place to discuss this? Thanks
Alden Torres
@aldenml_gitlab
looking at recent commits, I decided test again removing this explicit akka-stream-testkit dependency and it works fine now, lagom is pulling it for me, which is good for me, no hacks
Sergey Morgunov
@ihostage
Hi, maintainers! :hand: Can you transfer this issue lagom/lagom-akka-discovery-service-locator#81 to Lagom repository?
I am afraid that the issues an archived repository will be forgotten. :scream: :smile:
Renato Cavalcanti
@renatocaval
I will move it, thanks
Sergey Morgunov
@ihostage
@renatocaval :+1: Thanks!
Renato Cavalcanti
@renatocaval
we can repeat the comments we added on the original one and pretend that we are having the conversation for the first time ;-)
Sergey Morgunov
@ihostage
:joy:
Links will be enough. :wink: Just I did not want to create a new issue and thought you move the original issue to the new repository (like were moved issues to lagom-samples)
Renato Cavalcanti
@renatocaval
yep, I could have done that, but need to unarchive and archive again. So took the short cut of copying the description and linking back
Sergey Morgunov
@ihostage

but need to unarchive and archive again

Oops, I did not know about these details. :man-shrugging:

Michael Liarakos
@mliarakos
I developed a prototype Lagom ScalaJS client and example project on how to use it. I have a longer explanation on lagom/lagom#571. Let me know what you think of the approach.
Elijah Rippeth
@erip
:raised_hands:
Sergey Morgunov
@ihostage

I tried to use scala.Option on structural typing in
com.lightbend.lagom.dev.Servers, but got a error:

[error] java.lang.NoSuchMethodException: com.lightbend.lagom.internal.cassandra.CassandraLauncher.start(java.io.File, java.io.File, boolean, scala.Option, [Ljava.lang.String;, java.lang.ClassLoader)
[error]     at java.lang.Class.getMethod(Class.java:1786)
[error]     at com.lightbend.lagom.dev.Servers$CassandraServer$.reflMethod$Method4(Servers.scala:217)

Want to known why? Because Scala Library loaded by different class loaders from different places (~/.ivy2/cache/org.scala-lang/scala-library/jars/scala-library-2.12.8.jar!/scala/Option.class and ~/.sbt/boot/scala-2.12.4/lib/scala-library.jar!/scala/Option.class) :smile:
I knew about class loaders, but forget that Scala is just library (for JVM in runtime, of course) :smile: and lost hour for remember this :disappointed: My brain almost exploded, because I tried find difference in method signatures, but signatures (stringified) are absolutely equals :joy:

Elijah Rippeth
@erip
I know y'all have been busy, but has anyone had a chance to look at @mliarakos's SJS branch? Perhaps a WIP PR is a good option for a review?
Renato Cavalcanti
@renatocaval
@erip, I had a quick look
my personal take on it is that this would be good as an extension
thus not intergated inside Lagom
would that be possible?
Elijah Rippeth
@erip
I don't think so since it requires changes to the lagom internals.
Though very minimally
I suspect if those changes were made separately it might be possible.
Renato Cavalcanti
@renatocaval
Maybe a DRAFT PR, so we can easily compare the source code
Elijah Rippeth
@erip

:+1: The required changes are outlined here: https://github.com/lagom/lagom/issues/571#issuecomment-508942154

A large number of changes are just SJS compatibility changes of artifacts. The lagom changes are basically breaking components into separate files and adding a few abstractions.

Will talk to @mliarakos in case he isn't on gitter often. :)
Renato Cavalcanti
@renatocaval
one thing to take into account is that in the coming months we will be adding bits of Lagom back into Play
and the whole idea is to reduce Lagom’s code base (it should become a thin layer on top of Play)
this goes on the opposite direction because it increases Lagom, adds a new runtime (javascript) and more things to maintain
that’s why I would prefer it to be a side project
Elijah Rippeth
@erip
Understood. Some of the changes could likely be ported upstream, but don't quote me on that
The abstractions might be useful for Lagom even outside of this context (e.g., not relying so heavily on a wsClient from play)
Sergey Morgunov
@ihostage
Hi, folks! :wave:
What do you think about lagom/lagom-java.g8#60 ?
Tim Moore
@TimMoore
@ihostage I'll have to leave that up to the core development team. Seems like a fine idea IMHO but I'm not the one who will be maintaining it.
@ignasi35 any thoughts?
Sergey Morgunov
@ihostage
@TimMoore The core team is very busy until :disappointed: But you came to light and I caught you on the common channel. :joy:
Tim Moore
@TimMoore
Indeed we all are :)
Sergey Morgunov
@ihostage
:joy:
Tim Moore
@TimMoore
Some people have had summer holidays, too... everything slows down a bit (except of course for support requests somehow)