Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • Oct 19 22:37
    Travis lagom/lagom (master) broken (6081)
  • Oct 19 17:40
  • Oct 19 17:06
    a1kemist opened #2363
  • Oct 19 15:06

    mergify[bot] on master

    Update value to 2.8.1 Merge pull request #2362 from s… (compare)

  • Oct 19 15:06
    mergify[bot] closed #2362
  • Oct 19 14:20
    Travis lagom/lagom#2361 broken (6077)
  • Oct 19 13:41
    scala-steward opened #2362
  • Oct 19 13:41
    scala-steward opened #2361
  • Oct 19 09:12
    Travis lagom/lagom (master) fixed (6075)
  • Oct 19 07:46

    dwijnand on master

    New Akka & Play Adapt to Akka 2.6.0-M8 Mark broken tests as pending to… and 1 more (compare)

  • Oct 19 07:46
    dwijnand closed #2350
  • Oct 19 00:40
    a1kemist edited #2360
  • Oct 19 00:33
    triage-new-issues[bot] labeled #2360
  • Oct 19 00:33
    a1kemist opened #2360
  • Oct 18 23:22
    michael-read commented #2354
  • Oct 18 22:19
    Travis lagom/lagom (master) broken (6074)
  • Oct 18 21:42
  • Oct 18 21:07
    scala-steward opened #2359
  • Oct 18 20:43

    mergify[bot] on master

    #1334 remove SBT_OPTS documenta… Merge pull request #2356 from f… (compare)

  • Oct 18 20:43
    mergify[bot] closed #2356
Michael Liarakos
@mliarakos
I developed a prototype Lagom ScalaJS client and example project on how to use it. I have a longer explanation on lagom/lagom#571. Let me know what you think of the approach.
Elijah Rippeth
@erip
:raised_hands:
Sergey Morgunov
@ihostage

I tried to use scala.Option on structural typing in
com.lightbend.lagom.dev.Servers, but got a error:

[error] java.lang.NoSuchMethodException: com.lightbend.lagom.internal.cassandra.CassandraLauncher.start(java.io.File, java.io.File, boolean, scala.Option, [Ljava.lang.String;, java.lang.ClassLoader)
[error]     at java.lang.Class.getMethod(Class.java:1786)
[error]     at com.lightbend.lagom.dev.Servers$CassandraServer$.reflMethod$Method4(Servers.scala:217)

Want to known why? Because Scala Library loaded by different class loaders from different places (~/.ivy2/cache/org.scala-lang/scala-library/jars/scala-library-2.12.8.jar!/scala/Option.class and ~/.sbt/boot/scala-2.12.4/lib/scala-library.jar!/scala/Option.class) :smile:
I knew about class loaders, but forget that Scala is just library (for JVM in runtime, of course) :smile: and lost hour for remember this :disappointed: My brain almost exploded, because I tried find difference in method signatures, but signatures (stringified) are absolutely equals :joy:

Elijah Rippeth
@erip
I know y'all have been busy, but has anyone had a chance to look at @mliarakos's SJS branch? Perhaps a WIP PR is a good option for a review?
Renato Cavalcanti
@renatocaval
@erip, I had a quick look
my personal take on it is that this would be good as an extension
thus not intergated inside Lagom
would that be possible?
Elijah Rippeth
@erip
I don't think so since it requires changes to the lagom internals.
Though very minimally
I suspect if those changes were made separately it might be possible.
Renato Cavalcanti
@renatocaval
Maybe a DRAFT PR, so we can easily compare the source code
Elijah Rippeth
@erip

:+1: The required changes are outlined here: https://github.com/lagom/lagom/issues/571#issuecomment-508942154

A large number of changes are just SJS compatibility changes of artifacts. The lagom changes are basically breaking components into separate files and adding a few abstractions.

Will talk to @mliarakos in case he isn't on gitter often. :)
Renato Cavalcanti
@renatocaval
one thing to take into account is that in the coming months we will be adding bits of Lagom back into Play
and the whole idea is to reduce Lagom’s code base (it should become a thin layer on top of Play)
this goes on the opposite direction because it increases Lagom, adds a new runtime (javascript) and more things to maintain
that’s why I would prefer it to be a side project
Elijah Rippeth
@erip
Understood. Some of the changes could likely be ported upstream, but don't quote me on that
The abstractions might be useful for Lagom even outside of this context (e.g., not relying so heavily on a wsClient from play)
Sergey Morgunov
@ihostage
Hi, folks! :wave:
What do you think about lagom/lagom-java.g8#60 ?
Tim Moore
@TimMoore
@ihostage I'll have to leave that up to the core development team. Seems like a fine idea IMHO but I'm not the one who will be maintaining it.
@ignasi35 any thoughts?
Sergey Morgunov
@ihostage
@TimMoore The core team is very busy until :disappointed: But you came to light and I caught you on the common channel. :joy:
Tim Moore
@TimMoore
Indeed we all are :)
Sergey Morgunov
@ihostage
:joy:
Tim Moore
@TimMoore
Some people have had summer holidays, too... everything slows down a bit (except of course for support requests somehow)
Sergey Morgunov
@ihostage
I understand :wink:
yakovlevdmv
@yakovlevdmv
Hello,
I'm doing PR lagom/lagom#2251 . I got to the point when I need an outside perspective. Some points are not so obvious. I'd appreciate any response.