Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Nov 14 13:25
  • Nov 04 15:31
    JPritchard9518 opened #316
  • Oct 08 18:30
    rscheuer starred lasso-js/lasso
  • Oct 03 23:23
    mikevel starred lasso-js/lasso
  • Sep 18 14:16
    okmttdhr starred lasso-js/lasso
  • Aug 25 18:32
    emmiep starred lasso-js/lasso
  • Aug 19 18:13

    DylanPiercey on master

    3.4.3 (compare)

  • Aug 19 18:13

    DylanPiercey on v3.4.3

    (compare)

  • Aug 19 18:11

    DylanPiercey on master

    fix: re-enable read/transform c… refactor: html slot building op… (compare)

  • Aug 10 18:29
    dependabot[bot] labeled #315
  • Aug 10 18:29
    dependabot[bot] opened #315
  • Aug 10 18:29

    dependabot[bot] on npm_and_yarn

    Bump path-parse from 1.0.5 to 1… (compare)

  • Jul 31 05:25
    NeroBlackstone starred lasso-js/lasso
  • Jul 29 16:02
    DylanPiercey commented #314
  • Jul 29 16:01
    DylanPiercey closed #314
  • Jul 29 16:01
    DylanPiercey commented #314
  • Jul 28 05:08
    pedramphp edited #314
  • Jul 28 05:08
    pedramphp opened #314
  • Jul 23 13:57
    gurdev-r starred lasso-js/lasso
  • Jun 14 20:12
    speedupmate starred lasso-js/lasso
Daniel Pham
@nguyenpc
Here is the error I got when running my site.
Here is my lasso configuration in app.js
image.png
Thanks for any helps
Patrick Steele-Idem
@patrick-steele-idem
@nguyenpc sorry for the delayed reply, but better late than never. Instead of lasso-jsx you should just use the the lasso-babel-transform to do the JSX transpiling: https://github.com/lasso-js/lasso-babel-transform
Brandon Istenes
@brandones

Hi, I'm having trouble getting conditional remapping to work. In my package.json I have

"browser": {
  "fs": false
}

But when I do require('gcommon') (a local module for shared code that I have linked in) I get

Caused by: Error: Failed to walk dependency [require: ./config]. Dependency chain: [require: /Users/bistenes/Code/project/web/src/components/services-app.marko] → [require: ./map.marko] → [req
uire: /Users/bistenes/Code/project/web/src/components/map.marko] → [require: gcommon] → [require: ./config]. Cause: Error: Failed to walk dependency [require: nconf]. Dependency chain: [require: /
Users/bistenes/Code/project/web/src/components/services-app.marko] → [require: ./map.marko] → [require: /Users/bistenes/Code/project/web/src/components/map.marko] → [require: gcommon] → [require:
 ./config] → [require: nconf]. Cause: Error: Failed to walk dependency [require: ./nconf/common]. Dependency chain:[require: /Users/bistenes/Code/project/web/src/components/services-app.marko] → [
require: ./map.marko] → [require: /Users/bistenes/Code/project/web/src/components/map.marko] → [require: gcommon] → [require: ./config] → [require: nconf] → [require: ./nconf/common]. Cause: Error
: Failed to resolve "fs". Target file does not exist. Started search from directory "/Users/bistenes/Code/project/web/node_modules/gcommon/node_modules/nconf/lib/nconf".
Yoni Medoff
@yomed
@brandones Do you have that package.json as its own file, local to that component directory?
Brandon Istenes
@brandones
Magically couldn't repro. I guess I musta turned it off and turned it on again. (for posterity, yes, the browser configuration was provided in gcommon/package.json. I reckon I just needed to clear caches or something.)
Brandon Istenes
@brandones
Ah, emm, I take that back. It wasn't happening when running my app, but rather when building with marko-starter. I'm getting maybe 100 lines of similar output, it seems to be in some kind of loop.
Most of the error is pasted here
Brandon Istenes
@brandones
The same browser config line exists in web/package.json.
Brandon Istenes
@brandones
Ping?
Brandon Istenes
@brandones
?
Patrick Steele-Idem
@patrick-steele-idem
@brandones IIt looks like you are trying to bundle up a module for the browser that only works on the server and it looks like it's starting from you importing gcommon in src/components/map.marko. The .marko file is getting compiled to .js and being bundled up and sent to the browser, along with all of its dependencies. There's a transitive dependency on the fs module and the file system module only works on the server
@brandones Take a look at the following: https://github.com/defunctzombie/package-browser-field-spec
Ahmet Can Güven
@Acanguven
I am trying to implement offline pages with service workers using markojs. I only want to cache offline.html but its built with marko and lasso. So all the .css, .js files are coming as external fingerprinted files.
Is there a way to make lasso put them inline into same offline.html file?
Ahmet Can Güven
@Acanguven
Fixed the problem by caching the fingerprinted files with regex.
kdevan
@kdevan
what's the best way to share global css variables (sass) with all components?
kdevan
@kdevan
and for lasso-sass plugin, is it expecting style.scss { ... } or style.sass { ... }?
because creating a file like style.scss for a multi file component, then using style.sass { ... } in a single file component, creates two different files. style.scss { ... } works to combine into one file but i'm wondering if that's right or if i'll run into issues later
Yoni Medoff
@yomed
@kdevan on your first question, the less plugin has an import syntax for globals, but the sass plugin might not have it implemented: https://github.com/lasso-js/lasso-less#less-imports
kdevan
@kdevan
@yomed thank you for pointing me in the right direction
Scott Davis
@scttdavs
is there a way to tell lasso to NOT bundle up certain dependencies it finds in files? Let's say a file has require("foo") and we call tell lasso to just skip over that and don't bundle up "foo" with everything else?
Yoni Medoff
@yomed
@scttdavs You can map it, similarly to handling browser-specific deps -- https://github.com/defunctzombie/package-browser-field-spec#ignore-a-module
THAC0
@gunjam
hi
lasso 3.0.0 doesn't seem to work for me, I get a Error: Render async fragment error where all my static assets timed out after 10000ms
works fine in lasso 2, and reading the stack trace the file paths all seem correct, so any idea what's going wrong?
(running node 8.9.1)
THAC0
@gunjam
specifically, it only seems to be assets loaded through the use of the <lasso-resource/> tag
those in my browser.json aren't in the list
Austin Kelleher
@austinkelleher
@gunjam Are you importing the @lasso/marko-taglib taglib?
The Lasso taglib has been removed from the Lasso project in v3
THAC0
@gunjam
yeah I am
previously I was getting an error about a lasso tag not being defined, but I fixed that by installing @lasso/marko-taglib. The problem I have now, as described above, is that the <lasso-resource/> tag is timing out when tried to load the assets
and I have no idea how to fix it :(
thanks for replying though, @austinkelleher
Charles Read
@charlesread
@austinkelleher , should https://www.npmjs.com/package/lasso still be showing v2.11.23? It was showing v3.x yesterday.
Charles Read
@charlesread
(at least I think it was, I could be completely wrong)
Max Milton
@MaxMilton
@charlesread npmjs just shows the latest release not the highest version.
Charles Read
@charlesread
Thanks
Charles Read
@charlesread
Hi folks, I have an issue where I have Lasso bundling resources when I think that it shouldn't. I am using Marko and Lasso, I have a few Marko components, working just fine, each with its own browser.json and dependencies that work just fine and are bundled up and delivered to the browser just fine. The issue is that when I want to preferentially show one of these components, like with the <if()></if> Marko tags, Lasso will still bundle up the resources of a component if the conditions of the <if()></if> evaluate to false, and deliver them to the browser, even though that which is in <if()></if> does not get rendered. Am I doing something wrong? My desire would be to have resources of components be bundled and delivered to the browser if and only if that component is to actually be rendered according to <if()></if>. (cross post from the Marko gitter)
Sandeep Vattapparambil
@SandeepVattapparambil
Hi folks I am getting a Render error. Exception: Error: Async fragment timed out after 10000ms
I am using Marko 4.7.0 and lasso 2.11.1,
the error is thrown from a component
THAC0
@gunjam
that's the error I get, but only with lasso 3.0.0
and the path it spits out in the error is definitely correct, just times out reading the file from disk?
Ian Von Holt
@ianvonholt
@SandeepVattapparambil can you post your component and lasso config?
@charlesread Lasso should still bundle the alternative to the if and else statements, especially if the statement is a browser runtime statement. If you want alternative builds, you need to use Lasso configuration bundles and conditionals to accomplish that.
Ian Von Holt
@ianvonholt
@austinkelleher @patrick-steele-idem @mlrawlings I’ve updated lasso-stylus for v3, and re-worked the tests into the current format y’all have for most of the lasso-js projects.
Austin Kelleher
@austinkelleher
@ianvonholt Awesome! Thanks for doing that. I see your PR. I will get to reviewing it tomorrow morning
Ian Von Holt
@ianvonholt
Cool. Any others that need updating?
Max Milton
@MaxMilton
Anyone got a working config to automatically split out a vendor bundle (put everything from node_modules into a seperate bundle)?