Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Sep 18 14:16
    okmttdhr starred lasso-js/lasso
  • Aug 25 18:32
    emmiep starred lasso-js/lasso
  • Aug 19 18:13

    DylanPiercey on master

    3.4.3 (compare)

  • Aug 19 18:13

    DylanPiercey on v3.4.3

    (compare)

  • Aug 19 18:11

    DylanPiercey on master

    fix: re-enable read/transform c… refactor: html slot building op… (compare)

  • Aug 10 18:29
    dependabot[bot] labeled #315
  • Aug 10 18:29
    dependabot[bot] opened #315
  • Aug 10 18:29

    dependabot[bot] on npm_and_yarn

    Bump path-parse from 1.0.5 to 1… (compare)

  • Jul 31 05:25
    NeroBlackstone starred lasso-js/lasso
  • Jul 29 16:02
    DylanPiercey commented #314
  • Jul 29 16:01
    DylanPiercey closed #314
  • Jul 29 16:01
    DylanPiercey commented #314
  • Jul 28 05:08
    pedramphp edited #314
  • Jul 28 05:08
    pedramphp opened #314
  • Jul 23 13:57
    gurdev-r starred lasso-js/lasso
  • Jun 14 20:12
    speedupmate starred lasso-js/lasso
  • May 31 20:52
    giovannipds starred lasso-js/lasso
  • May 23 04:34
    p-raj starred lasso-js/lasso
  • May 10 21:04
    kimo070 starred lasso-js/lasso
  • May 09 14:00
    dependabot[bot] labeled #313
Ian Von Holt
@ianvonholt
@austinkelleher @patrick-steele-idem @mlrawlings I’ve updated lasso-stylus for v3, and re-worked the tests into the current format y’all have for most of the lasso-js projects.
Austin Kelleher
@austinkelleher
@ianvonholt Awesome! Thanks for doing that. I see your PR. I will get to reviewing it tomorrow morning
Ian Von Holt
@ianvonholt
Cool. Any others that need updating?
Max Milton
@MaxMilton
Anyone got a working config to automatically split out a vendor bundle (put everything from node_modules into a seperate bundle)?
Ian Von Holt
@ianvonholt
@MaxMilton Have you setup the bundle in the Lasso config for the specific vendor scripts you want?
Max Milton
@MaxMilton
@ianvonholt no I haven't, I was just looking for a generic solution. Something equivalent to webpack's webpack.optimize.CommonsChunkPlugin, e.g. https://github.com/vuejs-templates/webpack/blob/develop/template/build/webpack.prod.conf.js#L86,L98
Max Milton
@MaxMilton
A decent starting point would for at least the marko runtime code to be in its own bundle. The marko-starter boilerplate loads a completely different bundle for each route even though there's a lot of shared code.
THAC0
@gunjam
does Lasso now also include <script>$_mod.ready();</script> and bundle some of it's own js ?
started a new marko/lasso project and getting that on all my pages, wasn't there before
THAC0
@gunjam
*now always, not now also
Csaba Kiss
@csakis
I have tried using lasso for my hapi site. After modifying the css and js files for 20 minutes, my static folder is flooded with intermediate css and js files processed by lasso. Is there any clever way, perhaps a lasso option to clean these files up?
Max Milton
@MaxMilton

So I've been playing with lasso transform plugins... for example, a while ago I made a generic PostCSS runner; https://github.com/WeAreGenki/lasso-postcss, plus some others.

I've run into an issue. Lasso runs transforms per component. Or am I mistaken? Is there any way to run a plugin on the final compiled file just before it's output?

Main reasoning being static code analysis on the whole file (e.g. a bundled JS/CSS file), plus doing minification is much more optimal when processing the entire source at once.

Max Milton
@MaxMilton
Even the core minification plugins lasso-minify-js and lasso-minify-css run per component which is a bit strange to me. I havn't had a deep dive into the lasso source yet so forgive my ignorance if there's some reasoning for this. Are you perhaps caching the output of each individual component or something?
Eldar
@Eldar-X
Hi! how can i reconfigure created lasso instance ?
Eldar
@Eldar-X
https://github.com/lasso-js/lasso/blob/master/docs/bundling.md#page-level-bundles in documents it say we have "bundles" property on <lasso-page> component but it's not working :(
Yoni Medoff
@yomed
@Eldar-X I'm not sure if the docs are outdated, but I don't see bundles in the tag attribute definitions https://github.com/lasso-js/lasso-marko-taglib/blob/7a6342733f93e4c82ba072af6e1c1fa685a3e864/marko.json#L3-L48
Eldar
@Eldar-X
@yomed :( yes me too. I think it's great feature or maybe even better if we can define bundles in browser.json
Yoni Medoff
@yomed
FWIW you should be able to set it in the .configure() command (which also takes JSON), like https://github.com/yomed/lasso-configure/blob/bf9f27de6f6a37ed6986289017a6df2168cf1dfd/index.js#L66
Jarvis Prestidge
@JarvisPrestidge
hey guys, quick question - i'm looking to use marko / lasso in an electron app. Any foreseeable gotcha's or expected issues i'd run into? I can't see any examples of anyone trying this before :grimacing:
Jarvis Prestidge
@JarvisPrestidge
Hi guys i'm trying to use lasso-cli with the watch flag (everything work as expected without it) and i'm getting some cache errors:
lasso --main src/pages/home/main.js --inject-into index.html --config lasso-config.json --watch
Config:
{
    "outputDir": "/home/jarvis/Projects/marko-path-router-demo/static",
    "minify": false,
    "bundlingEnabled": false,
    "fingerprintsEnabled": false,
    "plugins": [
        "lasso-marko"
    ],
    "urlPrefix": "%STATIC_PATH%"
}
[lasso-cli] Watching: /home/jarvis/Projects/marko-path-router-demo
[lasso-cli] Ignore rule: node_modules
[lasso-cli] Ignore rule: static
[lasso-cli] Ignore rule: .cache
[lasso-cli] Ignore rule: *.marko.js
[lasso-cli] Ignore rule: /static/
[lasso-cli] Ignore rule: /build/
[lasso-cli] Ignore rule: /index.html

Optimizing page "index"...
/home/jarvis/.nvm/versions/node/v8.9.3/lib/node_modules/lasso-cli/node_modules/lasso-require/src/util/resolve.js:96
        var cache = lassoContext.cache.getSyncCache('resolveRequire');
                                       ^

TypeError: Cannot read property 'getSyncCache' of undefined
    at Object.resolveRequireCached (/home/jarvis/.nvm/versions/node/v8.9.3/lib/node_modules/lasso-cli/node_modules/lasso-require/src/util/resolve.js:96:40)
    at Ctor.init [as doInit] (/home/jarvis/.nvm/versions/node/v8.9.3/lib/node_modules/lasso-cli/node_modules/lasso-require/src/dep-require.js:240:46)
    at Ctor.init (/home/jarvis/.nvm/versions/node/v8.9.3/lib/node_modules/lasso-cli/node_modules/lasso/lib/dependencies/Dependency.js:177:32)
    at walkDependency (/home/jarvis/.nvm/versions/node/v8.9.3/lib/node_modules/lasso-cli/node_modules/lasso/lib/dependency-walker.js:91:20)
    at /home/jarvis/.nvm/versions/node/v8.9.3/lib/node_modules/lasso-cli/node_modules/lasso/lib/dependency-walker.js:40:17
    at series (/home/jarvis/.nvm/versions/node/v8.9.3/lib/node_modules/lasso-cli/node_modules/raptor-async/series.js:40:13)
    at walkDependencies (/home/jarvis/.nvm/versions/node/v8.9.3/lib/node_modules/lasso-cli/node_modules/lasso/lib/dependency-walker.js:50:9)
    at /home/jarvis/.nvm/versions/node/v8.9.3/lib/node_modules/lasso-cli/node_modules/lasso/lib/dependency-walker.js:84:17
    at AsyncValue.<anonymous> (/home/jarvis/.nvm/versions/node/v8.9.3/lib/node_modules/lasso-cli/node_modules/lasso/lib/LassoManifest.js:145:13)
    at AsyncValue.done (/home/jarvis/.nvm/versions/node/v8.9.3/lib/node_modules/lasso-cli/node_modules/raptor-async/AsyncValue.js:200:29)
works as expected without the --watch flag, any clues?
Jarvis Prestidge
@JarvisPrestidge
ooo interesting revelation: removing the --config option and bringing all the options onto the command line with the --production flag makes it all play nicely
i.e. - lasso --main src/pages/home/main.js --inject-into index.html --plugins "lasso-marko" --production --watch
however using the --development flag causes it to fail in the same way as above
i.e. lasso --main src/pages/home/main.js --inject-into index.html --plugins "lasso-marko" --development --watch :no_entry_sign:
@patrick-steele-idem @austinkelleher
Austin Kelleher
@austinkelleher
Hey @JarvisPrestidge I was able to reproduce this issue and put up a PR here: lasso-js/lasso-require#47
We should have that merged and published sometime today. I will also get this updated in Lasso 3.
Austin Kelleher
@austinkelleher
Hey @JarvisPrestidge. I've fixed this issue for both Lasso 2 and Lasso 3. If you re-install lasso-cli you should not see this issue anymore.
Jarvis Prestidge
@JarvisPrestidge
@austinkelleher good to hear and thank you very much :smile: i've also got some interesting behaviour on the marko gitter if you're free to take a look
Jarvis Prestidge
@JarvisPrestidge
Hi guys, is there a lasso plugin / configuration that allows bundling of node require type modules?
Since i've run into a blocker when trying to tie marko & lasso together with electron. I'm getting the following error - "Module not found: fs"
Jarvis Prestidge
@JarvisPrestidge
@austinkelleher :wave:
William Bewzenko
@WilliamBewzenko

Hi Guys!
I am using marko and lasso, I intend to be uploading the resources to s3, I would like to be uploading in runtime, but I am having some initial challenges, first which architecture to choose:

There is a possibility to do as suggested in the gist. What do you guys think about this still works?

Or use the lasso-s3-writer plugin, I would not like to be using it since it is necessary to run in prebuild.

Any personal suggestions? Reading? Implementation documentation?

Eldar
@Eldar-X
@austinkelleher Hi with lasso v3 i have extra file long-long-path-name-to-index.marko.init when render marko template. For example https://github.com/charlieduong94/marko-path-router-demo update lasso to v3 and enable bundling in server.js
Maybe i do something wrong ?
Yoni Medoff
@yomed
@Eldar-X Looks like that might be related to this issue lasso-js/lasso-marko#15
Eldar
@Eldar-X
@yomed yes and it's not good to show our path to app. We need fix for this
Yoni Medoff
@yomed
@Eldar-X You should be able to keep lasso-marko on a version below 2.4.0 for now, but I agree, it seems like a security issue
Renato Marinho
@renatomarinho
This message was deleted
Renato Peterman
@renatopeterman
Hi guys! We're trying to improve our browser-refresh/hot-reload refresh time. We realized that the lasso.handleWatchedFileChanged(path); just invalidates all the caches, so we need to re-run our entire lasso.lassoPage (which in our case is very slow) everytime a js or marko file changes. Is there any way to invalidate only one specific component (the one that changed) and rebuild only that component instead of running the lasso.lassoPage for the whole application? (we have a single page app)
Janakiram Ganesan
@janakg
Hi Everyone, Is there an option in lasso-cli for resolver { builtins: {}} ? Thanks in advance.
Renato Marinho
@renatomarinho
This message was deleted
Ian Von Holt
@ianvonholt
@mlrawlings @austinkelleher @DylanPiercey Hey guys, I see that there have been a lot of updates to LassoJS over the past couple months. Would we be able to get an update to the CHANGELOG to give developers some insight into some of the new features?
Pankaj Singh Bisht
@impsbisht_twitter
Hi, I am getting this error in my terminal The module [lasso] is using deprecated features. I am 6.10.0
Charles Read
@charlesread
Hi all, I’m containerizing Marko+Lasso apps, problem is that my asset bundles aren’t produced until the first request, so load balancing the containers with something like a k8s service is a problem as all of the asset bundles won’t be generated on a container whose actual endpoints havn’t been hit yet but may be the target of a load balancer request for such an asset, can I precompile all assets bundles? I am using the Marko/lasso taglib and have disabled fingerprinting, so that’s cool, now I jut need to generate those assets at deployment and I’ll be solid.
Alex Marion
@alexmarion
Hey all, I'm pretty new to lasso so I'm not sure if this is possible but if I have an app structured as follows:
/a
/b
/c/routes
/c/components
And I want to only lasso/minify/babel the /c directory to /c/static is there a way to exclude routes in /a and /b? The behavior that I've seen is that the routes in both a and b end up generating files in the /c/static directory
Ian Von Holt
@ianvonholt
@charlesread Unfortunately, this has been a problem with Lasso for quite some time: lasso-js/lasso#212
There was some work done on pre-build features, but there isn’t any documentation nor is there any evidence that it actually stops Lasso’s caching issue between build and serving a file.
Brian Sea
@bsea_twitter
I'm using lasso to package multiple JS files using require and I'm getting ReferenceErrors about module not being defined. Is this a known issue?
Oh.. I'm trying to load the bundled JS file from a Web Worker