it's explicit for sure
the other option is to always call UmbracoProperty
but we don't do this because it's entirely feasible that a processor may not even need a property values
for example AppSettingAttribute
calling UmbracoProperty would be a waste of time and processing
which is why we took the stance "if you declare 1, declare them all"
and if you find yourself declaring the same set again and again, wrap them in a multi processor
@BarryFogarty If you use a base class for all your nested content you can decorate that class with [DittoDocTypeFactory]
Using it in any calling classes like
public virtual IEnumerable<NestedComponent> NestedContent { get; set; }Will populate the values without having to declare any other attributes since Ditto will see no attributes and automatically add UmbracoProperty
NestedComponent is my base class there.
I think right now if we see a processors on a class, we use it completely
ie, we assume it will absolutely be able to resolve the value
wondered if we should add some checks to say, let it process it, but if it's not the right value that comes out, run regular processors
Ok so the current logic is.
- Check the property for processor attributes and capture them
- If non found add the default (UmbracoProperty)
- Then check for type based attributes and add
- Then check TypeParams in enumerables
- Then add core types.
As long as the processor ones resolve to your expected type they should overule anything found elsewhere.... Should.
You too!
Guys sorry for the interruption, just following on from yesterday, can I use [DittoDocTypeFactory] on a picker-based property? Basically I'm trying to do a similar thing as I described yesterday, but this time the collection will be derived from an MNTP:
[UmbracoProperty("cards_Items", Order = 1)]
[UmbracoPicker(Order = 2)]
[DittoDocTypeFactory(Order = 3)]
public virtual IEnumerable<ICard> Items { get; set; }
It is installed but removing UmbracoPicker attribute doesnt change things - I have 3 items of type ICard but they are all null. When this executes on the doctype with the nested content property however, I can see the {CardProxy} type in the watch. In both cases though, the GetPropertyValue returns a list of IPublishedContent correctly.
Maybe its not being wired up correctly on my concrete type - anyway off to lunch will do more investitgations after. Cheers
I never install the value converters.
They won't work in that scenario anyway since the value converters return type is IEnumerable<IPublishedContent>
here's the code:
public class XPathAttribute : DittoProcessorAttribute
{
private readonly string[] _currentItemIdentifiers = { ".", "$current" };
private readonly string[] _currentSiteIdentifiers = { "$site" };
private readonly string[] _currentPageIdentifiers = { "$currentPage" };
private string _xPath;
public XPathAttribute(string xPath)
{
_xPath = xPath;
}
public override object ProcessValue()
{
var umbracoContext = UmbracoContext.Current;
foreach (var currentItemIdentifier in _currentItemIdentifiers)
{
if (_xPath.StartsWith(currentItemIdentifier))
_xPath = $"id({Context.Content.Id})" + _xPath.Remove(0, currentItemIdentifier.Length).EnsureStartsWith("/");
}
foreach (var currentPageIdentifier in _currentPageIdentifiers)
{
if (_xPath.StartsWith(currentPageIdentifier))
_xPath = $"id({umbracoContext.PageId})" + _xPath.Remove(0, currentPageIdentifier.Length).EnsureStartsWith("/");
}
foreach (var currentSiteIdentifier in _currentSiteIdentifiers)
{
if (_xPath.StartsWith(currentSiteIdentifier))
_xPath = $"id({Context.Content.Id})/ancestor-or-self::*[@level = 1]" + _xPath.Remove(0, currentSiteIdentifier.Length).EnsureStartsWith("/");
}
if (Context.PropertyDescriptor.PropertyType.IsEnumerableType())
{
var genericTypeDefinition =
Context.PropertyDescriptor.PropertyType.GetGenericArguments().FirstOrDefault();
return umbracoContext.ContentCache.GetByXPath(_xPath).As(genericTypeDefinition);
}
return umbracoContext.ContentCache.GetSingleByXPath(_xPath).As(Context.PropertyDescriptor.PropertyType);
}
}
Still needs some Ditto project tests, as I'm using integration tests to test it my side
QQ - Is there a way to call a core ditto processor from a custom one. I want to create a 'DictionaryFallbackProcessor' which essentially needs to call UmbracoDictionary(key) if the value passed in is null or empty. I'm currently just using UmbracoHelper.GetDictionaryValue(key) but was interest generally whether a pattern like this was possible.
That's essentially what we do with AltUmbracoProperty processor, wrapping the regular UmbracoProperty processor