Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
    Levin Du
    @levin-du
    hello
    Tim Branyen
    @tbranyen
    Hey @leeluolee thanks for making this library. Been wanting something like it for a long time.
    Tim Branyen
    @tbranyen
    I'll help you out with the documentation. Your English is pretty darn good btw
    ZhengHaibo
    @leeluolee
    @tbranyen . Your help was greatly appreciated. I am so sad for my poor english.
    Tim Branyen
    @tbranyen
    @leeluolee what do you think about returning a promise inside enter and leave
    instead of var done = this.async()
    ZhengHaibo
    @leeluolee
    The main reason is【codebase】, Beacuse IE9- is our target browser now, introduceing Promise will need to import a lot of code. And, the feature about asynchronous routing in stateman haven't completely done yet. Currently support is very simple, and far from perfect.
    @tbranyen
    Tim Branyen
    @tbranyen
    Ah I meant something like:
    if (enterReturnValue.then) {
      enterReturnValue.then(function() {
        continuation();
      });
    }
    You don't need Promise's to support them
    Tim Branyen
    @tbranyen
    @leeluolee yo i'd like to contribute english spelling fixes in the codebase, any objection to renaming files, functions, and variables
    James
    @jamesplease
    hi @leeluolee !
    ZhengHaibo
    @leeluolee
    Hi. @jmeas .
    ZhengHaibo
    @leeluolee
    @tbranyen Just do it. Don't consider my feelings :smile:
    James
    @jamesplease
    :wave: @leeluolee
    how are your meetings? :)
    ZhengHaibo
    @leeluolee
    Plan to release v0.2.0 . leeluolee/stateman#17
    Pavel Karoukin
    @hippich
    hi leeluelee
    i am thinking may be .canEnter and .enter should trigger also everytime params change? i.e. when changing from /dashboard/1 to /dashboard/2, state 'dashboards.dashboard' should change to 'dashboards' then re-enter 'dashboards.dashboard' with new id?
    also, i added issue asking if i can go ahead and clean up code or may be wait till you are done with new work you have in a pipeline?
    ZhengHaibo
    @leeluolee
    /dashboard/1 and /dashboard/2 are all 'dashboards.dashboard'. so, 'leave-enter' process doesn't work. I think the issue (leeluolee/stateman#26 ) that you offered maybe a more reasonable choice. It will also trigger when normal navigation ('dashboard.app -> dashboard.dashboard' etc) begin.
    Pavel Karoukin
    @hippich
    well, .update() does not triggers when we are entering state for the first time. so in effect some logic will need to be defined in both .enter and .update to cover cases when you enter state for the first time and when you just change param(s).
    one of the solution would be to trigger .update on initial .enter
    or may be bring in separate method, like ".process" (i don't like this method name in particular, need to think for better one may be :)) which triggers on both enter and update to keep compatibility with existing codebase?
    Pavel Karoukin
    @hippich
    just an update - i continue code clean ups as time allows. almost where i consider it is acceptable, should submit PR to review in couple days i think - https://github.com/hippich/stateman/tree/pk-cleanup
    Pavel Karoukin
    @hippich
    after clean up done, i am going to work on implementing canUpdate in the same way canEnter/canLeave works
    Unbug Lee
    @unbug
    :smile: :clap: