Community-maintained fork of Firefox, focused on privacy, security and freedom.
Hm, I thought I had thrown away everything that wasn't needed – seems like I was wrong ;)
What do you mean by "not reactive"?
That's awesome – you're taking work away from me :D
I'll assume you've already found that yourself, but just in case: at least the privacy-pane-js (but probably some of the others as well) should give you a few examples of enabling/disabling setting several prefs (and if my memory servers me right even setting prefs depending on a "global" choice).
Also: if you're on gitlab, it might make sense to create a repo with the changed/new files to work on, so we could collaborate / avoid doing the same work twice. would that sound like something you'd appreciate? (if so, I'd just open one up, either with my simple attempts as a start or, probably preferable, with your improved work :)
Not reactive meant that the part responsible for checking if a certain about:config setting was selected didn't re-enable or disable the checkbox if you enabled that certain pref in about:config, until you reloaded the page.
I think simplifying the interface to just have a master button which toggles all the relevant settings related to something and section (or maybe a collapsible dropdown if we can manage it) that shows each about:config setting affected would be more ideal. I'll post a screenshot once I figure out how to align this button on the right - for some reason I've tried like 10 things and none seem to work, starting to think there is shadow css operating on main.inc.xhtml
I would've suggested just the changed / new files – the entire ff code would be overkill, I think ;)
that way, one could copy those over an existing ff source to get things building or generate diffs/patches from, while keeping things manageable.
ah, yeah – it's definitely not reactive then, I had intentionally ignored that for the sake of getting things going :D
organizing the settings like this sounds great to me – it would also be more or less exactly what was proposed in the issue that's outlining some ideas on it ^^
git add . to add all files to a repo - is there a shortcut to add only modified/currently tracked files easily?
git add -u does it
magnustesshu
I really didn't change much, I spent a lot of time trying to figure out how what was already there worked.
is
/ Services.prefs.setBoolPref(
// "privacy.override_rfp_for_color_scheme",
// rfpCheck.checked
// );set a preference?
seems to be possible – in privacy.js, that's done with a utility function (setEventListener) that just calls addEventListener.
that snippet could be used to set prefs manually, yep. wasn't needed at that point, though.
there also seem to be a few other helper functions there (not just setBoolPref) to read/write prefs.
plus, privacy.js has those two utility functions:
function setSyncFromPrefListener(aId, aCallback) {
Preferences.addSyncFromPrefListener(document.getElementById(aId), aCallback);
}
function setSyncToPrefListener(aId, aCallback) {
Preferences.addSyncToPrefListener(document.getElementById(aId), aCallback);
}calling Preferences.-methods, which might also help with some of the more complex stuff ^^
Alright. The following doesn't appear to be working, can you proofread to make sure I'm not an idiot and forgetting something obvious?
librewolf.inc.xhtml
<button id="browserContainersSettings"
is="highlightable-button"
class="accessory-button"
data-l10n-id="librewolf-webgl-toggle"
onclick="toggleWebGL();"
/>librewolf.js
function toggleWebGL() {
console.log("TEST");
let toggleOff = getPreference("webgl.disabled", false);
if (toggleOff) {
Services.prefs.setBoolPref("webgl.disabled", false);
Services.prefs.setBoolPref("webgl.enable-webgl2", true);
} else {
Services.prefs.setBoolPref("webgl.disabled", true);
Services.prefs.setBoolPref("webgl.enable-webgl2", false);
}
}Console says something about security policy not allowing it to load a resource, so I'm not sure if the console.log isn't being called at all cause I'm dumb or isn't allowed to run at all
function getPreference(prefname, defaultValue) {
let retval = Preferences.get(prefname);
if (retval === undefined) {
return defaultValue;
}
return retval;
}