These are chat archives for lift/framework

17th
May 2017
Antonio Salazar Cardozo
@Shadowfiend
May 17 00:04
Haha exploded how?
Ari Gold
@arigoldx
May 17 00:12
i’m guessing (hoping) in the usual first-unit-test way
in a general sense, i dunno what to write in that prose quote which begins the test
on the one hand, “A LiftSession should defer functions when asked to” makes some sense
but, as per lift/framework#1844’s comments, another option would be to put the test around the code that calls buildDeferredFunction.
i’d like to grok that bit too :)
Ari Gold
@arigoldx
May 17 00:18
Would that mean a test on each caller of buildDeferredFunction? For example, LAFutureWithSession.withCurrentSession because that calls withSession which is a private method in LAFutureWithSession which itself calls buildDeferredFunction?
yah.. new to writing tests :baby:
Ari Gold
@arigoldx
May 17 00:23
just stream-of-consciousnessing.. i'll put something together this week and push to the PR :muscle:
Ari Gold
@arigoldx
May 17 00:46
just updated that to “A LiftSession should, Defer functions without failing on null requests"
Ari Gold
@arigoldx
May 17 01:09
this stuff’s reaaaaal pretty
   ___,__      _     _   __  _
  |  / \  \   | |   (_)/  _|| |_    Lift Framework
  |  | |  |   | |__ | ||  _||  _|   3.1-SNAPSHOT for Scala 2.12.1
   \__\_\_.   |____||_||_|   \__|
Antonio Salazar Cardozo
@Shadowfiend
May 17 01:53
I usually phrase that something like "LiftSession when building deferred functions should" and then "provide access to request vars when available", "provide access to the session vars", "run the deferred function in the same render version as when it was deferred", "not fail when the underlying container request is null".
Where the last one is the only one strictly necessary in this case.
Ari Gold
@arigoldx
May 17 15:17
hopa! thanks for that.. i’ma hit it again towards the end of the day.
simplicity-wise, i’ll start with that last one :bowtie: