Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
    Hannah Won
    @nowhannahwon

    I also saw some extra formatting for the event listeners (extra parenthesis) that seemed out of place for the style and didn't seem to affect functionality one way or another. Let me know if those were there to correct a bug.

    I didn't touch the formatting for the image drag and drop functions since it looked like things were more inter-connected.

    Charles Gust
    @CharlesGust
    Hi @nowhannahwon I'm back. Can you point me to the extra parens? What line where? Is it on CSS or in the JS?
    Hannah Won
    @nowhannahwon
    In index.js, the event listeners at the bottom were put into a function call and then called (I think that's what was happening). You'll probably see it in the Diff
    Charles Gust
    @CharlesGust
    Do you mean the stuff I put under the IIFE comment?
    Hannah Won
    @nowhannahwon
    Yes.
    Charles Gust
    @CharlesGust
    That's page 142. Perhaps it requires greater explanation if you thought the parens were superfluous. Let me work on that.
    Hannah Won
    @nowhannahwon
    Ok, reading up on it, I see why we might need it if we were loading in multiple scripts onto the same page. I think we avoided clashing variables by using separate files, one for each webpage.
    Put it back in if you feel it'll be helpful. I could take it or leave it.
    Charles Gust
    @CharlesGust
    Thanks for doing them on a separate commit. I backed out the change, and accepted the rest of pull request 23
    Do you think we need a link back to index.html if the user completes the "purchase" on the buy page? Personally, I'd be a little annoyed if after the purchase I couldn't get to the service I bought...
    Charles Gust
    @CharlesGust
    Should we insert the link to [a video of] her talk at about.html?
    (She did say "married...single..is he a weirdo...what's his car like..." which would be great to append to the clever sayings we already have, randomly generated of course)
    Hannah Won
    @nowhannahwon
    I feel that the essentials of the project are done but if you'd like to add those, feel free to do so. I'll review and merge the PRs.
    Lily
    @lilymatcha
    So are we satisfied? Are you guys okay with submitting at this point?
    As for adding the video, I feel like it's kind of related, but just different enough that the viewer won't be thinking "Oh, cool, it's what she said!" but instead "Hmmm, this isn't quite what she said."
    Hannah Won
    @nowhannahwon
    I'm good to submit. Charles, my PR got merged with the IIFE formatting removed. Did you want to re-do?
    Lily
    @lilymatcha
    the hovereffect looks great btw @nowhannahwon !
    also @CharlesGust i see what you meant by the link now and i think it looks good... i was envisioning an embedded video and was initially like ehhhhh but this is good
    Charles Gust
    @CharlesGust
    @cuppajiu Do you want the link to the video taken out?
    Lily
    @lilymatcha
    no no i think it's good
    i'm going to fix the readme just so it's formatted nicely
    then are we cool with submitting?
    Charles Gust
    @CharlesGust
    @nowhannahwon Did the IIFE wrapper get removed? I did a cherry pick to exclude it. I guess if it makes it in I won't bother to change it, but the comment doesn't make a like of sense then
    The only change I was still working on was the linkback from the submit (and some additions to the form to make it look a little more real)
    the linkback on the order form
    Lily
    @lilymatcha
    okay i just updated the readme
    @CharlesGust, are you okay with submitting now? how far along are you with the linkback? if it's proving troublesome, don't worry about it.
    Hannah Won
    @nowhannahwon
    I'm good with submitting!
    Kudos to @cuppajiu for coding the visual layout. It looks great. Thanks to @CharlesGust for really raising the quality of the user experience. Some really nice features there.
    Lily
    @lilymatcha
    Cool. I'll submit it and comment, then. If anyone wants to keep making changes, I think you can resubmit it and it'll be fine. Just detail what you added. But otherwise, great work guys! Like @nowhannahwon said, good features, @CharlesGust , and thanks to @nowhannahwon for figuring out the random response generator!
    CROSS YOUR FINGERS THAT MINDY LOVES IT
    Charles Gust
    @CharlesGust
    uhhh,, I just made a push
    i Just made pull request 24
    Hannah Won
    @nowhannahwon
    K. I think we submit the repo link anyway so any merges to master will be reflected when they grade it
    Charles Gust
    @CharlesGust
    i made the form longer. folks might not like that. I knew beans about how to format the button because we are using images instead of buttons everywhere
    Lily
    @lilymatcha
    k i just merged it
    good job guys see you all tomorrow!
    Charles Gust
    @CharlesGust
    we're good. see you in AM!
    Hannah Won
    @nowhannahwon
    Sweet!! Great job!
    Lily
    @lilymatcha
    is there a reason why you have to be 18 to order?
    wait so when you click buy no
    buy now*
    it just changes the button to an image of our original header
    i don't really care, but just so we all now
    know*
    (it's late...)
    Charles Gust
    @CharlesGust
    um, I needed a button back to index.html that fit the design scheme... I wanted it to have a nice white border at least...
    .. but I couldn't figure out how to innerHTML that. It's a "one-off" button because all the other buttons are completely Photoshop, right?
    Lily
    @lilymatcha
    ohhh i see
    nvm then
    see you tomorrow!