Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Aug 01 2018 17:48
    @jnh5y banned @matrixbot
James Hughes
@jnh5y
did you add Java 17 to the CI?
Jody Garnett
@jodygarnett
No, just tested locally. Not sure if it is available for our CI.
(Java 17 is still RC - it is not released until mid september. So we can wait until then)
James Hughes
@jnh5y
The Eclipse CI actually runs Dockers.... so you can do whatever you can do.
Jody Garnett
@jodygarnett
still for today let's not fuss. It can be something for JTS 1.19.x
Martin Davis
@dr-jts
all sounds good. And yes, this is JTS 1.18.2
James Hughes
@jnh5y
GT and GWC built cleanly. After the GS build finishes up, I'd be totally happy.
I can cut the release and publish artifacts here in an hour or so. Any last minute things before I do that?
Jody Garnett
@jodygarnett
Check the releasing instructions for notes on last moment things. I cannot think of anything beyond that.
Checking RELEASING.md we may be able clarify a bit the "Start an eclipse release process" as the criteria for when we do all that has changed a bit has it not?
James Hughes
@jnh5y
Ah, this is a "bug fix" release. Right? (Asking, not telling)
Jody Garnett
@jodygarnett
Yep
James Hughes
@jnh5y
so yeah, no dependency changes, we've got ECAs for all the contributions, etc, etc
Jody Garnett
@jodygarnett
I only really want to do the full eclipse release process for 1.19.0 / 1.20.0 / etc...
yup (you are correct a lot so just provide confirmations)
James Hughes
@jnh5y
+1
Jody Garnett
@jodygarnett
(+1|yes|yup|yeah|yep|ya)
James Hughes
@jnh5y
Ok, I'm going to start pushing buttons over here for the release
James Hughes
@jnh5y

Alright, I have completed the JTS 1.18.2 release.

Artifacts are on Maven Central: https://repo1.maven.org/maven2/org/locationtech/jts/jts-core/1.18.2/ and GitHub https://github.com/locationtech/jts/releases/tag/jts-1.18.2

The Eclipse documentation is also updated: https://projects.eclipse.org/projects/locationtech.jts
and I've reset the JTSVersion.java and version history
I think at this point, we just need to announce this here (done!), on the dev email list, and on Twitter
Oh! I also have GT/GWC/GS PRs up
@dr-jts congrats on the release! Do you want to email the dev list?
@jodygarnett shout when you tweet something and I'll get CCR_inc to retweet it
Jody Garnett
@jodygarnett
james I do not think you need to reset version history, instead we add an entry for 1.19.0 (coming up)
Thanks for the GT/GWC/GS PRs i will review tomorrow
James Hughes
@jnh5y
I meant that I added an entry for 1.18.3 (which we can change later to 1.19.0!)
Jody Garnett
@jodygarnett
+1
Martin Davis
@dr-jts
ok, I'll send out a note to the list
seems to me this was a bit more than a dot-dot release. Too late now of course, but I think we should be clearer on what is dot and what is dot-dot
Thoughts?
Jody Garnett
@jodygarnett
tentative:
  • major: rewrite, please send funding first. api change breaking compatibility
  • minor: new features, bug fixes. api change maintaining compatibility
  • dot: improvements, bug fixes. api change "minor" such as javadoc clarifications or additve api change
Martin Davis
@dr-jts
thanks, Jody.
I question major: API change breaking compatibility. We do that fairly regularly! And I don't really want to get into JTS 2.x until rewrite time.
Here's my thought:
  • major: rewrite, please send funding first.
  • minor: new features, bug fixes. api change
  • dot: minor improvements, bug fixes
what is the distinction between "API change maintaining compatibility" and "additive API change"?
Jody Garnett
@jodygarnett
I hear where you are coming from; my list was with a slightly relaxed take on compatibility. GeoTools has gradually allowed backports of api changes as long as they are "additive" and do not distrupt existing functionality.
So something like:
  • major: you will need to port your application to use JTS 2.0 interfaces as Geometry is now an interface
  • minor: we changed the api and your client code may have a compile error or new warning to fix
  • dot: we fixed stuff, if we we changed the api your client code will not notice
It looks like JTS 1.18.2 had one class change locations so it could of been a minor release :P
Martin Davis
@dr-jts
that sounds good to me.
The API change in JTS 1.18.2 is somewhat "soft"... a class changed packages, but the old class is still present but deprecated. Would this still be a minor?
Jody Garnett
@jodygarnett
(not saying I agree with the above, but I am trying to be more prgamatic and less purist. It is just how geotools is operating the last decade, so far less trouble then I expected)
Thinking ...
The old class is probably deprecated, so client code would get a new warning but still compile. I agree "soft" ...
So let me edit the above:
  • major: you will need to port your application to use JTS 2.0 interfaces as Geometry is now an interface
  • minor: we changed the api and your client code may have a compile error to fix
  • dot: we fixed stuff, if we we changed the api your client code will compile, but may have a new warning to address
Martin Davis
@dr-jts
getting there....