Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Sep 10 20:39

    did on master

    convert   and & charac… (compare)

  • Sep 04 15:49

    did on master

    use file.filename to get the fi… (compare)

  • Sep 04 15:31

    did on master

    use file.identifier to get the … (compare)

  • Sep 04 15:15

    did on master

    use the last commit of Steam to… (compare)

  • Sep 04 15:08

    did on master

    fix JS vulnerabilities (compare)

  • Sep 04 15:01

    did on master

    fix a Nokogiri vulnerability (compare)

  • Sep 04 14:36

    did on master

    persist assets with multiple do… push the sections content of th… (compare)

  • Sep 04 14:27

    did on master

    remove useless debug statement (compare)

  • Sep 04 14:25

    did on master

    allow to attach the entry files… (compare)

  • Sep 04 09:04

    did on master

    add the parameterize liquid fil… (compare)

  • Sep 02 15:36
    sebastienbeau edited #158
  • Sep 02 15:33
    sebastienbeau opened #158
  • Aug 29 16:59
    proxygear opened #157
  • Aug 29 15:55
    proxygear opened #378
  • Aug 29 14:17
    lmignon edited #1350
  • Aug 29 14:15
    lmignon opened #1350
  • Aug 23 19:25
    manuchap commented #1321
  • Aug 23 19:16
    manuchap commented #1321
  • Aug 23 19:14
    manuchap commented #1321
  • Aug 23 19:13
    manuchap commented #1321
Didier Lafforgue
@did
oh I see
what’s in your Locomotive routes?
Tahir Poduska
@tap87
  # Locomotive Back-office
  mount Locomotive::Engine => '/locomotive', as: 'locomotive' # you can change the value of the path, by default set to "/locomotive"

  # Locomotive API
  mount Locomotive::API.to_app => '/locomotive(/:site_handle)/api'

  # Render site
  mount Locomotive::Steam::Server.to_app => '/', anchor: false
Didier Lafforgue
@did
change the last line with
mount Locomotive::Steam.to_app => '/', anchor: false
Tahir Poduska
@tap87
Ah. That worked. Thanks.
Didier Lafforgue
@did
@tap87 thanks for the documentation! I used to it to create a full guide
Let me know if you see typos or if it’s not easy to understand
Tahir Poduska
@tap87
@did I figured you would do that. I could only submit an edit as a section. This looks great, and is pretty easy to follow. Thank you. I am sure it will help a lot of folks trying to extend steam.
Didier Lafforgue
@did
hmm, I’ll let the guys behind readme.io know about your suggestion.
thanks again!
Alan Collins
@alanc0llins
Hi
Didier Lafforgue
@did
hi @alanc0llins!
Alan Collins
@alanc0llins
how are you?
Didier Lafforgue
@did
I’m good!
Ahmed Helil
@aaeabdo
Hi @did
Today I faced an issue when I enabled the cache for Locomotive V3 To put you more in the context the issue only persists with the migrated sites from V2. If it’s a new one all works fine. Here is the backtrace:-
NoMethodError (undefined method `fullpath' for nil:NilClass):
  /Users/ahmedabdelsatar/.rvm/gems/ruby-2.2.4/bundler/gems/steam-3541600888dd/lib/locomotive/steam/liquid/tags/editable/base.rb:14:in `initialize'
  locomotivecms-liquid (4.0.0) lib/liquid/tag.rb:9:in `new'
  locomotivecms-liquid (4.0.0) lib/liquid/tag.rb:9:in `parse'
  locomotivecms-liquid (4.0.0) lib/liquid/block_body.rb:27:in `parse'
  locomotivecms-liquid (4.0.0) lib/liquid/document.rb:10:in `parse'
  locomotivecms-liquid (4.0.0) lib/liquid/document.rb:5:in `parse'
  locomotivecms-liquid (4.0.0) lib/liquid/template.rb:124:in `parse'
  locomotivecms-liquid (4.0.0) lib/liquid/template.rb:110:in `parse'
  locomotivecms-liquid (4.0.0) lib/liquid/tags/include.rb:75:in `load_cached_partial'
  locomotivecms-liquid (4.0.0) lib/liquid/tags/include.rb:46:in `render'
  /Users/ahmedabdelsatar/.rvm/gems/ruby-2.2.4/bundler/gems/steam-3541600888dd/lib/locomotive/steam/liquid/tags/snippet.rb:20:in `render'
  locomotivecms-liquid (4.0.0) lib/liquid/block_body.rb:105:in `render_token'
  locomotivecms-liquid (4.0.0) lib/liquid/block_body.rb:87:in `block in render'
  locomotivecms-liquid (4.0.0) lib/liquid/block_body.rb:74:in `each'
  locomotivecms-liquid (4.0.0) lib/liquid/block_body.rb:74:in `render'
  locomotivecms-liquid (4.0.0) lib/liquid/block.rb:15:in `render'
  locomotivecms-liquid (4.0.0) lib/liquid/tags/inherited_block.rb:71:in `block in render'
  locomotivecms-liquid (4.0.0) lib/liquid/context.rb:128:in `stack'
  locomotivecms-liquid (4.0.0) lib/liquid/tags/inherited_block.rb:64:in `render'
  /Users/ahmedabdelsatar/.rvm/gems/ruby-2.2.4/bundler/gems/steam-3541600888dd/lib/locomotive/steam/liquid/tags/inherited_block.rb:42:in `render'
  locomotivecms-liquid (4.0.0) lib/liquid/block_body.rb:105:in `render_token'
  locomotivecms-liquid (4.0.0) lib/liquid/block_body.rb:87:in `block in render'
  locomotivecms-liquid (4.0.0) lib/liquid/block_body.rb:74:in `each'
  locomotivecms-liquid (4.0.0) lib/liquid/block_body.rb:74:in `render'
  locomotivecms-liquid (4.0.0) lib/liquid/block.rb:15:in `render'
  locomotivecms-liquid (4.0.0) lib/liquid/tags/inherited_block.rb:71:in `block in render'
  locomotivecms-liquid (4.0.0) lib/liquid/context.rb:128:in `stack'
  locomotivecms-liquid (4.0.0) lib/liquid/tags/inherited_block.rb:64:in `render'
  /Users/ahmedabdelsatar/.rvm/gems/ruby-2.2.4/bundler/gems/steam-3541600888dd/lib/locomotive/steam/liquid/tags/inherited_block.rb:42:in `render'
  locomotivecms-liquid (4.0.0) lib/liquid/block_body.rb:105:in `render_token'
  locomotivecms-liquid (4.0.0) lib/liquid/block_body.rb:87:in `block in render'
  locomotivecms-liquid (4.0.0) lib/liquid/block_body.rb:74:in `each'
  locomotivecms-liquid (4.0.0) lib/liquid/block_body.rb:74:in `render'
  locomotivecms-liquid (4.0.0) lib/liquid/template.rb:215:in `block in render'
  locomotivecms-liquid (4.0.0) lib/liquid/template.rb:269:in `with_profiling'
  locomotivecms-liquid (4.0.0) lib/liquid/template.rb:214:in `render'
  /Users/ahmedabdelsatar/.rvm/gems/ruby-2.2.4/bundler/gems/steam-3541600888dd/lib/locomotive/steam/liquid/template.rb:17:in `render'
  /Users/ahmedabdelsatar/.rvm/gems/ruby-2.2.4/bundler/gems/steam-3541600888dd/lib/locomotive/steam/middlewares/renderer.rb:40:in `parse_and_render_liquid'
  /Users/ahmedabdelsatar/.rvm/gems/ruby-2.2.4/bundler/gems/steam-3541600888dd/lib/locomotive/steam/middlewares/renderer.rb:22:in `render_page'
  /Users/ahmedabdelsatar/.rvm/gems/ruby-2.2.4/bundler/gems/steam-3541600888dd/lib/locomotive/steam/middlewares/renderer.rb:10:in `_call'
  /Users/ahmedabdelsatar/.rvm/gems/ruby-2.2.4/bundler/gems/steam-3541600888dd/lib/locomotive/steam/middlewares/thread_safe.rb:13:in `call'
  /Users/ahmedabdelsatar/.rvm/gems/ruby-2.2.4/bundler/gems/steam-3541600888dd/lib/locomotive/steam/middlewares/thread_safe.rb:23:in `next'
  /Users/ahmedabdels
the rest
/Users/ahmedabdelsatar/.rvm/gems/ruby-2.2.4/bundler/gems/steam-3541600888dd/lib/locomotive/steam/middlewares/thread_safe.rb:18:in `call'
  /Users/ahmedabdelsatar/.rvm/gems/ruby-2.2.4/bundler/gems/steam-3541600888dd/lib/locomotive/steam/middlewares/thread_safe.rb:23:in `next'
  /Users/ahmedabdelsatar/.rvm/gems/ruby-2.2.4/bundler/gems/steam-3541600888dd/lib/locomotive/steam/middlewares/thread_safe.rb:18:in `call'
  /Users/ahmedabdelsatar/.rvm/gems/ruby-2.2.4/bundler/gems/engine-1cd142815ca1/lib/locomotive/steam/middlewares/cache.rb:31:in `fetch_cached_response'
  /Users/ahmedabdelsatar/.rvm/gems/ruby-2.2.4/bundler/gems/engine-1cd142815ca1/lib/locomotive/steam/middlewares/cache.rb:17:in `call'
  /Users/ahmedabdelsatar/.rvm/gems/ruby-2.2.4/bundler/gems/engine-1cd142815ca1/lib/locomotive/steam/middlewares/catch_error.rb:13:in `call'
  /Users/ahmedabdelsatar/.rvm/gems/ruby-2.2.4/bundler/gems/engine-1cd142815ca1/lib/locomotive/steam/middlewares/page_editing.rb:16:in `call'
  /Users/ahmedabdelsatar/.rvm/gems/ruby-2.2.4/bundler/gems/engine-1cd142815ca1/lib/locomotive/steam/middlewares/missing_translations.rb:13:in `block in call'
  /Users/ahmedabdelsatar/.rvm/gems/ruby-2.2.4/bundler/gems/engine-1cd142815ca1/lib/locomotive/steam/middlewares/missing_translations.rb:24:in `find_and_persist_missing_translations'
  /Users/ahmedabdelsatar/.rvm/gems/ruby-2.2.4/bundler/gems/engine-1cd142815ca1/lib/locomotive/steam/middlewares/missing_translations.rb:12:in `call'
  /Users/ahmedabdelsatar/.rvm/gems/ruby-2.2.4/bundler/gems/engine-1cd142815ca1/lib/locomotive/steam/middlewares/wysihtml_css.rb:12:in `call'
  /Users/ahmedabdelsatar/.rvm/gems/ruby-2.2.4/bundler/gems/steam-3541600888dd/lib/locomotive/steam/middlewares/thread_safe.rb:23:in `next'
  /Users/ahmedabdelsatar/.rvm/gems/ruby-2.2.4/bundler/gems/steam-3541600888dd/lib/locomotive/steam/middlewares/thread_safe.rb:18:in `call'
  /Users/ahmedabdelsatar/.rvm/gems/ruby-2.2.4/bundler/gems/steam-3541600888dd/lib/locomotive/steam/middlewares/path.rb:13:in `call'
  /Users/ahmedabdelsatar/.rvm/gems/ruby-2.2.4/bundler/gems/steam-3541600888dd/lib/locomotive/steam/middlewares/thread_safe.rb:23:in `next'
  /Users/ahmedabdelsatar/.rvm/gems/ruby-2.2.4/bundler/gems/steam-3541600888dd/lib/locomotive/steam/middlewares/thread_safe.rb:18:in `call'
  /Users/ahmedabdelsatar/.rvm/gems/ruby-2.2.4/bundler/gems/steam-3541600888dd/lib/locomotive/steam/middlewares/thread_safe.rb:23:in `next'
  /Users/ahmedabdelsatar/.rvm/gems/ruby-2.2.4/bundler/gems/steam-3541600888dd/lib/locomotive/steam/middlewares/thread_safe.rb:18:in `call'
  /Users/ahmedabdelsatar/.rvm/gems/ruby-2.2.4/bundler/gems/steam-3541600888dd/lib/locomotive/steam/middlewares/thread_safe.rb:23:in `next'
  /Users/ahmedabdelsatar/.rvm/gems/ruby-2.2.4/bundler/gems/steam-3541600888dd/lib/locomotive/steam/middlewares/locale.rb:24:in `block in _call'
  i18n (0.7.0) lib/i18n.rb:257:in `with_locale'
  /Users/ahmedabdelsatar/.rvm/gems/ruby-2.2.4/bundler/gems/steam-3541600888dd/lib/locomotive/steam/middlewares/locale.rb:23:in `_call'
  /Users/ahmedabdelsatar/.rvm/gems/ruby-2.2.4/bundler/gems/steam-3541600888dd/lib/locomotive/steam/middlewares/thread_safe.rb:13:in `call'
  /Users/ahmedabdelsatar/.rvm/gems/ruby-2.2.4/bundler/gems/steam-3541600888dd/lib/locomotive/steam/middlewares/thread_safe.rb:23:in `next'
  /Users/ahmedabdelsatar/.rvm/gems/ruby-2.2.4/bundler/gems/steam-3541600888dd/lib/locomotive/steam/middlewares/thread_safe.rb:18:in `call'
  /Users/ahmedabdelsatar/.rvm/gems/ruby-2.2.4/bundler/gems/steam-3541600888dd/lib/locomotive/steam/middlewares/thread_safe.rb:23:in `next'
  /Users/ahmedabdelsatar/.rvm/gems/ruby-2.2.4/bundler/gems/steam-3541600888dd/lib/locomotive/steam/middlewares/timezone.rb:16:in `block in _call'
  activesupport (4.2.6) lib/active_support/core_ext/time/zones.rb:48:in `use_zone'
  /Users/ahmedabdelsatar/.rvm/gems/ruby-2.2.4/bundler/gems/steam-3541600888dd/lib/locomotive/steam/middlewares/timezone.rb:15:in `_call'
  /Users/ahmedabdelsatar/.rvm/gems/ruby-2.2.4/bundler/gems/steam-3541600888dd/lib/locomotive/steam/middlew
Nikolay Bonev
@DonKoko
Hey @aaeabdo. I think you should make an issue on github with this and it will be taken care of when the time is right. Thanks for reporting an issue.
Ahmed Helil
@aaeabdo
hey @DonKoko, I understand that I need to submit an issue for this but I'd rather wait for @did suggestion on this.
Nikolay Bonev
@DonKoko
@aaeabdo well i know he is very busy at the moment, hopefully this is not something blocking your progress too much.
Ahmed Helil
@aaeabdo
to be honest it's blocking as I can't enable rails caching I already spent some time trying to figure our why it's happening but looks like I'm missing something in the chain. The problem is that when it tries to render a snippet the options parameter doesn't contain the page attribute. see here for more info. I hope I'm not disturbing him by asking. I can also submit a pull request with the fix if i reached the solution.
Nikolay Bonev
@DonKoko
I am sure you are not disturbing him, Did loves feedback and suggestions, its just that he might take some time with answering. Anyways, give me 5 mins, maybe i can see something you dont
Ahmed Helil
@aaeabdo
cool
will wait for ur feedback on it
Nikolay Bonev
@DonKoko
yeah i am looking at it at the moment but I am kinda lost
Ahmed Helil
@aaeabdo
well this only happen when u enable the cache with the upgraded DB V2->V3 with some pages. I think it's quite difficult to look on the issue from the code perspective only.
Nikolay Bonev
@DonKoko
yeah, the context is what matters. I do remember, though a few days/weeks ago Did was talking to somebody about caching issues with v3
and as far as i remember they said the issues are fixed
which version of engine , steam are you using?
Ahmed Helil
@aaeabdo
@DonKoko yeah thats true for the gems I use unreleased versions for steam and the engine because some of the issues that I faced was fixed there.
gem 'locomotivecms_steam', git: 'https://github.com/aaeabdo/steam.git', ref: "3541600"
gem 'locomotivecms', git: 'https://github.com/locomotivecms/engine.git', ref: "1cd142815ca19200c5903e3b32618677072fefe0"
Didier Lafforgue
@did
(thanks @DonKoko for your help!)
hi @aaeabdo, what’s the status of your issues?
Ahmed Helil
@aaeabdo
Hi @did, I ended up not enabling the cache for the affected sites. but it'd be awesome if you can guide me through the issue. Thanks in advance :)
Didier Lafforgue
@did
hmmm
I remember also having issues with the cache and I think I fixed them a couple of weeks ago.
Ahmed Helil
@aaeabdo
well, Then I'll try to get the latest code in the master and see if it solves my issue afterwards I'll let you know if the issue still persisted.
Didier Lafforgue
@did
(don’t forget to update Steam as well)
Ahmed Helil
@aaeabdo
yea, that what I'm planning to do. thanks for the guidance.
Didier Lafforgue
@did
you’re welcome!
Frolin
@frolin
This message was deleted
Troy Starwalt
@troystarwalt
I setup a redirect via pages. The redirect failed (I wasn't sure what format the URL should be in). Now, even after commenting out the option for the redirect, the page still attempts the redirect. Any idea how to fully reset the redirect?
superturbo
@superturbo
hello, @did! what do you think about this PR? locomotivecms/steam#65
Nikolay Bonev
@DonKoko
@superturbo i like it. We could implement an simple search with that in a pretty straightforward way
Didier Lafforgue
@did
hi @superturbo!
I answered it on GH
superturbo
@superturbo
Thanks :smile:
Patricio Tapia Ugalde
@elsilentforce
Greetings everyone, I found a little issue trying to list select options after upgrade from v2 to v3. I've commented this issue here: locomotivecms/steam#74
Didier Lafforgue
@did
thanks @elsilentforce!
will look into it today