Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • Oct 14 07:48
    did commented #159
  • Oct 13 23:27

    did on liquid-4

    upgrade to Liquid 4.0.3 (WIP) +… (compare)

  • Oct 11 16:25
    did commented #159
  • Oct 11 16:23
    did assigned #159
  • Oct 11 16:23
    did labeled #159
  • Oct 11 16:22
    did commented #159
  • Oct 11 11:36
    simahawk commented #1351
  • Oct 10 07:52
    dahogenelst opened #159
  • Oct 09 13:53
    lmignon commented #1350
  • Oct 09 10:14
    dotsi opened #1354
  • Sep 30 19:48

    did on master

    introduce a new liquid tag: red… (compare)

  • Sep 26 08:33
    dotsi commented #379
  • Sep 26 08:07
    dotsi commented #379
  • Sep 25 15:26
    dotsi opened #379
  • Sep 24 13:03
    wmulligan87 opened #1353
  • Sep 24 12:57
    wmulligan87 opened #1352
  • Sep 16 14:25
    simahawk synchronize #1351
  • Sep 16 13:49
    simahawk opened #1351
  • Sep 10 20:39

    did on master

    convert   and & charac… (compare)

  • Sep 04 15:49

    did on master

    use file.filename to get the fi… (compare)

daniel
@dahogenelst
i haven't explicitly required steam in my gemfile, neither in my theme or in my locomotive repo
Nikolay Bonev
@DonKoko
hmm okey
and which version of wagon?
daniel
@dahogenelst
my wagon is set on 2.4.1
Nikolay Bonev
@DonKoko
i see so you are not using v4 sections and so on?
daniel
@dahogenelst
nope, i've just upgraded locomotive to 3.4...tried to do it sensible through a staging platform on heroku, but i did'nt see this issue before i deployed the new version to my production loco
locomotivecms gemfile
```
damnit
locomotivecms gemfile
source 'https://rubygems.org'

ruby '2.5.7'

gem 'locomotivecms', '~> 3.4.0'
gem 'carrierwave-aws'
gem 'devise', '~> 4.4.3'
gem 'mongoid', '~> 6.4.0'
gem 'mongo', '~> 2.8.0'

gem 'letsencrypt_http_challenge'
gem 'turbolinks'
gem 'locomotive_liquid_filters',
    git: 'https://github.com/dahogenelst/locomotive_liquid_filters.git',
    require: true,
    ref: '70e66a3'
gem 'jquery-rails'

gem 'puma'
theme gemfile
source 'https://rubygems.org'

gem 'locomotivecms_wagon', '~> 2.4.1'

gem 'guard-livereload', '~> 2.5.2'
gem 'rb-readline'

group :development do
  # Mac OS X
  gem 'rb-fsevent', '~> 0.9.1', require: 'rb-fsevent' if RUBY_PLATFORM.include?('darwin')

  # Unix
  gem 'therubyracer', require: 'v8', platforms: :ruby unless RUBY_PLATFORM.include?('darwin')

  gem 'rb-inotify', '~> 0.9', require: 'rb-inotify' if RUBY_PLATFORM.include?('linux')
  gem 'byebug'
end

group :misc do
  ## for local
  #
  # gem 'locomotive_liquid_filters',
  #     path: "/home/daniel/cc/locomotive_liquid_filters",
  #     require: true

  ## for remote
  #
  gem 'locomotive_liquid_filters',
      :git => 'https://github.com/dahogenelst/locomotive_liquid_filters.git',
      require: true
end
Nikolay Bonev
@DonKoko
okey so the issue doesnt happen on local?
daniel
@dahogenelst
"luckily" the issue is consistent....in my theme (through wagon) in my local dev instance of locomotive, on my staging platform on heroku and finally also on my loco production platform
Nikolay Bonev
@DonKoko
okey, so its everywhere
hmm
daniel
@dahogenelst
yeah, superweird
Nikolay Bonev
@DonKoko
maybe the liquid_filters custom gem is causing the issue?
maybe you can test updating your local to v4 to see if then the filter works
source 'https://rubygems.org'

gem 'locomotivecms_wagon', '~> 3.0.0.rc0'

# gem 'guard-livereload', '~> 2.5.1'

group :development do
  # Mac OS X
  gem 'rb-fsevent', '~> 0.9.1', require: 'rb-fsevent' if RUBY_PLATFORM.include?('darwin')

  # Unix
  gem 'therubyracer', require: 'v8', platforms: :ruby unless RUBY_PLATFORM.include?('darwin')

  gem 'rb-inotify', '~> 0.9', require: 'rb-inotify' if RUBY_PLATFORM.include?('linux')

  # Guard gem for auto refresh during development. Install w/ 'bundle install', initialize w/ 'guard init', Run w/ ' '.
  gem 'guard-livereload', '~> 2.5.1'

  # Windows
  # gem 'wdm', '~> 0.1.1', require: 'wdm' if RUBY_PLATFORM =~ /mswin|mingw/i
end

group :misc do
  # Add your extra gems here
  # gem 'susy', require: 'susy'
  # gem 'bourbon', require: 'bourbon'
end
daniel
@dahogenelst
is it stable enough yet?
do you already have v4 running in production?
Nikolay Bonev
@DonKoko
ooh yes
like 10 sites already
havent had any problems
just in the begining
daniel
@dahogenelst
nice! i'll give it a go tonight..currently at work supposed to do other things :)
Nikolay Bonev
@DonKoko
соундс гоод
sounds good
hopefully i helped at least a bit
daniel
@dahogenelst
yeah mate, thanks for providing a new angle...i was kinda lost
Nikolay Bonev
@DonKoko
no probs
daniel
@dahogenelst
i'll post an update here if it helped in anyway to bump it to v4
Nikolay Bonev
@DonKoko
Anyone has experience with adding security headers to locomotive cms?
daniel
@dahogenelst
Well that was a surprising outcome...it didn't do any good! Still no results! Updated my local loco instance to 4.0.0rc0 and wagon to 3.0.0rc0.
daniel
@dahogenelst
for good measure, i've started a new rails app to setup loco 4.0, without my own liquid gem...must be something db related, I beginning to think i've singled out everything else
Nikolay Bonev
@DonKoko
that is so strange
so the issue happens also on a locally run engine?
daniel
@dahogenelst
yeah, thats where i checked it...deploying to heroku after that felt a bit useless
for a second i thought it might have been caused by the general timezone setting, but that didnt do anything either
daniel
@dahogenelst

Okay, I've finally figured it out. Took my three whole nights but I'll now remember to be careful when updating ruby. Big issue here is that 2.5.7 caused all my problems. If I would've just sticked to the guides and used 2.5.1, then all would be good.

So cautionary advice for everyone trying to bump ruby to the latest minor (that was at least what I thought it would be; thus safe to do) DO NOT update to 2.5.7

Manu
@manuchap
Sry about your sleepless nights, I know the feeling 😅. Thx for the heads-up!
Didier Lafforgue
@did
sorry guys, more explanation here: locomotivecms/steam#159
WIP
Will Mulligan
@wmulligan87
hey guys. I'm having some difficulty with the page editor on v4... on one of my sites, when using a mac (not on a PC, or on a phone...) when I try to edit the page the standard loading graphic comes up and nothing happens - icon showed in the middle of the page and no sections listed on the left... has anyone has a problem like this before?
I'm using the section manager js provided by the wagon scaffolding
I'm unsure if it's related to my individual sites JS, or if it's something to do with the engine. There are no JS errors in my console
(browser console)
Will Mulligan
@wmulligan87
Hey guys, so I think I figured out my above problem, I think it might be something that can be looked at in the engine repo though - The issue was to do with cross-origin requests between http and https versions of the site. Basically even though I have 'redirect to https' set for the site, if the site is accessed via /admin, that redirect doesn't seem to be triggered. When I then went to edit a page, I was looking at http still, and then things starting screwing up.
sorry, I think the default endpoint for admin panel is /locomotive - I changed it to /admin
anyway, tldr; https redirect for a loco site doesn't seem to work when you access via admin panel
the mac vs pc / phone browser agent bit was due to chrome autocomplete providing http address on the mac... so not browser related at all, just diff user
Nikolay Bonev
@DonKoko
@dahogenelst thanks for letting us know man and glad you figured it out, even after all the struggles