These are chat archives for locomotivecms/v3

19th
Aug 2016
Nick Cappadona
@cappadona
Aug 19 2016 19:09
@did Just created locomotivecms/engine#1172
Didier Lafforgue
@did
Aug 19 2016 19:54
thanks @cappadona
Nick Cappadona
@cappadona
Aug 19 2016 20:03
You bet…let me know if you find something you think I can help with
Didier Lafforgue
@did
Aug 19 2016 20:04
the first thing is to create a spec describing the bug
Nick Cappadona
@cappadona
Aug 19 2016 20:04
Sure…I can do that :)
Didier Lafforgue
@did
Aug 19 2016 20:04
great!
but the test is not going to be easy to write
Nick Cappadona
@cappadona
Aug 19 2016 20:06
ha…so maybe I spoke too soon
still willing to give it a shot
and open to any advice, of course
Didier Lafforgue
@did
Aug 19 2016 20:06
I’m thinking about it
Nick Cappadona
@cappadona
Aug 19 2016 20:08
I’ll be here :)
Didier Lafforgue
@did
Aug 19 2016 20:08
I’m not sure if the test has to be written in Engine or Steam
btw, is that a fixed editable element?
Nick Cappadona
@cappadona
Aug 19 2016 20:09
nope…not fixed
Didier Lafforgue
@did
Aug 19 2016 20:09
okay
Nick Cappadona
@cappadona
Aug 19 2016 20:09
yeah, I was wondering about the test location as well
Didier Lafforgue
@did
Aug 19 2016 20:10
could you output the value of the editable_elements drop?
Nick Cappadona
@cappadona
Aug 19 2016 20:10
Yeah, I was printing that as part of my debug
Nick Cappadona
@cappadona
Aug 19 2016 20:11
all of the editable_text(s) were populated as expected
just the editable_file that's always nil
just before, we transform it into a liquid drop
better
Nick Cappadona
@cappadona
Aug 19 2016 20:13
yeah, that first is within the page drop, so page.editable_elements correct?
Didier Lafforgue
@did
Aug 19 2016 20:13
I’d like to see the output of repository.editable_elements_of(@_source)
Nick Cappadona
@cappadona
Aug 19 2016 20:13
gotcha
Didier Lafforgue
@did
Aug 19 2016 20:13
thanks!
Nick Cappadona
@cappadona
Aug 19 2016 20:14
and this does seem familiar…
locomotivecms/steam@9ae8fa4
Didier Lafforgue
@did
Aug 19 2016 20:14
old commit :-)
Nick Cappadona
@cappadona
Aug 19 2016 20:15
Yeah…just wondering whether that fix for localized sites inadvertently introduced the current issue
anyway, I guess we’ll find out
Didier Lafforgue
@did
Aug 19 2016 20:15
it’s a possibility
Nick Cappadona
@cappadona
Aug 19 2016 20:16
I know, tough to say with the info we have at the moment…I plan on working on this next week
don’t be surprised if I have more questions while trying to write the spec ;)
Didier Lafforgue
@did
Aug 19 2016 20:17
no pb!
I’ll be here :-)
Nick Cappadona
@cappadona
Aug 19 2016 20:27
thanks…have a good one. I’ll be in touch
Didier Lafforgue
@did
Aug 19 2016 20:27
you too!