Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • May 28 2015 11:54
    GiriDandu opened #8
  • May 20 2015 15:19
    GiriDandu synchronize #7
  • May 19 2015 20:21
    GiriDandu opened #7
  • May 14 2015 20:58
    maheshkelkar assigned #6
  • May 14 2015 20:58
    maheshkelkar opened #6
  • May 14 2015 17:50

    GiriDandu on master

    Add empty shell classes for MBe… Added travis for build and test… Added travis cache configuratio… and 4 more (compare)

  • May 14 2015 17:50
    GiriDandu closed #5
  • May 14 2015 17:50
    GiriDandu closed #4
  • May 14 2015 16:44
    GiriDandu commented #5
  • May 14 2015 15:40
    maheshkelkar synchronize #5
  • May 13 2015 20:26
    maheshkelkar synchronize #5
  • May 13 2015 20:08
    GiriDandu commented #5
  • May 13 2015 18:07
    maheshkelkar synchronize #5
  • May 13 2015 17:51
    maheshkelkar synchronize #5
  • May 13 2015 17:44
    maheshkelkar synchronize #5
  • May 13 2015 17:41
    maheshkelkar assigned #5
  • May 13 2015 17:41
    maheshkelkar opened #5
  • May 13 2015 17:30

    maheshkelkar on gh-pages

    Added initial docs with directo… Update links in docs, added tra… (compare)

  • May 13 2015 14:30

    GiriDandu on master

    Added initial docs with directo… Update links in docs, added tra… Merge pull request #2 from mahe… (compare)

  • May 13 2015 14:30
    GiriDandu closed #2
maheshkelkar
@maheshkelkar
@rtyler I have added .travis.yml as a part of pull request #5. I logged into travis CI, but I can't enable it.
I can't find repositories' settings page, perhaps I dont have permissions
maheshkelkar
@maheshkelkar
@rtyler looks like travis build is running, but its not coupled with github
R. Tyler Croy
@rtyler
travis properly enabled
maheshkelkar
@maheshkelkar
don't know why you removed that line
you need to set sourceCompatibilty to 1.7
otherwise it thinks you want to take JDK8 code and compile for JDK7
which isn't a thing
GiriDandu
@GiriDandu
@rtyler i suggested we remove that. we have sourceCompatability removed deploydb also
R. Tyler Croy
@rtyler
then that's probably wrong
:D
GiriDandu
@GiriDandu
its my bad
GiriDandu
@GiriDandu
IMO, we should not add sourceCompatability and targetCompatability. Let the default values - ie the JVM in use build the correct version using jdk parameter of travis.yml
R. Tyler Croy
@rtyler
no
we should
because we're building a library
and we need to be able to build it on multiple JVMs, but target source code compat to JDK7
GiriDandu
@GiriDandu
so you are saying we build library with “sourceCompatability = 1.7” and building with different JDK version using travis.yml
R. Tyler Croy
@rtyler
yes
GiriDandu
@GiriDandu
so what if somebody wants to build this library for JDK 1.8, they need to fork and update the build.gradle to change the sourceCompatability to 1.8 ?
R. Tyler Croy
@rtyler
no
JDK8 runs JDK7 code
GiriDandu
@GiriDandu
oh yeah, that right. The opposite is not true
R. Tyler Croy
@rtyler
yep
GiriDandu
@GiriDandu
thx @rtyler. @maheshkelkar, can you add the sourceCompatability and set it 1.7. i messed you up :-(
maheshkelkar
@maheshkelkar
@GiriDandu no problem. I will take care of it. But, I need to resolve other raised issues as well.
maheshkelkar
@maheshkelkar
@rtyler @GiriDandu Take a look https://github.com/jmxtrans/jmxtrans-agent. Something similar metrics-wizard, except its using a thread and polling a set of configured ObjectName
maheshkelkar
@maheshkelkar
from a quick look it seems to me that you can configure objectName as ":", then it will start monitoring all the objectNames
maheshkelkar
@maheshkelkar
ok, I take that back. It looks like it loops thr the objectNames,
(1) but it ONLY offers a capability to search specific attributes;
(2) it does not discover new MBeans
(3) it does not monitor multiple MBeanServer(s)
E.g. it wakes up every 20 seconds, look for the values of configured attributes and print them. That seems expensive, if we have query as follows: "objectName:".", attribute="count" - which suggest that every 20 seconds, search all objectnames with attribute=count and export
maheshkelkar
@maheshkelkar
@rtyler anymore comments on #5?
R. Tyler Croy
@rtyler
I'm dealing with production incidents and don't have time for you guys right now, sorry
maheshkelkar
@maheshkelkar
np
GiriDandu
@GiriDandu
@maheshkelkar let's merge and we will make changes if need be
GiriDandu
@GiriDandu
@rtyler for parsing metrics-wizard configuration, can we use dropwizard-configuration or the library should not have any dropwizard-configuration dependency?
R. Tyler Croy
@rtyler
the problem with pulling dependencies in is that you're adding them to the main process and increasing the chance for classpath conflicts
reading a YAML file with straight Jackson isn't hard
GiriDandu
@GiriDandu
ok, i will stick to that ... no dependencies with dropwizard-configuration
maheshkelkar
@maheshkelkar
:thumbsup
maheshkelkar
@maheshkelkar
@rtyler @GiriDandu question:
is metrics-wizard supposed to notify events such as: register, attrib change, and unregister? Or
is it supposed to report all metrics periodically regardless of a change?
maheshkelkar
@maheshkelkar
ok, I think thats reporter's job; in that discovery does not need to worry about attribute changes
In short: MBeansDiscovery - discovers the MBeanServer(s) and MBean(s) (register & unregister ONLY)
In MetricsBuilder, BasicMetricsContext i.e. simply creates Gauges for MBean attributes, the Gauge's getValue() routine will fetch the value directly from MBean.
That makes MBeansDiscovery very straightforward
GiriDandu
@GiriDandu
@maheshkelkar, as discussed, let's do a review of the work flow on Monday to make sure we cover all the use cases.
maheshkelkar
@maheshkelkar
@rtyler take a look at my comments yesterday about jmxtrans-agent; it somewhat does what we are doing; but not exactly
R. Tyler Croy
@rtyler
it completely lacks any discovery, what do you want me to look at ?
maheshkelkar
@maheshkelkar
Wrote a few thoughts on internal chat