Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
    risk danger olson
    @technoweenie
    yeah
    Matt
    @iMacTia
    this way we could also control the versions of adapters that are supported
    it would actually solve many issues
    risk danger olson
    @technoweenie
    part of the reason for Hurley was so we could keep Faraday super conservative, and use the completely new gem name to really improve things
    Matt
    @iMacTia
    which makes sense to me, I'm just surprised no one could pick it up
    risk danger olson
    @technoweenie
    faraday is pretty stable... i was worried about dealing with user confusion with major changes between Faraday v0.9 and v1.0
    Matt
    @iMacTia
    I think is normal when you have such a major release, it was the same for 0.8 -> 0.9
    reality is that unless you need something particular that was introduced in the latest version
    no-one stops you from blocking the version in your Gemfile
    risk danger olson
    @technoweenie
    Hurley's internals are pretty radically different
    Matt
    @iMacTia
    if you block a project, sooner or later, it will become incompatible with all its dependencies
    it is pretty much what's gradually happing to Faraday
    me and sbleon have been coping in the last months to keep gem compatible
    we already had to drop ruby 1.8.7 (finally, I would add)
    but if people don't see progresses in a project, they just abandon it
    and that would be really sad :(
    so either it is Faraday 1.0 or another Gem
    I don't really mind, but the community needs it and a clear moving plan
    risk danger olson
    @technoweenie
    yeah, i agree. i'm just not the one to make that plan or carry it out :)
    Matt
    @iMacTia
    event if it's not as easy as bundle update faraday :D
    risk danger olson
    @technoweenie
    happy to go over more details about hurley, but i'll leave it up to you and the other current maintainers how you approach things
    Matt
    @iMacTia
    No worries, I understand you have time constraints, we all have in the end in different measures
    Understood
    If you don't mind, I'll have a look at Hurley personally to save you some time
    will try to collect some questions and forward them to you
    risk danger olson
    @technoweenie
    sure, sounds good
    Matt
    @iMacTia
    biggest one right now is: Faraday 1.0 or Harley? (assuming we WILL have incompatibility with the past, no way to escape that)
    I need a clearer picture to figure this out
    but I think you already made up your mind
    and Hurley should be the way
    risk danger olson
    @technoweenie
    (hurley)
    it's definitely possible to do a long term refactor of Faraday... but i thought it'd be better to rip the bandaid off, so to speak
    Matt
    @iMacTia
    ups :D
    risk danger olson
    @technoweenie
    it's very explicit to end users that it's a big change
    also, i dont care about the names that much. a new gem is a chance to get away from my LOST nerd stuff :)
    Matt
    @iMacTia
    ahaha that's not an issue at all
    it's full of strange names out there, we care about other stuff ;)
    like performances, scalability, etc...
    happy to keep hurley, I like it
    ok then, thanks for the chat
    do you know what Mislav thinks about this?
    risk danger olson
    @technoweenie
    His comment here is the last thing I know of: https://github.com/lostisland/faraday/issues/454#issuecomment-174125687
    I'd at least look at hurley's internals... if you don't think it's worth doing, then iterating on Faraday towards 1.0 is probably a better approach
    one big reason for the big change in Hurley is that people get really confused on the order of faraday request/response adapters
    Faraday treats it like an array of code blocks to execute. so you have to add the url param adapters before the http adapter
    Hurley uses callbacks, so it's easy to swap the http adapter without messing with the order of things
    Matt
    @iMacTia
    @technoweenie me and Mislav are having a chat tonight on how we can get to Faraday 1.0, as we both agreed this looks like the easiest and less painful solution
    I know this was not your preferred path, but if you have any advice or thought on the email I sent at the end of last week, we would be happy to discuss about it
    risk danger olson
    @technoweenie
    i'm fine with it
    Matt
    @iMacTia
    @technoweenie @mislav how are you guys doing? I wrote you an email some time ago but never got a reply back :( Would you guys let me know if you received it ?