Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
Caleb Maclennan
@alerque
I'm familiar with that setup and use it too but again it's a lot of tooling to include in the parent repository and changing any part of it involves a lot of round trip trial-and-error with Travis.
Matthieu Coudron
@teto
is there a changelog for the new release ? couldn't find any specific in changelog.md. Also it doesn't appear in https://luarocks.github.io/luarocks/releases/
Caleb Maclennan
@alerque
Thanks @leafo! I set those actions up on simoncozens/cassowary.lua#7 and it appears to work great (At least in my fork, I guess PR's don't work in Actions until it's been started on master?).
Thijs Schreijer
@Tieske
@leafo the install-lua one is giving me a 404 ?
Caleb Maclennan
@alerque
@Tieske If you look at his example you'll see he renamed the action and repo to install-lua-luajit.
I don't happen to think that was a good idea, but it does still exist.
Caleb Maclennan
@alerque
Lets say I want to run luacheck and busted and have different pass/fail behavior for PRs. Does that need to be two separate action workflows or can it be two jobs in the same workflow? I don't understand when one layout would be preferred.
Also @leafo I see you are posting to Lua Locks after build. Have you set this up to handle releases when Github tags are created as well or are you just using it for updating SCM versions?
leaf
@leafo
I didn't rename the action to install-luajit
github marketplace needs 1 action per repo, so there's leafo/install-lua and leafo/install-luarocks
oh
they generated a new url because I changed the title of the action to mention luajit
that's annoying (especially since they don't create redirects)
well, in any case the name used in the workflow won't change
Caleb Maclennan
@alerque
@leafo Thanks again, I just started a new project fluent-lua and it was nice to get going quickly and cleanly with actions.
I'm looking into how to post to Lua Rocks now though, and it looks like even in your lua-twitter project example you are posting the same spec twice for every run, no? Shouldn't that bit be a separate job (depending on the first) so it doesn't repost the spec for every iteration of the matrix?
leaf
@leafo
@alerque yeah, dont use my publish example exactly in lua twitter, it's double deploying. You'll want to probably set something up that does it on pushing a tag
that was just me messing around. I think the only thing missing for deploy from tag is generating a rockspec with the correct version in the name and file
Caleb Maclennan
@alerque
Is there any advantage to publishing the scm rockspec to Lua Rocks on every pushed commit?
mothilv
@Starkyv
Can someone give me a lead on where to start contributing?
Caleb Maclennan
@alerque
Sure, but can you be a little more specific? Do you have Lua code you want to make into a rock? Or just want some Lua project to tinker with? Or something to the luarocks project itself?
Pierre Chapuis
@catwell

Is there any advantage to publishing the scm rockspec to Lua Rocks on every pushed commit?

Not that I know.

daurnimator
@daurnimator
There is not
You should only need to change your scm rock if you add/remove files; or change the URL of your repository
*scm rockspec
Caleb Maclennan
@alerque
Or, presumably, values like the description that live in the spec. Got it, thanks @daurnimator
daurnimator
@daurnimator
alerque: yep
Caleb Maclennan
@alerque
What about a best-practice for release specs? Having the version in the filename just plays really weird with version control. I see a few projects keeping a ./rockspecs directory with one-each rockspec file for each release. Is that the best alternative?
daurnimator
@daurnimator
alerque: how does it play weird?
alerque: when I do my releases I make a "release branch"; commit the release (with updated NEWS file, renamed rockspec, version file in repository filled in); tag that commit; then merge it back into master (where rockspec is still scm one)
Caleb Maclennan
@alerque
First the vast majority of the content is duplicated over and over again in mulpiple files just to change one key (the version). Some projects rename the file on each release, but that makes it hard to track the history, and also it blocks people from installing old versions. Those that don't rename end up with a bunch of clutter, often in the root of the repo, hence why a directory just for accumulating specs seemed like the most sensible thing I've seen.
daurnimator
@daurnimator
alerque: see https://github.com/daurnimator/lua-http/network there is a release commit on feb 13
Caleb Maclennan
@alerque
daurnimator: So when you merge back from the release branch you suppress the renamed and updated rockspec from coming in with the merge?
daurnimator
@daurnimator
alerque: yep
mothilv
@Starkyv
@alerque I'm not sure. Can you please enlighten me with the difference?
And what are the prerequisites to start contributing to Lua? I'm just a beginner right now. So can someone help me out?
Caleb Maclennan
@alerque
Thanks for the merges on luacov-coveralls @moteus. Any ideas about a new Luarocks release? I'd be glad to strip out the hacks I have in place to make it work in favor of just working out of the box ;-)
Pierre Chapuis
@catwell
Caleb Maclennan
@alerque
LuaRocks could use some improvement, but is starting from scratch the way to do it? Has he tried contributing?
leaf
@leafo

The late addition of https to the rocks server was something

https was added years ago :O

what's the deal with lua-cjson and version of lua > 5.1? I'm building 5.2 with default makefile (has -DLUA_COMPAT_ALL) and I still get undefined symbol: lua_objlen
I'm guessing -DLUA_COMPAT_ALL has to be passed when building the module as well. I don't know if luarocks has something for that
leaf
@leafo
trying to run the lua-cjson test suite for all versions of lua with github actions, these tests 🤔 https://leafo.net/shotsnb/2019-09-21_17-53-07.png
leaf
@leafo
there's two separate test suites: one using some homemade lua script, another using some perl(!) thing