Lucky/Lobby

Discussion about Lucky - https://luckyframework.org

Jeremy Woertink

@jwoertink

@sdzyba What happens when you run yarn run webpack --progress --hide-modules --color --config=node_modules/laravel-mix/setup/webpack.config.js manually?

Slava Dzyba

@sdzyba

the same error

Jeremy Woertink

@jwoertink

Do you have npx installed?

npx webpack --progress --hide-modules --color --config=node_modules/laravel-mix/setup/webpack.config.js

can you try that one?

Slava Dzyba

@sdzyba

could you share what's in your node_modules/laravel-mix ?
I mean, do you have webpack.mix there and mine installation is broken or in your case it actually resolves the webpack.mix in the project root

Jeremy Woertink

@jwoertink

[14:55PM] zooo (master)$ ls -la node_modules/laravel-mix
total 24
drwxr-xr-x    9 jeremywoertink  staff    288 Jul  2 14:52 .
drwxr-xr-x  786 jeremywoertink  staff  25152 Jul  2 14:52 ..
-rw-r--r--    1 jeremywoertink  staff   1094 Oct 20  2019 LICENSE
drwxr-xr-x    5 jeremywoertink  staff    160 Jul  2 14:52 icons
drwxr-xr-x   16 jeremywoertink  staff    512 Jul  2 14:52 node_modules
-rw-r--r--    1 jeremywoertink  staff   3452 Oct 20  2019 package.json
-rw-r--r--    1 jeremywoertink  staff   1105 Oct 20  2019 readme.md
drwxr-xr-x    4 jeremywoertink  staff    128 Jul  2 14:52 setup
drwxr-xr-x   20 jeremywoertink  staff    640 Jul  2 14:52 src

Slava Dzyba

@sdzyba

hm
npx webpack --progress --hide-modules --color --config=node_modules/laravel-mix/setup/webpack.config.js
executed just fine

Jeremy Woertink

@jwoertink

weird

[14:57PM] zooo (master)$ node --version
v14.5.0
[14:57PM] zooo (master)$ yarn --version
1.22.4
[14:58PM] zooo (master)$ npm --version
6.14.5
[14:58PM] zooo (master)$ npm --version
6.14.5

Slava Dzyba

@sdzyba

I have node installed from nvm and yarn from homebrew
I have a suspicious that might be the reason

Jeremy Woertink

@jwoertink

oh interesting

The whole node ecosystem is kinda funny sometimes....

Edward Loveall

@edwardloveall

i've had a lot of trouble with yarn + homebrew

Jeremy Woertink

@jwoertink

Well, if npx works, maybe you can swap those out in your package.json?

sorry you ran in to these issues. I know it's a bummer when you want to start up something new and then nothing works

I wonder if we should switch our default to be npm so that's always the same as the node installation

Slava Dzyba

@sdzyba

unfortunately reinstalling yarn as a node package didn't help
so yes seems like switching to npm can do the trick for me

thanks for your help guys

Jeremy Woertink

@jwoertink

https://github.com/luckyframework/lucky_cli/blob/master/src/browser_app_skeleton/package.json#L11-L14

Glad it's at least working!

Stephen Dolan

@stephendolan

Is there any way to persist a flash assignment through a redirect in an action? Trying to show a success/failure flash message, but redirect to my Home::Index and let it figure out what to show based on if a user is present or not.

Benjamin French

@bnjamin

I'm trying to fix the issue with queries that gets mutated instead of cloned, but I'm running into an issue with the compiler

This is what was in src/avram/criteria.cr before

private def add_clause(sql_clause) : T
    sql_clause = build_sql_clause(sql_clause)
    rows.query.where(sql_clause)
    rows
  end

I changed it to this

private def add_clause(sql_clause) : T
    sql_clause = build_sql_clause(sql_clause)
    new_instance = rows.clone
    new_instance.query.where(sql_clause)
    new_instance
end

But the compiler gives me this error:

In src/avram/criteria.cr:177:40

 177 | private def add_clause(sql_clause) : T
                                            ^
Error: method must return BucketQuery but it is returning BucketQuery

:sweat_smile:

Has anyone seen a simular problem? If so how did you solve it?

Benjamin French

@bnjamin

I found the culprit, BucketQuery is defined as private class BucketQuery in one of the spec files.

Jeremy Woertink

@jwoertink

Ah, yeah. In the specs, we define them as private classes so they don't leak in to other areas. Might be able to just make that public though

Benjamin French

@bnjamin

Yeah it now resides in spec/support/bucket_query.cr

Håkan Nylén

@confact

@stephendolan i think that issue was fixed in the last release. @wout should have been fixing it

Wout

@wout

@stephendolan We've added flash.keep to persist flash messages between multiple redirects:

class Things::Index < BrowserAction
  get "/things" do
    # ...

    flash.keep
    redirect to: Somewhere::Show
  end
end

Stephen Dolan

@stephendolan

Ohh, cool! Submitting a PR to the website now to document it

Wout

@wout

Great! :)

Stephen Dolan

@stephendolan

Anyone have experience with https://github.com/ilanusse/praetorian recently? Project is looking a bit untouched, which is fine given the simplicity if it's still working great for folks :smile:

Håkan Nylén

@confact

I use my own one, lucky_can for that :)

Stephen Dolan

@stephendolan

Does that mean I need to go ahead and make lucky_can_can? :wink:

Håkan Nylén

@confact

Haha, not really :D here it is: https://github.com/confact/lucky_can

Stephen Dolan

@stephendolan

Lol yeah, just a joke from what happened in Rails: https://github.com/CanCanCommunity/cancancan

This looks great, thanks @confact !

Jeremy Woertink

@jwoertink

@confact is there something else you want to share with the group? :stuck_out_tongue_winking_eye:

Håkan Nylén

@confact

@jwoertink let's see here... opening my big lucky shard folder

Jeremy Woertink

@jwoertink

lol

I'm not talking about code :stuck_out_tongue:

Håkan Nylén

@confact

Oh.. Yea. Wait ^^

Håkan Nylén

@confact

https://twitter.com/confact/status/1279111216527486976?s=21

@jwoertink there you go, and every one else for that matter :)

Jeremy Woertink

@jwoertink

nice! Looks great! :tada:

Stephen Dolan

@stephendolan

Woohoo, nice @confact! Those shirts are awesome! :tada:

Edward Loveall

@edwardloveall

yah!

Wout

@wout

🥳

Håkan Nylén

@confact

Thanks!

I want to give back to this community too, so when Kindmetrics is out of beta:

I will give everyone here 30% for 6 months or something that is similar to that (not sure which processor I will choose)
Give away kindmetrics shirts to people helping Kindmetrics out.

Where communities thrive

People

Repo info

Activity