Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Oct 18 14:41
    KonH edited #1844
  • Oct 18 14:41
    KonH opened #1844
  • Oct 14 03:52
    nicolasbize edited #1843
  • Oct 14 03:52
    nicolasbize opened #1843
  • Oct 14 03:42
    nicolasbize edited #1842
  • Oct 14 03:37
    nicolasbize opened #1842
  • Oct 13 22:52
    local-minimum commented #1840
  • Oct 13 18:14
    nicolasbize commented #1840
  • Oct 13 08:12
    local-minimum reopened #1766
  • Oct 13 08:12
    local-minimum commented #1766
  • Oct 13 03:52
    nicolasbize opened #1841
  • Oct 13 00:04
    nicolasbize edited #1840
  • Oct 12 23:49
    nicolasbize edited #1840
  • Oct 12 23:48
    nicolasbize edited #1839
  • Oct 12 23:47
    nicolasbize opened #1840
  • Oct 12 18:49
    nicolasbize commented #1838
  • Oct 12 18:24
    nicolasbize synchronize #1839
  • Oct 12 11:19
    suve commented #1638
  • Oct 12 09:47
    nicolasbize opened #1839
  • Oct 11 05:53
    nicolasbize commented #1838
Mike Kasprzak
@mikekasprzak
I did neglect to include some other apache settings, so a fresh pull of the latest with a vagrant destroy vagrant up should do the trick.
ah shoot, I did mess up some more settings...
very close though
Mike Kasprzak
@mikekasprzak
okay, running another pass. There's either a typo in user.conf, or I messed up the file
Mike Kasprzak
@mikekasprzak
okay, fixed the opcache typo
Zak West
@zwrawr

Looks like the theme idea add issue is because the MYSQL mode is strict and there is no default value for parent in sh_theme_idea.

What is the parent of a theme idea meant to be?

same with the score in sh_theme_idea
Mike Kasprzak
@mikekasprzak
parent is 0 by default
(parenting is used during duplicate removal. a parent is assigned when we want it effectively removed)
I'll see about adding some defaults.
Zak West
@zwrawr
yea, thats what i set it too when messing with it
I guess score would have to be -INFINITY since scores can be negitive. Or make it nullable?
Mike Kasprzak
@mikekasprzak
yep, that did the trick
Both defaults are zero
still got 1 error POST 'http://api.ludumdare.org/vx/theme/idea/add/112' with data 'idea=cs1-code%7Bcolor%3Ainherit%3Bbackground%3Ainherit%3Bborder%3Ainherit%3Bpadding%3Ainherit%7D' for user Attiwad
Zak West
@zwrawr
Yea i know how to fix that
The theme suggestion is too long
Mike Kasprzak
@mikekasprzak
ah, data too long for column theme at row 1
Zak West
@zwrawr
$suggestion = (strlen($suggestion) > 63) ? substr($string,0,60).'...' : $suggestion;
Mike Kasprzak
@mikekasprzak
okay, I'll get my database change merged in
Zak West
@zwrawr
in the default model line 397
works to fix it
I can PR the too long theme text fix
Mike Kasprzak
@mikekasprzak
sure
Zak West
@zwrawr
I was expecting updating to scotchbox 3.5 to be much worse. It wasn't that bad in the end
Mike Kasprzak
@mikekasprzak
Yeah, it did help that we were already using PHP 7.0. A lot of Linux setup stuff got cleaned up starting in Ubuntu 16.04. It'll be less work going from 16.04 to 18.04.
And yay, mailhog
this is way nicer
Zak West
@zwrawr
There's still an error in the js console, but thats also on ldjam.com so probably not as issue
401 on /vx/node/what/
Mike Kasprzak
@mikekasprzak
yeah, if I remember /what 401's if you're not logged in
might be something else though.
actually... what is the what?
are we what'ing the current event?
Zak West
@zwrawr
i think so
yea
Mike Kasprzak
@mikekasprzak
okay, so then i think we're what'ing the event to find out what we know about it (as it relates to us). but yeah, because we're not logged in it has nothing to tell us.
so the what should just not happen when not logged in
I bet it's a promise chain that's to blame
yeah, if there's a featured event (which is always), do a what on it
Mike Kasprzak
@mikekasprzak
okay, I think I have a fix for it
nope!
haha
Mike Kasprzak
@mikekasprzak
Well specifically it's the what call above.
The what call succeeds if the cookie is set.
I think fetching the root (followed by the featured event) might actually happen before we load a user.
my fix was to check if a user was loaded... which I think will not be the case.
the 401 error is the error the emitted by the endpoint if not logged in
it's intentional, but looks ugly