by

Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • May 12 23:21

    mikekasprzak on master

    udated date Merge pull request #1900 from m… (compare)

  • May 12 23:21
    mikekasprzak closed #1900
  • May 12 23:21
    mikekasprzak opened #1900
  • May 06 14:23
    mamahnxarya201 commented #589
  • May 06 14:20
    mamahnxarya201 commented #589
  • May 03 05:16
    mikekasprzak labeled #1835
  • May 03 05:15
    mikekasprzak labeled #1844
  • May 03 05:15
    mikekasprzak labeled #1844
  • May 03 05:15
    mikekasprzak edited #1844
  • May 03 05:14
    mikekasprzak commented #1844
  • May 03 05:10
    mikekasprzak labeled #1845
  • May 03 05:09
    mikekasprzak closed #1889
  • May 03 05:09
    mikekasprzak commented #1889
  • May 03 05:04
    mikekasprzak opened #1899
  • May 03 01:13

    mikekasprzak on master

    theoretically this is working Merge remote-tracking branch 'u… Merge pull request #1898 from m… (compare)

  • May 03 01:13
    mikekasprzak closed #1898
  • May 03 01:13
    mikekasprzak opened #1898
  • May 02 21:42
    dashrava closed #1832
  • May 02 21:37
    BrianMacIntosh commented #1832
  • May 02 19:49
    mikekasprzak labeled #1850
Zak West
@zwrawr
yea, thats what i set it too when messing with it
I guess score would have to be -INFINITY since scores can be negitive. Or make it nullable?
Mike Kasprzak
@mikekasprzak
yep, that did the trick
Both defaults are zero
still got 1 error POST 'http://api.ludumdare.org/vx/theme/idea/add/112' with data 'idea=cs1-code%7Bcolor%3Ainherit%3Bbackground%3Ainherit%3Bborder%3Ainherit%3Bpadding%3Ainherit%7D' for user Attiwad
Zak West
@zwrawr
Yea i know how to fix that
The theme suggestion is too long
Mike Kasprzak
@mikekasprzak
ah, data too long for column theme at row 1
Zak West
@zwrawr
$suggestion = (strlen($suggestion) > 63) ? substr($string,0,60).'...' : $suggestion;
Mike Kasprzak
@mikekasprzak
okay, I'll get my database change merged in
Zak West
@zwrawr
in the default model line 397
works to fix it
I can PR the too long theme text fix
Mike Kasprzak
@mikekasprzak
sure
Zak West
@zwrawr
I was expecting updating to scotchbox 3.5 to be much worse. It wasn't that bad in the end
Mike Kasprzak
@mikekasprzak
Yeah, it did help that we were already using PHP 7.0. A lot of Linux setup stuff got cleaned up starting in Ubuntu 16.04. It'll be less work going from 16.04 to 18.04.
And yay, mailhog
this is way nicer
Zak West
@zwrawr
There's still an error in the js console, but thats also on ldjam.com so probably not as issue
401 on /vx/node/what/
Mike Kasprzak
@mikekasprzak
yeah, if I remember /what 401's if you're not logged in
might be something else though.
actually... what is the what?
are we what'ing the current event?
Zak West
@zwrawr
i think so
yea
Mike Kasprzak
@mikekasprzak
okay, so then i think we're what'ing the event to find out what we know about it (as it relates to us). but yeah, because we're not logged in it has nothing to tell us.
so the what should just not happen when not logged in
I bet it's a promise chain that's to blame
yeah, if there's a featured event (which is always), do a what on it
Mike Kasprzak
@mikekasprzak
okay, I think I have a fix for it
nope!
haha
Mike Kasprzak
@mikekasprzak
Well specifically it's the what call above.
The what call succeeds if the cookie is set.
I think fetching the root (followed by the featured event) might actually happen before we load a user.
my fix was to check if a user was loaded... which I think will not be the case.
the 401 error is the error the emitted by the endpoint if not logged in
it's intentional, but looks ugly
Mike Kasprzak
@mikekasprzak
bad design in general. ;)
Trying to save time by loading the root+featured and the user at the same time.
relying on the cookie
Mike Kasprzak
@mikekasprzak
yeah there's not really a nice way to rework this that doesn't turn in to a chain of dependencies
And it's not actually a problem, just confusing to those that don't know the crappy structure
lame fix: changing the error code returned by /what
Mike Kasprzak
@mikekasprzak
ok, incoming lame fix
if you're not logged in, assume you have nothing authored under the node
Mike Kasprzak
@mikekasprzak
hmm. auto-logging out shouldn't be happening in the vm (redis sessions are enabled), but it did just happen, and I got a bunch of errors trying to check notifications.
still working on a repro, but I just saw the oddest logout bug