Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Nov 23 2019 19:46
    TotallyNotHuman commented #589
  • Nov 23 2019 19:45
    TotallyNotHuman commented #589
  • Nov 23 2019 19:44
    TotallyNotHuman commented #589
  • Nov 12 2019 07:37
    Noojuno review_requested #1843
  • Oct 29 2019 21:21

    mikekasprzak on master

    corrected the start date Merge pull request #1849 from m… (compare)

  • Oct 29 2019 21:21
    mikekasprzak closed #1849
  • Oct 29 2019 21:21
    mikekasprzak opened #1849
  • Oct 29 2019 21:19

    mikekasprzak on master

    updated clocks Merge pull request #1848 from m… (compare)

  • Oct 29 2019 21:19
    mikekasprzak closed #1848
  • Oct 29 2019 21:19
    mikekasprzak opened #1848
  • Oct 29 2019 20:38

    mikekasprzak on master

    updated the email blacklist Merge pull request #1847 from m… (compare)

  • Oct 29 2019 20:38
    mikekasprzak closed #1847
  • Oct 29 2019 20:38
    mikekasprzak opened #1847
  • Oct 29 2019 19:32

    mikekasprzak on master

    sidebar Merge pull request #1846 from m… (compare)

  • Oct 29 2019 19:32
    mikekasprzak closed #1846
  • Oct 29 2019 19:32
    mikekasprzak opened #1846
  • Oct 27 2019 20:09
    zr3 commented #1635
  • Oct 27 2019 07:43
    local-minimum commented #1845
  • Oct 26 2019 19:45
    scscgit edited #1845
  • Oct 26 2019 19:44
    scscgit edited #1845
Mike Kasprzak
@mikekasprzak
And yay, mailhog
this is way nicer
Zak West
@zwrawr
There's still an error in the js console, but thats also on ldjam.com so probably not as issue
401 on /vx/node/what/
Mike Kasprzak
@mikekasprzak
yeah, if I remember /what 401's if you're not logged in
might be something else though.
actually... what is the what?
are we what'ing the current event?
Zak West
@zwrawr
i think so
yea
Mike Kasprzak
@mikekasprzak
okay, so then i think we're what'ing the event to find out what we know about it (as it relates to us). but yeah, because we're not logged in it has nothing to tell us.
so the what should just not happen when not logged in
I bet it's a promise chain that's to blame
yeah, if there's a featured event (which is always), do a what on it
Mike Kasprzak
@mikekasprzak
okay, I think I have a fix for it
nope!
haha
Mike Kasprzak
@mikekasprzak
Well specifically it's the what call above.
The what call succeeds if the cookie is set.
I think fetching the root (followed by the featured event) might actually happen before we load a user.
my fix was to check if a user was loaded... which I think will not be the case.
the 401 error is the error the emitted by the endpoint if not logged in
it's intentional, but looks ugly
Mike Kasprzak
@mikekasprzak
bad design in general. ;)
Trying to save time by loading the root+featured and the user at the same time.
relying on the cookie
Mike Kasprzak
@mikekasprzak
yeah there's not really a nice way to rework this that doesn't turn in to a chain of dependencies
And it's not actually a problem, just confusing to those that don't know the crappy structure
lame fix: changing the error code returned by /what
Mike Kasprzak
@mikekasprzak
ok, incoming lame fix
if you're not logged in, assume you have nothing authored under the node
Mike Kasprzak
@mikekasprzak
hmm. auto-logging out shouldn't be happening in the vm (redis sessions are enabled), but it did just happen, and I got a bunch of errors trying to check notifications.
still working on a repro, but I just saw the oddest logout bug
Mike Kasprzak
@mikekasprzak
did not repo
hopefully it's just a fluke
Should the fake games have artwork?
(the ones generated by the simulator?)
Ah, I think I know what's up
Mike Kasprzak
@mikekasprzak
okay, made another apache fix
this should fix images
I think we're back in business again. :)
Zak West
@zwrawr
Did the play and rate times jump from 4 to 6 hours or am I misremembering, It's the same time as results now?
Mike Kasprzak
@mikekasprzak
weird. Refresh fixed it for me
Definitely something wonky with the clock
Zak West
@zwrawr
Refreshing fix it here too, weird
Mike Kasprzak
@mikekasprzak
I'm definitely ready to see that code gutted. ;)
Zak West
@zwrawr
Yea, hardcoded dates must be getting old for you
Mike Kasprzak
@mikekasprzak
;)
Zak West
@zwrawr
I set up travis to use ubuntu16