Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Sep 05 09:25
    local-minimum commented #1746
  • Sep 05 09:21
    local-minimum commented #1746
  • Sep 05 08:28
    joleeee commented #1746
  • Sep 04 17:52
    local-minimum commented #1746
  • Sep 02 23:32

    mikekasprzak on master

    new about-ld popup Merge pull request #1831 from m… (compare)

  • Sep 02 23:32
    mikekasprzak closed #1831
  • Sep 02 23:32
    mikekasprzak opened #1831
  • Sep 02 19:11

    mikekasprzak on master

    when not logged in, or not sign… cleaned up guides sidebar Merge pull request #1830 from m… (compare)

  • Sep 02 19:11
    mikekasprzak closed #1830
  • Sep 02 19:10
    mikekasprzak opened #1830
  • Jul 16 01:35
    Doppp commented #1722
  • Jun 27 18:19
    zwrawr commented #1821
  • Jun 20 20:06
    zwrawr commented #1772
  • Jun 20 20:04
    zwrawr edited #1772
  • Jun 20 17:50
    mikekasprzak commented #1829
  • Jun 20 15:46
    zwrawr closed #1823
  • Jun 20 15:46
    zwrawr commented #1823
  • Jun 20 15:46
    zwrawr closed #1829
  • Jun 20 15:46
    zwrawr commented #1829
  • Jun 20 15:42
    zwrawr labeled #1829
Zak West
@zwrawr
i think so
yea
Mike Kasprzak
@mikekasprzak
okay, so then i think we're what'ing the event to find out what we know about it (as it relates to us). but yeah, because we're not logged in it has nothing to tell us.
so the what should just not happen when not logged in
I bet it's a promise chain that's to blame
yeah, if there's a featured event (which is always), do a what on it
Mike Kasprzak
@mikekasprzak
okay, I think I have a fix for it
nope!
haha
Mike Kasprzak
@mikekasprzak
Well specifically it's the what call above.
The what call succeeds if the cookie is set.
I think fetching the root (followed by the featured event) might actually happen before we load a user.
my fix was to check if a user was loaded... which I think will not be the case.
the 401 error is the error the emitted by the endpoint if not logged in
it's intentional, but looks ugly
Mike Kasprzak
@mikekasprzak
bad design in general. ;)
Trying to save time by loading the root+featured and the user at the same time.
relying on the cookie
Mike Kasprzak
@mikekasprzak
yeah there's not really a nice way to rework this that doesn't turn in to a chain of dependencies
And it's not actually a problem, just confusing to those that don't know the crappy structure
lame fix: changing the error code returned by /what
Mike Kasprzak
@mikekasprzak
ok, incoming lame fix
if you're not logged in, assume you have nothing authored under the node
Mike Kasprzak
@mikekasprzak
hmm. auto-logging out shouldn't be happening in the vm (redis sessions are enabled), but it did just happen, and I got a bunch of errors trying to check notifications.
still working on a repro, but I just saw the oddest logout bug
Mike Kasprzak
@mikekasprzak
did not repo
hopefully it's just a fluke
Should the fake games have artwork?
(the ones generated by the simulator?)
Ah, I think I know what's up
Mike Kasprzak
@mikekasprzak
okay, made another apache fix
this should fix images
I think we're back in business again. :)
Zak West
@zwrawr
Did the play and rate times jump from 4 to 6 hours or am I misremembering, It's the same time as results now?
Mike Kasprzak
@mikekasprzak
weird. Refresh fixed it for me
Definitely something wonky with the clock
Zak West
@zwrawr
Refreshing fix it here too, weird
Mike Kasprzak
@mikekasprzak
I'm definitely ready to see that code gutted. ;)
Zak West
@zwrawr
Yea, hardcoded dates must be getting old for you
Mike Kasprzak
@mikekasprzak
;)
Zak West
@zwrawr
I set up travis to use ubuntu16
Mike Kasprzak
@mikekasprzak
:thumbsup:
Zak West
@zwrawr
I keep getting that clock bug
Mike Kasprzak
@mikekasprzak
same
I'm hoping it goes away in 12 minutes once we go down to 1 clock
Zak West
@zwrawr
did better than last event with % of rated games (where rated > 20 votes), but still pretty average at 62.5%
Mike Kasprzak
@mikekasprzak
yeah
Zak West
@zwrawr
Screenshot from 2019-05-21 21-21-31.png
Mike Kasprzak
@mikekasprzak
Nice graphs. :)