4 replies
Bugs in the about dialog in 1.77.3 (I compiled the latest)
1) It tries to load markdown directly from GitHub. Specifically, the develop branch which was removed (btw it's really confusing to change the default branch every release)
2) The icon is the default Visual studio one and not mR
I just checked. It's not hard coded to develop, but wherever this is being set, it evaluates to develop which is wrong. Is there updated documentation on the new branching strategy?
private void llCredits_LinkClicked(object sender, LinkLabelLinkClickedEventArgs e)
{
OpenUrl("https://raw.githubusercontent.com/mRemoteNG/mRemoteNG/v" + Assembly.GetExecutingAssembly().GetName().Version.ToString().Substring(0, Assembly.GetExecutingAssembly().GetName().Version.ToString().Length - 2) + "-" + Settings.Default.CurrentUpdateChannelType + "/CREDITS.md");
Close();
}
I was looking at mRemoteNG/mRemoteNG#2128 when I discovered two settings configuration scenarios that can brick the app.
If "reconnect to previously opened sessions on startup" and "always show panel selections dialog" are both set True, then on startup when the app tries to reconnect it will present the panel selection form, which cannot be interacted-with because the startup-splash-logo is still present.
If "Informations" Popups are checked, then when one such popup is displayed, dismissing it will cause a panel focus event, which triggers another popup, which then will cause the same thing to happen when it is dismissed.
Bugs in the about dialog in 1.77.3 (I compiled the latest)
thanks :)
1) It tries to load markdown directly from GitHub. Specifically, the develop branch which was removed (btw it's really confusing to change the default branch every release)
it was like that as its will change from version to version so need to be sure it will stay unchanged for released version because develop branch will not stay forever its always moving forward.
2) The icon is the default Visual studio one and
will check that, as for now still some merging is happening between 1.77.2-dev and 1.77.3-dev something perhaps was escape from my eye
active - default - develop branch is 1.77.3 -dev - all new functionality goes into it.
sub active - develop (for migration period) is 1.77.2-dev - to merge with 1.77.3 with fixes of current bugs
pre-release is 1.77.2-preview, and release 1.77.2-release
Logic as follows: we do coding once we got enough changes we clone 1.y.x-dev branch to 1.y.x-preview, rename branch to 1.y.x+1-dev so we can continue working on new changes. All bug fixes will go to 1.y.x-preview, and if no big complains about bug we clone it to 1.y.x-release branch, after couple of month if we don't get any report about bugs - 1.y.x-preview branch will be deleted, if still any bug will be found it should be addressed in new version. -release branch will be staled for memories :)
i usually like when master/main matches the stable release, so if there's an emergency fix needed (and the dev branch features are not ready yet), you can branch off master/main, make the release hotfix and then re-release... Then merge that into the develop branch and then when dev is ready, it merges to master/main and gets released again. And use tags to specify versions
But please use whatever workflow makes sense for you
I was testing this feature that was just added and I cannot get it to work. Trying it on Win Server 2019, with the protocol version set to RDC9 and Fit To Panel and Autommatic Resize set to yes mRemoteNG/mRemoteNG@37fc611
It always reconnects and usually fails reconnecting