Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Dec 27 2018 18:31
    d3lm commented #838
  • Dec 27 2018 09:08
    Jefiozie commented #838
  • Dec 12 2018 12:51
    d3lm commented #838
  • Dec 12 2018 07:27
    Jefiozie commented #838
  • Dec 04 2018 08:13
    d3lm commented #838
  • Dec 03 2018 18:24
    Jefiozie commented #838
  • Aug 28 2018 17:52
    amyhartz synchronize #843
  • Aug 28 2018 00:17
    amyhartz opened #843
  • Aug 27 2018 21:05
    PascalPrecht commented #432
  • Aug 27 2018 21:03
    amyhartz commented #432
  • Aug 26 2018 21:34
    PascalPrecht commented #432
  • Aug 26 2018 17:09
    amyhartz commented #432
  • Aug 09 2018 13:50

    PascalPrecht on master

    feat(client):added has output iā€¦ (compare)

  • Aug 09 2018 13:50
    PascalPrecht closed #842
  • Aug 09 2018 13:50
    PascalPrecht closed #811
  • Aug 09 2018 12:25
    Jefiozie commented #842
  • Aug 09 2018 12:08
    PascalPrecht commented #842
  • Aug 09 2018 12:06
    Jefiozie synchronize #842
  • Aug 09 2018 12:06
    Jefiozie commented #842
  • Aug 09 2018 12:06
    Jefiozie commented #842
Jeffrey Bosch
@Jefiozie
Don't know what @PascalPrecht thinks about it?
Dominic E.
@d3lm
Haha yea that GIF is fast :D No idea why
Pascal Precht
@PascalPrecht
That realtime indicator is ace!!
Love it
Dominic E.
@d3lm
Here is another GIF
Let's see if that works better
indicator.gif
There you can see the indicator
Pascal Precht
@PascalPrecht
Yea really nice
Jeffrey Bosch
@Jefiozie
Nice!!
Pascal Precht
@PascalPrecht
I wonder if we can have something like that for the console output as well
Dominic E.
@d3lm
image.png
And this is what you'll see while the outputs are loaded
Just a simple message + that indicator
This is much more snappy and direct than showing a loading spinner and then the table
Pascal Precht
@PascalPrecht
What if there's no outputs in the first place?
Dominic E.
@d3lm
Yep, we can easily do that for the console too
Well if there are no output files it's still listening for them in realtime
No?
Jeffrey Bosch
@Jefiozie
Really like it @d3lm
Pascal Precht
@PascalPrecht
Not if the execution isn't actually running
Dominic E.
@d3lm
I mean we could extend the behavior a little and check if the execution is finished, if that's the case and it has no outputs then we don't have to listen for outputs
Pascal Precht
@PascalPrecht
Like the way it is now: If there's no executions, ML tells you "No executions"
Dominic E.
@d3lm
Indeed
Pascal Precht
@PascalPrecht
*no outputs it is
Dominic E.
@d3lm
Yea I need to account for that.
Good point
Pascal Precht
@PascalPrecht
Okay cool. I'd like to not introduce a regression on that
Dominic E.
@d3lm
Yep, but then the realtime only makes sense if the execution is running
If not, then we can check for output files
Pascal Precht
@PascalPrecht
Most of our labs right now don't have any outputs. Also, when no execution is selected in the first place, we also no there's no outputs to show.
Dominic E.
@d3lm
I ll implement that on top of my commit
Pascal Precht
@PascalPrecht
Really nice.
Dominic E.
@d3lm
@Jefiozie Can you add me as a collaborator to your fork?
So that I can push into your feature branch on your fork?
Jeffrey Bosch
@Jefiozie
Yeah sure give me a sec.
Did you get my invite?
Dominic E.
@d3lm
Let's see
Yep got it
Let's see
Jeffrey Bosch
@Jefiozie
Great! Let me know if I need to do something. Otherwise I will have a look at a other issue I can pickup
Dominic E.
@d3lm
Yep!
Dominic E.
@d3lm
Hey @Jefiozie, I have created another WIP PR machinelabs/machinelabs#838
You can look at my last two commits which implement the loading story
It distinguishes between 3 different states - loading, realtime fetching and no outputs
Jeffrey Bosch
@Jefiozie
Great! I will have a look at it to see the changes you made.
Jeffrey Bosch
@Jefiozie
Do you expect something from me at this point? Are you want me just to have a look? šŸ˜ƒ
Pascal Precht
@PascalPrecht
Feel free to review the PR and leave comments as needed.
I'll have a look at it as well.
Jeffrey Bosch
@Jefiozie
okay I will do that :)