Thanks for all the help. Will post here if I see any issue while development
Nice to hear that!
Question about Machinomy + ERC20 tokens: will
0x8ad5c3cd38676d630b060a09baa40b0a3cb0b4b5 always be the contract address when using ERC20 tokens, or does that depend on the specific token you're using or the sender and receiver address? (I'm looking at https://github.com/machinomy/machinomy/blob/master/examples/machinomyERC20.ts)
Also, is there an easy way to make sure the normal (non-ERC20) token is deployed to the network from a node script (rather than using the
truffle:migrate from the command line)? Something like what the ERC20 example does here: https://github.com/machinomy/machinomy/blob/master/examples/machinomyERC20.ts#L36-L37?
@emschwartz Re: https://github.com/machinomy/machinomy/blob/master/examples/machinomyERC20.ts#L34 it is an address of the token contract, like 0xd0d6d6c5fe4a677d343cc433536bb717bae167dd for https://etherscan.io/token/AdToken
and one currency used in that channel
@emschwartz Channel != Contract.
... and what are they? ;)
So just to check I'm understanding this right, the
contractAddress in this line: https://github.com/machinomy/machinomy/blob/master/index.ts#L27 is the ERC20 token contract, correct? (I mistakenly thought it was the Machinomy contract to use before) And if it's undefined that means it's using Ether?
@emschwartz That is correct.
any ballpark estimate on when you think it'll be ready?
What is the purpose of having this hardcoded? https://github.com/machinomy/machinomy/blob/d489213a60016a34f659ac98924b6173ff400660/lib/sender.ts#L208
buy() seems to always call it: https://github.com/machinomy/machinomy/blob/d489213a60016a34f659ac98924b6173ff400660/index.ts#L136
... although, I just noticed that it throws it away
yarn link && yarn build
yarn link v1.3.2
warning There's already a module called "machinomy" registered.
Done in 0.12s.
yarn run v1.3.2
$ tsc -p tsconfig.json
node_modules/tsutils/typeguard/node.d.ts(75,73): error TS2694: Namespace 'ts' has no exported member 'JsxClosingFragment'.
node_modules/tsutils/typeguard/node.d.ts(78,67): error TS2694: Namespace 'ts' has no exported member 'JsxFragment'.
node_modules/tsutils/typeguard/node.d.ts(79,66): error TS2694: Namespace 'ts' has no exported member 'JsxFragment'.
node_modules/tsutils/typeguard/node.d.ts(81,73): error TS2694: Namespace 'ts' has no exported member 'JsxOpeningFragment'.
node_modules/tsutils/util/util.d.ts(80,65): error TS2694: Namespace 'ts' has no exported member 'HasJSDoc'.
error Command failed with exit code 2.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
I had a machinomy installed previously from npm
uninstalled it, still get the same error
unfortunately no experience with yarn
I think there's only one contract for everyone but you need each buyer to fund a payment channel with their own money (using an on-ledger transaction) to set it up. One way to address the cost issue is by having multi-hop payments so that each buyer only needs a payment channel with one intermediary but can still pay any seller
Not as complicated as you'd think, but I'm biased cause that's what I work on (https://interledger.org) :wink:
We're on what feels like it might be the final version of the core protocol and now we're focused on doing it with real money and integrating with the major cryptocurrencies. I've been working on an Ethereum plugin for Interledger using Machinomy https://github.com/emschwartz/ilp-plugin-ethereum-paychan. Once that is done we'll be able to plug it into the main implementation of an Interledger connector. You'll then be able to open a payment channel to a connector in Ether or an ERC20 token that it accepts and it'll pay out to anyone else in Bitcoin, XRP, whatever they want as long as there is some chain of connectors from your asset to the receiver's. (If anyone is interested in helping out with this, I'd love to find more collaborators to work on this plugin)