Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • May 20 2019 03:49

    stelcheck on 1.6.2

    (compare)

  • May 20 2019 03:49

    stelcheck on master

    Release 1.6.2 (compare)

  • May 20 2019 03:47

    stelcheck on master

    Use Consul locks to ensure expi… Use MageError when a Consul wri… Ignore line length linting for … and 1 more (compare)

  • May 20 2019 03:47
    stelcheck closed #280
  • May 20 2019 03:14
    Evertras synchronize #280
  • May 20 2019 03:08
    Evertras synchronize #280
  • May 20 2019 02:55
    stelcheck synchronize #235
  • May 20 2019 02:47
    Evertras opened #280
  • May 20 2019 00:51

    stelcheck on 1.6.1

    (compare)

  • May 20 2019 00:51

    stelcheck on master

    Release 1.6.1 (compare)

  • May 17 2019 10:11

    stelcheck on master

    Make services use a generated I… Remove hostname from consul key Merge pull request #278 from Ev… (compare)

  • May 17 2019 10:11
    stelcheck closed #278
  • May 17 2019 09:43
    Evertras synchronize #278
  • May 17 2019 09:41
    Evertras synchronize #278
  • May 17 2019 09:40

    stelcheck on master

    Update handlebars to fix vulner… Merge pull request #279 from Ev… (compare)

  • May 17 2019 09:40
    stelcheck closed #279
  • May 17 2019 09:29
    Evertras opened #279
  • May 17 2019 09:13
    Evertras opened #278
  • Apr 08 2019 08:58

    stelcheck on master

    allow node 9 Merge branch 'master' of ssh://… added prevent migrate and 1 more (compare)

  • Apr 08 2019 08:58
    stelcheck closed #277
Ron Korving
@ronkorving
possibly, would first need to know what error 2 means in this context
(in any case, I made an issue)
Marc Trudel
@stelcheck
In the comments you should be able to find a link to the C file
where error codes are defined
Ron Korving
@ronkorving
yeah maybe... wouldn't make a lot of sense though.. my bucket does get created
Marc Trudel
@stelcheck
ah... actually
Ron Korving
@ronkorving
so the connection is there
Could it be an auth error somehow?
Ron Korving
@ronkorving
also wouldn't make much sense
the bucket gets created :)
on an auth failure, that would be quite something ;)
Marc Trudel
@stelcheck
@ronkorving
```> c.errors
{ success: 0,
authContinue: 1,
authError: 2,
it does look like an auth error though
what could happen is that it may give you an auth error if the bucket is not yet created entirely?
waitForSet does (re?)open the bucket itself to do the check
so that it would be ignored - it should be safe enough to ignore, given that we know our auth credentials are valid at this point
Seems to be pointing in that direction
Marc Trudel
@stelcheck
@ronkorving mage/mage#168 (untested)
You'll want to try that out on your project to see if it fixes the issue
Ron Korving
@ronkorving
Thanks for the input, I'll give that a shot a little later
Ron Korving
@ronkorving
@stelcheck so on Windows, we had this issue... I can't replicate it on my mac
(mind you, CB runs in a docker container)
false alarm, I have it on Mac too
Ron Korving
@ronkorving
see PR, can confirm it works
Ron Korving
@ronkorving
in any case, I've merged your PR @stelcheck
Ron Korving
@ronkorving
for the record, MAGE 1.3.0 as released yesterday, solves the issue above :)
Marc Trudel
@stelcheck
New MAGE 1.4.1 released! Now project creation is done with
npx mage create my-gameproject [--typescript]
Feedback welcome!
Ron Korving
@ronkorving
@stelcheck re. this mage-console issue: https://github.com/mage/mage-console/blob/master/index.js#L281
that was fixed in Node 8.9.4: https://nodejs.org/en/blog/release/v8.9.4/
Marc Trudel
@stelcheck
@ronkorving its something that had appeared to be on-and-off broken historically :)
Ron Korving
@ronkorving
now it has a unit test :)
Marc Trudel
@stelcheck
Good
Marc Trudel
@stelcheck
Hopefully that'll be the end of it
Ron Korving
@ronkorving
yeah
Marc Trudel
@stelcheck
This said the comment is a bit misplaced
https://github.com/mage/mage-console/blob/master/index.js#L291 is the line that will eventually go away
the function itself is necessary
Ron Korving
@ronkorving
right :)
in fact, going by the issue thread, it seems that process.on('SIGWINCH', () => {}); should do the trick too
Marc Trudel
@stelcheck
sure, but thats not very explicit
calling the function manually will mean the call will be called twice, but at least we can see that it will call it at least once