Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • 09:55

    weirddan455 on master

    [AFR] Implemented Armory Veteran [AFR] Implemented Compelled Duel [AFR] Implemented Deadly Dispute and 1 more (compare)

  • 08:54
    weirddan455 commented #7808
  • 08:40
    weirddan455 commented #7808
  • 08:31
    weirddan455 commented #7808
  • 08:18
    weirddan455 commented #7808
  • 07:23
    Lexion27 opened #7985
  • 02:55
    theelk801 commented #7808
  • 01:47
    theelk801 commented #7808
  • 01:47
    theelk801 edited #7808
  • 01:47

    theelk801 on master

    [AFR] updated spoiler and repri… [AFR] Implemented Magic Missile [AFR] Implemented Acecerak the … and 7 more (compare)

  • 01:43

    weirddan455 on master

    [AFR] Implemented Split the Par… [AFR] Implemented Arborea Pegas… (compare)

  • 01:43
    theelk801 commented #7808
  • 01:41
    theelk801 commented #7808
  • 01:23
    weirddan455 commented #7808
  • 00:53
    theelk801 commented #7981
  • 00:28
    theelk801 commented #7981
  • 00:13
    JayDi85 commented #7981
  • 00:08
    theelk801 commented #7808
  • 00:08
    theelk801 edited #7808
  • 00:07

    theelk801 on master

    [AFR] updated spoiler [AFR] Implemented Steadfast Pal… [AFR] Implemented Greataxe and 2 more (compare)

Evan Kranzler
@theelk801
but also I just wait until the set is done to do text fixes now since I can do it all in one go
htrajan
@htrajan
Oof lots of PR comments haha. Thanks @theelk801 and @JayDi85 for your patience with me and for showing me the ropes. :smile:
htrajan
@htrajan
Thanks @JayDi85 for fixing my Baleful Mastery implementation. Seems like a pretty complex interaction which I didn’t realize when volunteering to do it.. 😅
htrajan
@htrajan
@JayDi85 @theelk801 I put up my PR attempt for Elite Spellbinder. I can allow opponent to cast from exile but not at increased cost. Please take over the card and feel free to use my branch code if it's helpful. I hope to have a PR for Selfless Glyphweaver up tomorrow.
Evan Kranzler
@theelk801
oh hell yeah they're doing errata on the cards from KHC that care about which player moves cards from zone to zone
ingmargoudt
@ingmargoudt
Working on a branch currently to remove quite some explicit nullchecks
htrajan
@htrajan
@JayDi85 @theelk801 Both of my last 2 PRs are up: Efreet Flamepainter and Selfless Glyphweaver. Thanks for taking on Elite Spellbinder @theelk801.
Evan Kranzler
@theelk801
oh I didn't even see the flamepainter one
ingmargoudt
@ingmargoudt
Pushed PR
7757
Anyone reviews besides JayDi85?
Evan Kranzler
@theelk801
I can check it out
ingmargoudt
@ingmargoudt
Thanks. Assigned
Evan Kranzler
@theelk801
definitely not gonna be able to look too hard at it right now though
ingmargoudt
@ingmargoudt
Sure :)
ingmargoudt
@ingmargoudt
Damn I am so messing up my branch commits after I merged back in master to fix merge conflicts
dsenginr
@dsenginr
I'm trying to compile and run for the first time--just forked and cloned the repository this morning. the 'clean install' compiles fine, but when I 'Run Server' I get this error: "package mage.game.result.ResultProtos does not exist". Anyone have any ideas what I'm doing wrong? The only thing I did after cloning the repository was to work on 2 cards, I didn't touch the result.ResultProtos...
Here is my only commit to my fork: dsenginr/mage@8d1b914
Evan Kranzler
@theelk801
you can still open the PR if you want even though you're having trouble running it
htrajan
@htrajan
@dsenginr I had that issue too; some things you can try (in increasing level of annoyance): 1. right click pom.xml > Maven > Update Project 2. File > Invalidate Caches > Invalidate and restart 3. nuke and re-clone the repo. Unfortunately for me, I believe I had to do #3 in the end but you might have luck with 1 or 2 first.
dsenginr
@dsenginr
@htrajan Thanks for the suggestions! I'll give this a try
@theelk801 I'll see if htrajan's suggestion works and then open the PR if I can do any testing.
htrajan
@htrajan
@JayDi85 eta on the STX release? Is it just waiting on release notes?
Oleg Agafonov
@JayDi85

@JayDi85 eta on the STX release? Is it just waiting on release notes?

@htrajan new release in next 1-2 days

@dsenginr missing ResultProtos -- you must full build first to auto-generate classes. So run mvn install command in the root of the project. After that you can build project by IDE and run any code or test.
ingmargoudt
@ingmargoudt
@JayDi85 could you look at my PR or did you already approve?
Oleg Agafonov
@JayDi85
@ingmargoudt yes, I'll look at it today (need to check "move" usage in some cards). PR and code are fine -- just need to check usage to find potential bugs with empty cards. If it critical then it can be merged as is.
ingmargoudt
@ingmargoudt
appreciate it!
Yes its a complex one due to some cards using it wrong, leading to false positives
Such as Mox Diamond
I do not know Mox Diamond now fails, but it is due to my PR.
*why
Evan Kranzler
@theelk801
anybody have any idea why goblin welder prevents death triggers? I'm not too familiar with the zone change handler
ingmargoudt
@ingmargoudt
@JayDi85 could you take a look at my PR please? :g
:)
htrajan
@htrajan

@htrajan new release in next 1-2 days

@JayDi85 any update on the release?

Evan Kranzler
@theelk801
anybody know why the builds have been failing? I'm not too knowledgeable about maven and pom files and stuff
Oleg Agafonov
@JayDi85
jboss repository website was offline and maven stopped, now it works again.
Evan Kranzler
@theelk801
travis-ci.org is no longer available, should we switch to travis-ci.com or something else?
Zach H
@ZeldaZach
Move to GitHub actions or Circle CI
abandon Travis
Evan Kranzler
@theelk801
I've heard similar sentiment elsewhere
are either of those free?
Evan Kranzler
@theelk801
looks like github actions would be pretty simple and easy to set up
Zach H
@ZeldaZach
Yeah we switched to GHA
it’s fine enough
Evan Kranzler
@theelk801
looks like jaydi got it working on travis-ci.com
I do think we should maybe still switch to gh actions though
Oleg Agafonov
@JayDi85
Yes, I migrated to travis-com, so it need some time to check builds, credits consumption and etc (is it good or bad for xmage). I agree that github actions can be good alternative and can be added later too.
Evan Kranzler
@theelk801
it looks super easy to set up, especially given that we don't do anything super complicated
Evan Kranzler
@theelk801
somebody please help I have no idea why one test is failing in #7899 it's the only thing holding the PR back
ingmargoudt
@ingmargoudt
Hi :) recently I started my own repo for mtg rules enforcing, using a test driven approach and the comp rules. First task was to fix blood moon ofc. Its private for now but if you want to take a look, let me know.