magefree/mage

Magic Another Game Engine

Evan Kranzler

@theelk801

please feel free to help on the commander cards

they're uh... difficult

Zach H

@ZeldaZach

How are y’all dealing with turn order changes

Evan Kranzler

@theelk801

we're not!

or at least I'm not

or at least I'm not yet

I'm thinking it might join the ranks of cards like Mind Bend where we just don't implement it

we'll see if it ends up on modo

Zach H

@ZeldaZach

I’m looking into it on my side for trice

Oleg Agafonov

@JayDi85

lol, WTF: Exile Aeon Engine: Reverse the game’s turn order. (For example, if play had proceeded clockwise around the table, it now goes counterclockwise.)

Oleg Agafonov

@JayDi85

I'll try to implement change turn order effect

Alexander Luyten

@imgifty

Hello guys! I setup xmage on my ide. Are there any easy bugs/issues I could start helping with?

Oleg Agafonov

@JayDi85

@imgifty you can:

Find old missing card and implement it (if it easy and already exists -- search code by same card texts):
https://github.com/magefree/mage/labels/tracking%20set
If you can run tests then search private void checkWrongAbilitiesText(Card card, JsonCard ref) { and run verify test for latest C19 commander cards to check texts. You will see wrong/missing abilities (maybe some texts have typo, wrong coded or just missing). Same for other sets too.
You can look at sonar's code report for bugs or fixes: https://sonarcloud.io/dashboard?id=JayDi85_mage

Oleg Agafonov

@JayDi85

Or just look at https://github.com/magefree/mage/issues take some issues and test it to confirm or fix. Some bugs can be easy to fix (as example: wrong type/damage, missing optional choose or nothing happened).

4 - Some cards needs extra info about battlefield state like "make damage equals to creatures controlled". You can add that info to card text as special hints: search code for examples: .addHint(

Alexander Luyten

@imgifty

yes! I started on implementing Commander 19 cards. I'm having some issues running my client though. I get NullPointerExceptions trying to load the CardPluginImpl. Also I had to add Javafx Dependencies to the Maven xml file. Is that correct?

Alexander Luyten

@imgifty

this is the ouput, when I try to run the client: https://hastebin.com/odufonozos.coffeescript

Oleg Agafonov

@JayDi85

You oracle's java 8 to run

Don't try to implement commander 2019 -- @theelk801 already implemented it. There are only very difficult cards (not for novice). The older set -- the easiest missing card to implement.

Oleg Agafonov

@JayDi85

You can use any java 8 versions.

You don't need to add any libs to maven files - it's already works fine and imports by intellij idea.

Alexander Luyten

@imgifty

okay, I got it to work! Which sets are you talking about? I can start with those cards as well!

Oleg Agafonov

@JayDi85

Use that issue search to find out missing cards: https://github.com/magefree/mage/labels/tracking%20set

EikePeace

@EikePeace

A quick question: A friend and I were thinking of setting up a private xMage server, but we're not sure about the OS we should use.

Would you recommend Windows or does it work on Linux as well?

Oleg Agafonov

@JayDi85

@EikePeace you can use any system for server. Wiki have instructions for local server setup too: https://github.com/magefree/mage/wiki#running-local-server

You can run it on your computer, connect to it from same computer and connect to it from friend's.

EikePeace

@EikePeace

Okay, the server is running now, we are working on opening the ports

But, there are no cards on there

Should I just delete the db foder and make a clean install?

EikePeace

@EikePeace

Okay, it doesn't create a card database for clean install

Any ideas why?

Oleg Agafonov

@JayDi85

db creates on startup on missing db... You must delete db folder from mage-server folder, not from mage-client (it's a different).

EikePeace

@EikePeace

It still creates an empty one :/

Oleg Agafonov

@JayDi85

mage-server/db folder is empty? Show your server logs here (delete mage-server/mageserver.log , start server and copy logs here or to https://pastebin.com/ )

EikePeace

@EikePeace

the server is not empty, it doesn't have any cards in the database

THe decks on a testing server are empty for example

Oleg Agafonov

@JayDi85

What you mean by "empty decks"? Server shows missing card error on game start? Or what?

EikePeace

@EikePeace

No, the decks are literally empty

Not even lands exist

The databases are just empty

It is as if no cards would have been ever created

And the test games all end in a draw

Oleg Agafonov

@JayDi85

Show me server's logs file

ingmargoudt

@ingmargoudt

Could anyone check my fix for Jeskai's Infiltrator ?

there was an endless loop that causes a server crash (I think an out of memory or a stackoverflow exception)

ingmargoudt

@ingmargoudt

but I am not sure this fix is that easy..

ingmargoudt

@ingmargoudt

also, I am interested in this:

  @Deprecated
    void discard(int amount, Ability source, Game game);

    Card discardOne(boolean random, Ability source, Game game);

    Cards discard(int amount, boolean random, Ability source, Game game);

    boolean discard(Card card, Ability source, Game game);

The top method is deprecated and internally calls the 3rd method. The 4th method discards a particular card. So since the top method is deprecated , should we remove it and replace all instances with discard(int amount, boolean random, Ability source, Game game); ? And what about discardOne(random...) ?

Oleg Agafonov

@JayDi85

If void discard( uses by few cards then you can remove it, but if it uses in many cards then save it (there are many simplified methods with less params to call for more easy devs).

Where communities thrive

People

Repo info

Activity