But yeah, I also updated now, thx :)
Sorry for spamming all my problems in here
It cannot resolve the symbol
It tries to import from com.fasterxml.jackson.annotations.JsonIgnoreProperties;
But when I try to type it myself, .annotations isn't a thing that is recognized
It didn't get added automatically somehow
Thanks :)
Food for thought, a while ago I removed the game.getGameState.getwatcher() method and added it to the Game class. Reasoning because a) it is a violation of the Law of Demeter and b) cards and players should not have direct access to the gamestate. I can look at other Objects in the GameImpl class that have similar behaviour
I have 2 weeks off now so I can spend some time again :)
Another thing I could do is to remove the SubTypeList. It basically became a simple ArrayList now. The transitive API is not used anymore
Or make more tests
they're uh... difficult
or at least I'm not
or at least I'm not yet
I'm thinking it might join the ranks of cards like Mind Bend where we just don't implement it
we'll see if it ends up on modo
Find old missing card and implement it (if it easy and already exists -- search code by same card texts):
https://github.com/magefree/mage/labels/tracking%20setIf you can run tests then search
private void checkWrongAbilitiesText(Card card, JsonCard ref) {and run verify test for latest C19 commander cards to check texts. You will see wrong/missing abilities (maybe some texts have typo, wrong coded or just missing). Same for other sets too.You can look at sonar's code report for bugs or fixes: https://sonarcloud.io/dashboard?id=JayDi85_mage
Or just look at https://github.com/magefree/mage/issues take some issues and test it to confirm or fix. Some bugs can be easy to fix (as example: wrong type/damage, missing optional choose or nothing happened).
4 - Some cards needs extra info about battlefield state like "make damage equals to creatures controlled". You can add that info to card text as special hints: search code for examples:
.addHint(
Don't try to implement commander 2019 -- @theelk801 already implemented it. There are only very difficult cards (not for novice). The older set -- the easiest missing card to implement.
You can use any java 8 versions.
You don't need to add any libs to maven files - it's already works fine and imports by intellij idea.
Use that issue search to find out missing cards: https://github.com/magefree/mage/labels/tracking%20set
Would you recommend Windows or does it work on Linux as well?
@EikePeace you can use any system for server. Wiki have instructions for local server setup too: https://github.com/magefree/mage/wiki#running-local-server