Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • 07:59
    maxxa416 opened #5996
  • 05:32
    JayDi85 commented #5915
  • 05:22
    JayDi85 edited #5915
  • 05:21
    JayDi85 closed #5952
  • 05:21
    JayDi85 commented #5952
  • 05:10
    JayDi85 commented #5995
  • 05:10
    JayDi85 commented #5995
  • 05:09
    JayDi85 commented #5995
  • 04:44
    JayDi85 commented #5995
  • 04:42
    JayDi85 commented on 6cc2472
  • 04:41

    JayDi85 on master

    * UI: improved choose target am… (compare)

  • 04:21
    jmharmon opened #5995
  • 04:05
    JayDi85 commented on eafb4eb
  • 03:48

    JayDi85 on master

    Added max targets limit support… * UI: improved choose target am… (compare)

  • Sep 23 14:00

    theelk801 on master

    fixed Fires of Invention allowi… (compare)

  • Sep 23 08:11
    archalypse commented #5961
  • Sep 23 01:26

    theelk801 on master

    cleaned up the TargetAmount cla… fixed Torbran, Thane of Red Fel… fixed Heraldic Banner pumping a… and 1 more (compare)

  • Sep 23 01:08
    imendi7 commented #5961
  • Sep 23 00:07
    archalypse commented #5961
  • Sep 22 23:12

    theelk801 on master

    fixed Joust causing your creatu… (compare)

EikePeace
@EikePeace
The Import Statement is still red
It tries to import from com.fasterxml.jackson.annotations.JsonIgnoreProperties;
But when I try to type it myself, .annotations isn't a thing that is recognized
Oleg Agafonov
@JayDi85
Well... That's strange. Then try clean install: create new folder, unzip git sources and import/rebuild as maven project.
Oleg Agafonov
@JayDi85
It's will be red until you add that lib to project structure in mage-verify (maven adds it automaticly on maven->re-import).
shot_190812_183802.png
EikePeace
@EikePeace
Now it works
It didn't get added automatically somehow
Thanks :)
ingmargoudt
@ingmargoudt
Food for thought, a while ago I removed the game.getGameState.getwatcher() method and added it to the Game class. Reasoning because a) it is a violation of the Law of Demeter and b) cards and players should not have direct access to the gamestate. I can look at other Objects in the GameImpl class that have similar behaviour
I have 2 weeks off now so I can spend some time again :)
Another thing I could do is to remove the SubTypeList. It basically became a simple ArrayList now. The transitive API is not used anymore
Or make more tests
Evan Kranzler
@theelk801
please feel free to help on the commander cards
they're uh... difficult
Zach H
@ZeldaZach
How are y’all dealing with turn order changes
Evan Kranzler
@theelk801
we're not!
or at least I'm not
or at least I'm not yet
I'm thinking it might join the ranks of cards like Mind Bend where we just don't implement it
we'll see if it ends up on modo
Zach H
@ZeldaZach
I’m looking into it on my side for trice
Oleg Agafonov
@JayDi85
lol, WTF: Exile Aeon Engine: Reverse the game’s turn order. (For example, if play had proceeded clockwise around the table, it now goes counterclockwise.)
Oleg Agafonov
@JayDi85
I'll try to implement change turn order effect
Alexander Luyten
@imgifty
Hello guys! I setup xmage on my ide. Are there any easy bugs/issues I could start helping with?
Oleg Agafonov
@JayDi85
@imgifty you can:
  1. Find old missing card and implement it (if it easy and already exists -- search code by same card texts):
    https://github.com/magefree/mage/labels/tracking%20set

  2. If you can run tests then search private void checkWrongAbilitiesText(Card card, JsonCard ref) { and run verify test for latest C19 commander cards to check texts. You will see wrong/missing abilities (maybe some texts have typo, wrong coded or just missing). Same for other sets too.

  3. You can look at sonar's code report for bugs or fixes: https://sonarcloud.io/dashboard?id=JayDi85_mage

Oleg Agafonov
@JayDi85
Or just look at https://github.com/magefree/mage/issues take some issues and test it to confirm or fix. Some bugs can be easy to fix (as example: wrong type/damage, missing optional choose or nothing happened).
4 - Some cards needs extra info about battlefield state like "make damage equals to creatures controlled". You can add that info to card text as special hints: search code for examples: .addHint(
Alexander Luyten
@imgifty
yes! I started on implementing Commander 19 cards. I'm having some issues running my client though. I get NullPointerExceptions trying to load the CardPluginImpl. Also I had to add Javafx Dependencies to the Maven xml file. Is that correct?
Alexander Luyten
@imgifty
this is the ouput, when I try to run the client: https://hastebin.com/odufonozos.coffeescript
Oleg Agafonov
@JayDi85
You oracle's java 8 to run
Don't try to implement commander 2019 -- @theelk801 already implemented it. There are only very difficult cards (not for novice). The older set -- the easiest missing card to implement.
shot_190818_172504.png
Oleg Agafonov
@JayDi85
shot_190818_172649.png
You can use any java 8 versions.
You don't need to add any libs to maven files - it's already works fine and imports by intellij idea.
Alexander Luyten
@imgifty
okay, I got it to work! Which sets are you talking about? I can start with those cards as well!
Oleg Agafonov
@JayDi85
Use that issue search to find out missing cards: https://github.com/magefree/mage/labels/tracking%20set
EikePeace
@EikePeace
A quick question: A friend and I were thinking of setting up a private xMage server, but we're not sure about the OS we should use.
Would you recommend Windows or does it work on Linux as well?
Oleg Agafonov
@JayDi85
@EikePeace you can use any system for server. Wiki have instructions for local server setup too: https://github.com/magefree/mage/wiki#running-local-server
You can run it on your computer, connect to it from same computer and connect to it from friend's.
EikePeace
@EikePeace

Okay, the server is running now, we are working on opening the ports

But, there are no cards on there

Should I just delete the db foder and make a clean install?
EikePeace
@EikePeace

Okay, it doesn't create a card database for clean install

Any ideas why?

Oleg Agafonov
@JayDi85
db creates on startup on missing db... You must delete db folder from mage-server folder, not from mage-client (it's a different).
EikePeace
@EikePeace
It still creates an empty one :/
Oleg Agafonov
@JayDi85
mage-server/db folder is empty? Show your server logs here (delete mage-server/mageserver.log , start server and copy logs here or to https://pastebin.com/ )
EikePeace
@EikePeace
the server is not empty, it doesn't have any cards in the database