Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • 02:39

    theelk801 on master

    [UNF] added set [UNF] Implemented The Space Fam… added cardutil method for incre… and 1 more (compare)

  • 02:38
    theelk801 commented #8491
  • 02:38
    theelk801 commented #8491
  • 02:37
    theelk801 labeled #8491
  • 02:37
    theelk801 opened #8491
  • Nov 29 03:50
    github-actions[bot] commented #8490
  • Nov 29 03:50
    copperfield42 opened #8490
  • Nov 28 20:27
    theelk801 synchronize #8164
  • Nov 28 20:25
    theelk801 closed #8482
  • Nov 28 20:25

    theelk801 on master

    fixed validation for partner wi… (compare)

  • Nov 28 16:54
    dashosa opened #8489
  • Nov 28 03:31
    CCTV-1 commented #8470
  • Nov 27 22:46
    theelk801 commented #8482
  • Nov 27 22:46
    theelk801 assigned #8482
  • Nov 27 22:44
    JayDi85 commented on 7da2985
  • Nov 27 22:42

    JayDi85 on master

    Images: added direct image link… (compare)

  • Nov 27 19:19
    Bdett151 commented #8482
  • Nov 27 19:11
    JayDi85 closed #8443
  • Nov 27 19:11
    JayDi85 commented #8443
  • Nov 27 19:10

    JayDi85 on master

    * Images: fixed wrong token fil… (compare)

Oleg Agafonov
@JayDi85
4 - Some cards needs extra info about battlefield state like "make damage equals to creatures controlled". You can add that info to card text as special hints: search code for examples: .addHint(
Alexander Luyten
@imgifty
yes! I started on implementing Commander 19 cards. I'm having some issues running my client though. I get NullPointerExceptions trying to load the CardPluginImpl. Also I had to add Javafx Dependencies to the Maven xml file. Is that correct?
Alexander Luyten
@imgifty
this is the ouput, when I try to run the client: https://hastebin.com/odufonozos.coffeescript
Oleg Agafonov
@JayDi85
You oracle's java 8 to run
Don't try to implement commander 2019 -- @theelk801 already implemented it. There are only very difficult cards (not for novice). The older set -- the easiest missing card to implement.
shot_190818_172504.png
Oleg Agafonov
@JayDi85
shot_190818_172649.png
You can use any java 8 versions.
You don't need to add any libs to maven files - it's already works fine and imports by intellij idea.
Alexander Luyten
@imgifty
okay, I got it to work! Which sets are you talking about? I can start with those cards as well!
Oleg Agafonov
@JayDi85
Use that issue search to find out missing cards: https://github.com/magefree/mage/labels/tracking%20set
EikePeace
@EikePeace
A quick question: A friend and I were thinking of setting up a private xMage server, but we're not sure about the OS we should use.
Would you recommend Windows or does it work on Linux as well?
Oleg Agafonov
@JayDi85
@EikePeace you can use any system for server. Wiki have instructions for local server setup too: https://github.com/magefree/mage/wiki#running-local-server
You can run it on your computer, connect to it from same computer and connect to it from friend's.
EikePeace
@EikePeace

Okay, the server is running now, we are working on opening the ports

But, there are no cards on there

Should I just delete the db foder and make a clean install?
EikePeace
@EikePeace

Okay, it doesn't create a card database for clean install

Any ideas why?

Oleg Agafonov
@JayDi85
db creates on startup on missing db... You must delete db folder from mage-server folder, not from mage-client (it's a different).
EikePeace
@EikePeace
It still creates an empty one :/
Oleg Agafonov
@JayDi85
mage-server/db folder is empty? Show your server logs here (delete mage-server/mageserver.log , start server and copy logs here or to https://pastebin.com/ )
EikePeace
@EikePeace
the server is not empty, it doesn't have any cards in the database
THe decks on a testing server are empty for example
Oleg Agafonov
@JayDi85
What you mean by "empty decks"? Server shows missing card error on game start? Or what?
EikePeace
@EikePeace
No, the decks are literally empty
Not even lands exist
The databases are just empty
It is as if no cards would have been ever created
And the test games all end in a draw
Oleg Agafonov
@JayDi85
Show me server's logs file
ingmargoudt
@ingmargoudt
Could anyone check my fix for Jeskai's Infiltrator ?
there was an endless loop that causes a server crash (I think an out of memory or a stackoverflow exception)
ingmargoudt
@ingmargoudt
but I am not sure this fix is that easy..
ingmargoudt
@ingmargoudt

also, I am interested in this:

  @Deprecated
    void discard(int amount, Ability source, Game game);

    Card discardOne(boolean random, Ability source, Game game);

    Cards discard(int amount, boolean random, Ability source, Game game);

    boolean discard(Card card, Ability source, Game game);

The top method is deprecated and internally calls the 3rd method. The 4th method discards a particular card. So since the top method is deprecated , should we remove it and replace all instances with discard(int amount, boolean random, Ability source, Game game); ? And what about discardOne(random...) ?

Oleg Agafonov
@JayDi85
If void discard( uses by few cards then you can remove it, but if it uses in many cards then save it (there are many simplified methods with less params to call for more easy devs).
Evan Kranzler
@theelk801
probably gonna need some help implementing adventure cards, I have an outline of what I've got in mind on the tracking thread #5961
Zach H
@ZeldaZach
I’ll give it a gander tomorrow
I’d reckon it’s similar to aftermath tho
Evan Kranzler
@theelk801
aftermath is way simpler, it's just a split card with an ability that says "cast this only from your graveyard"
this has a whole bunch of extra rules baggage
Evan Kranzler
@theelk801
the important thing is that we can probably implement them in a way where we can add each card even if the overall implementation doesn't work
Evan Kranzler
@theelk801
would anyone be able to help with fixing Leadership Vacuum? it turns out that the engine doesn't support moving cards to the command zone and I'm not sure how to make it work as zone changes are very complicated and confusing
Zach H
@ZeldaZach
Move to exile and use standard replacement?
Evan Kranzler
@theelk801
I can't even find where the commander replacement happens
Oleg Agafonov
@JayDi85
Zone changes works fine. Look at CommanderReplacementEffect
ZoneChangeEvent zEvent = (ZoneChangeEvent) event;
zEvent.setToZone(Zone.COMMAND);
Evan Kranzler
@theelk801
oh, interesting
but how do we make that actually work
Oleg Agafonov
@JayDi85
You can just add command zone support in public boolean moveCards(Set<Card> cards, Zone toZone,
I don't think it different with other zones like library or outside